mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/sdk/objc/helpers
History
Artem Titov 63ee39d0be Revert "Add a prefix for objc category." 
This reverts commit 181ea6e414.

Reason for revert: Breaks downstream project. Kári will help to land it next week.

Original change's description:
> Add a prefix for objc category.
>
> According to the Google Objective-C style [1], category names should
> start with an appropriate prefix. WebRTC has some category definitions
> for system interfaces, but it doesn't use prefixes.
>
> $ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC"
> 0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile
> 0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition
> 0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString
> 0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView
>
> To avoid conflicts, prefix the names and methods of those categories.
> Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as
> it is not used by any other files.
>
> [1] https://google.github.io/styleguide/objcguide.html#category-naming
>
> Bug: webrtc:13884
> Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36880}

Bug: webrtc:13884
Change-Id: I85257088e4a3a62e01ff925ab5e77af83b078ef3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262420
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36885}
2022-05-13 14:47:54 +00:00
..
AVCaptureSession+DevicePosition.h Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
AVCaptureSession+DevicePosition.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
noop.mm Obj-C SDK Cleanup 2018-08-30 10:42:41 +00:00
NSString+StdString.h Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
NSString+StdString.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCCameraPreviewView.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCCameraPreviewView.m Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDispatcher+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDispatcher.h Implement network monitor for iOS. 2020-08-20 21:46:18 +00:00
RTCDispatcher.m Implement network monitor for iOS. 2020-08-20 21:46:18 +00:00
scoped_cftyperef.h Obj-C SDK Cleanup 2018-08-30 10:42:41 +00:00
UIDevice+RTCDevice.h Added new apple devices. 2022-03-29 15:40:35 +00:00
UIDevice+RTCDevice.mm Added new apple devices. 2022-03-29 15:40:35 +00:00