mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
0dd1b0a4b2
This reverts commit00733015fa. Reason for revert: The reason for a downstream test failure on the original commit and a workaround has been found. Solution is to keep a PeerConnectionFactory constructor implementation as the same as before. Original change's description: > Revert "Enables PeerConnectionFactory using external fec controller" > > This reverts commit4f07bdb255. > > Reason for revert: Speculatively reverting, because downstream test is now hitting "PeerConnectionFactory.initialize was not called before creating a PeerConnectionFactory" error, even though it did call initialize. I don't see how any change in this CL could cause that, but it's the only CL on the blamelist, and it does modify PeerConnectionFactory.java > > Original change's description: > > Enables PeerConnectionFactory using external fec controller > > > > Bug: webrtc:8799 > > Change-Id: Ieb2cf6163b9a83844ab9ed4822b4a7f1db4c24b8 > > Reviewed-on: https://webrtc-review.googlesource.com/43961 > > Commit-Queue: Ying Wang <yinwa@webrtc.org> > > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22038} > > TBR=sakal@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,stefan@webrtc.org,yinwa@webrtc.org > > Change-Id: I95868c35d6f9973e0ebf563814cd71d0fcbd433d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8799 > Reviewed-on: https://webrtc-review.googlesource.com/54080 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22040} TBR=deadbeef@webrtc.org,sakal@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,stefan@webrtc.org,yinwa@webrtc.org Bug: webrtc:8799 Change-Id: If9f3292bfcc739782967530c49f006d0abbc38a8 Reviewed-on: https://webrtc-review.googlesource.com/55400 Commit-Queue: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22100}
58 lines
2.3 KiB
C++
58 lines
2.3 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef MODULES_VIDEO_CODING_FEC_CONTROLLER_DEFAULT_H_
|
|
#define MODULES_VIDEO_CODING_FEC_CONTROLLER_DEFAULT_H_
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
#include "api/fec_controller.h"
|
|
#include "modules/include/module_common_types.h"
|
|
#include "modules/video_coding/media_opt_util.h"
|
|
#include "rtc_base/criticalsection.h"
|
|
#include "system_wrappers/include/clock.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class FecControllerDefault : public FecController {
|
|
public:
|
|
FecControllerDefault(Clock* clock,
|
|
VCMProtectionCallback* protection_callback);
|
|
explicit FecControllerDefault(Clock* clock);
|
|
~FecControllerDefault();
|
|
void SetProtectionCallback(
|
|
VCMProtectionCallback* protection_callback) override;
|
|
void SetProtectionMethod(bool enable_fec, bool enable_nack) override;
|
|
void SetEncodingData(size_t width,
|
|
size_t height,
|
|
size_t num_temporal_layers,
|
|
size_t max_payload_size) override;
|
|
uint32_t UpdateFecRates(uint32_t estimated_bitrate_bps,
|
|
int actual_framerate_fps,
|
|
uint8_t fraction_lost,
|
|
std::vector<bool> loss_mask_vector,
|
|
int64_t round_trip_time_ms) override;
|
|
void UpdateWithEncodedData(const size_t encoded_image_length,
|
|
const FrameType encoded_image_frametype) override;
|
|
bool UseLossVectorMask() override { return false; }
|
|
|
|
private:
|
|
enum { kBitrateAverageWinMs = 1000 };
|
|
Clock* const clock_;
|
|
VCMProtectionCallback* protection_callback_;
|
|
rtc::CriticalSection crit_sect_;
|
|
std::unique_ptr<media_optimization::VCMLossProtectionLogic> loss_prot_logic_
|
|
RTC_GUARDED_BY(crit_sect_);
|
|
size_t max_payload_size_ RTC_GUARDED_BY(crit_sect_);
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(FecControllerDefault);
|
|
};
|
|
|
|
} // namespace webrtc
|
|
#endif // MODULES_VIDEO_CODING_FEC_CONTROLLER_DEFAULT_H_
|