mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-14 22:30:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/infra/config
History
Mirko Bonadei 5c8993cba0 Reland "Add 2 additional tests config in waterfalls.pyl." 
This reverts commit b5ab062a3e.

Reason for revert: The CL was not the culprit.

Original change's description:
> Revert "Add 2 additional tests config in waterfalls.pyl."
>
> This reverts commit 429c1bd74d.
>
> Reason for revert: It breaks some CQ bots (e.g. https://ci.chromium.org/ui/p/webrtc/builders/try/linux_compile_rel/42825/overview). I am reverting to check is this is the culprit.
>
> Original change's description:
> > Add 2 additional tests config in waterfalls.pyl.
> >
> > * Add a presubmit check that generate_builbot_json.py has been called.
> > * Add a webrtc_mixins.pyl file.
> >
> > Bug: webrtc:13899
> > Change-Id: I7c4226ddd80bf9376bcb91476a1446a0392e7ec6
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257904
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#36428}
>
> Bug: webrtc:13899
> Change-Id: Ic79306688c26937a988a9eacb4799f53f7145c65
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257919
> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36431}

Bug: webrtc:13899
Change-Id: Id0ac9a98744fa5019cbb69bbd1e53e138f887e9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257980
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36433}
2022-04-04 19:11:38 +00:00
..
generated Reland "Add 2 additional tests config in waterfalls.pyl." 2022-04-04 19:11:38 +00:00
luci-notify/email-templates Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
chops-weetbix-dev.cfg Add WebRTC Weetbix config 2022-03-29 13:57:01 +00:00
chops-weetbix.cfg Add WebRTC Weetbix config 2022-03-29 13:57:01 +00:00
codereview.settings Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
commit-queue.cfg Return linux bots to cq and lkgr as the issue with them is fixed 2022-04-04 08:23:13 +00:00
config.star Return linux bots to cq and lkgr as the issue with them is fixed 2022-04-04 08:23:13 +00:00
console-header.textpb Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
cr-buildbucket.cfg Return linux bots to cq and lkgr as the issue with them is fixed 2022-04-04 08:23:13 +00:00
luci-logdog.cfg Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
luci-milo.cfg Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
luci-notify.cfg Return linux bots to cq and lkgr as the issue with them is fixed 2022-04-04 08:23:13 +00:00
luci-scheduler.cfg Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
PRESUBMIT.py Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
project.cfg Temporarily remove red bots from CQ and LKGR until they are fixed 2022-03-30 14:18:34 +00:00
README.md Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00
realms.cfg Copy infra/config in the main branch. 2022-03-14 07:45:10 +00:00

README.md

infra/config folder

This folder contains WebRTC project-wide configurations for Chrome infra services, mainly the CI system (console).

*.cfg files are the actual configuration that LUCI looks at. They are in protocol buffer text format. For example, cr-buildbucket.cfg defines builders.

However, they are all automatically generated from the Starlark script config.star that defines a unified config using lucicfg. The main body of the config is at the bottom of the file, following all the helper definitions.

lucicfg should be available as part of depot_tools. After editing config.star you should run lucicfg generate config.star to re-generate *.cfg files. Check the diffs in generated files to confirm that your change worked as expected. Both the code change and the generated changes need to be committed together.

Uploading changes

It is recommended to have a separate checkout for this branch, so switching to/from it does not populate/delete all files in the master branch.

Initial setup:

git clone https://webrtc.googlesource.com/src/

Now you can create a new branch to make changes:

git new-branch add-new-builder
# edit/generate files
git commit -a
git cl upload

Changes can be reviewed on Gerrit and submitted with commit queue as usual.

Activating the changes

Any changes to this directory go live soon after landing, without any additional steps. You can see the status or force a refresh of the config at luci-config.