mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 14:20:45 +01:00
ad5037b4a8
This reverts commit793bac569f. Reason for revert: rare compilation error fixed Original change's description: > Revert "Refactor the PlatformThread API." > > This reverts commitc89fdd716c. > > Reason for revert: Causes rare compilation error on win-libfuzzer-asan trybot. > See https://ci.chromium.org/p/chromium/builders/try/win-libfuzzer-asan-rel/713745? > > Original change's description: > > Refactor the PlatformThread API. > > > > PlatformThread's API is using old style function pointers, causes > > casting, is unintuitive and forces artificial call sequences, and > > is additionally possible to misuse in release mode. > > > > Fix this by an API face lift: > > 1. The class is turned into a handle, which can be empty. > > 2. The only way of getting a non-empty PlatformThread is by calling > > SpawnJoinable or SpawnDetached, clearly conveying the semantics to the > > code reader. > > 3. Handles can be Finalized, which works differently for joinable and > > detached threads: > > a) Handles for detached threads are simply closed where applicable. > > b) Joinable threads are joined before handles are closed. > > 4. The destructor finalizes handles. No explicit call is needed. > > > > Fixed: webrtc:12727 > > Change-Id: Id00a0464edf4fc9e552b6a1fbb5d2e1280e88811 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215075 > > Commit-Queue: Markus Handell <handellm@webrtc.org> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Tommi <tommi@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#33923} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR=handellm@webrtc.org > > Bug: webrtc:12727 > Change-Id: Ic0146be8866f6dd3ad9c364fb8646650b8e07419 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217583 > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Reviewed-by: Markus Handell <handellm@webrtc.org> > Commit-Queue: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33936} # Not skipping CQ checks because this is a reland. Bug: webrtc:12727 Change-Id: Ifd6f44eac72fed84474277a1be03eb84d2f4376e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217881 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33950}
94 lines
2.1 KiB
C++
94 lines
2.1 KiB
C++
/*
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/event.h"
|
|
|
|
#include "rtc_base/platform_thread.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace rtc {
|
|
|
|
TEST(EventTest, InitiallySignaled) {
|
|
Event event(false, true);
|
|
ASSERT_TRUE(event.Wait(0));
|
|
}
|
|
|
|
TEST(EventTest, ManualReset) {
|
|
Event event(true, false);
|
|
ASSERT_FALSE(event.Wait(0));
|
|
|
|
event.Set();
|
|
ASSERT_TRUE(event.Wait(0));
|
|
ASSERT_TRUE(event.Wait(0));
|
|
|
|
event.Reset();
|
|
ASSERT_FALSE(event.Wait(0));
|
|
}
|
|
|
|
TEST(EventTest, AutoReset) {
|
|
Event event;
|
|
ASSERT_FALSE(event.Wait(0));
|
|
|
|
event.Set();
|
|
ASSERT_TRUE(event.Wait(0));
|
|
ASSERT_FALSE(event.Wait(0));
|
|
}
|
|
|
|
class SignalerThread {
|
|
public:
|
|
void Start(Event* writer, Event* reader) {
|
|
writer_ = writer;
|
|
reader_ = reader;
|
|
thread_ = PlatformThread::SpawnJoinable(
|
|
[this] {
|
|
while (!stop_event_.Wait(0)) {
|
|
writer_->Set();
|
|
reader_->Wait(Event::kForever);
|
|
}
|
|
},
|
|
"EventPerf");
|
|
}
|
|
void Stop() {
|
|
stop_event_.Set();
|
|
thread_.Finalize();
|
|
}
|
|
Event stop_event_;
|
|
Event* writer_;
|
|
Event* reader_;
|
|
PlatformThread thread_;
|
|
};
|
|
|
|
// These tests are disabled by default and only intended to be run manually.
|
|
TEST(EventTest, DISABLED_PerformanceSingleThread) {
|
|
static const int kNumIterations = 10000000;
|
|
Event event;
|
|
for (int i = 0; i < kNumIterations; ++i) {
|
|
event.Set();
|
|
event.Wait(0);
|
|
}
|
|
}
|
|
|
|
TEST(EventTest, DISABLED_PerformanceMultiThread) {
|
|
static const int kNumIterations = 10000;
|
|
Event read;
|
|
Event write;
|
|
SignalerThread thread;
|
|
thread.Start(&read, &write);
|
|
|
|
for (int i = 0; i < kNumIterations; ++i) {
|
|
write.Set();
|
|
read.Wait(Event::kForever);
|
|
}
|
|
write.Set();
|
|
|
|
thread.Stop();
|
|
}
|
|
|
|
} // namespace rtc
|