mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
181ea6e414
According to the Google Objective-C style [1], category names should
start with an appropriate prefix. WebRTC has some category definitions
for system interfaces, but it doesn't use prefixes.
$ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC"
0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile
0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition
0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString
0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView
To avoid conflicts, prefix the names and methods of those categories.
Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as
it is not used by any other files.
[1] https://google.github.io/styleguide/objcguide.html#category-naming
Bug: webrtc:13884
Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36880}
51 lines
2.1 KiB
Text
51 lines
2.1 KiB
Text
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "AVCaptureSession+RTCDevicePosition.h"
|
|
|
|
BOOL CFStringContainsString(CFStringRef theString, CFStringRef stringToFind) {
|
|
return CFStringFindWithOptions(theString,
|
|
stringToFind,
|
|
CFRangeMake(0, CFStringGetLength(theString)),
|
|
kCFCompareCaseInsensitive,
|
|
nil);
|
|
}
|
|
|
|
@implementation AVCaptureSession (RTCDevicePosition)
|
|
|
|
+ (AVCaptureDevicePosition)rtc_devicePositionForSampleBuffer:(CMSampleBufferRef)sampleBuffer {
|
|
// Check the image's EXIF for the camera the image came from.
|
|
AVCaptureDevicePosition cameraPosition = AVCaptureDevicePositionUnspecified;
|
|
CFDictionaryRef attachments = CMCopyDictionaryOfAttachments(
|
|
kCFAllocatorDefault, sampleBuffer, kCMAttachmentMode_ShouldPropagate);
|
|
if (attachments) {
|
|
int size = CFDictionaryGetCount(attachments);
|
|
if (size > 0) {
|
|
CFDictionaryRef cfExifDictVal = nil;
|
|
if (CFDictionaryGetValueIfPresent(
|
|
attachments, (const void *)CFSTR("{Exif}"), (const void **)&cfExifDictVal)) {
|
|
CFStringRef cfLensModelStrVal;
|
|
if (CFDictionaryGetValueIfPresent(cfExifDictVal,
|
|
(const void *)CFSTR("LensModel"),
|
|
(const void **)&cfLensModelStrVal)) {
|
|
if (CFStringContainsString(cfLensModelStrVal, CFSTR("front"))) {
|
|
cameraPosition = AVCaptureDevicePositionFront;
|
|
} else if (CFStringContainsString(cfLensModelStrVal, CFSTR("back"))) {
|
|
cameraPosition = AVCaptureDevicePositionBack;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
CFRelease(attachments);
|
|
}
|
|
return cameraPosition;
|
|
}
|
|
|
|
@end
|