mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
184da528a7
There is a value missing in an array, causing indexing to sometimes be off by one. The result is never used anyway, so the "solution" is to insert an extra zero at the end. Details: In an old refactoring CL, the corresponding array in the floating point version of iSAC is declared with 578 elements, the fixed point version has 577. See WebRtcIsac_kQKltCodeLenShape: https://webrtc-codereview.appspot.com/548004/patch/10002/11005 Perhaps the entire array was not carried over to fixed point. However, the floating point version does not actually have 578 elements in its definition, it has 568. The remaining 10 elements are initialized to 0. So there is no value to use from there, and using a zero instead will mimic the behavior of the floating point code. Use of the value: WebRtcIsacfix_kCodeLenShapeQ11 is only accessed in one place [0]. The value sumQQ is set to is only used to compute the BitsQQ, which is only used to populate the sizeQ11 param of EstCodeLpcCoef, which is never used anywhere. Not within EstCodeLpcCoef, not within the calling function WebRtcIsacfix_EncodeLpc [1], not in the calling function's calling function [2]. Then it falls out of scope. [0] https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c?l=1223&rcl=3c4fda2ed8140a330634c0a2704a3cf0311a89de [1] https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c?l=1468&rcl=3c4fda2ed8140a330634c0a2704a3cf0311a89de [2] https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c?l=214&rcl=3c4fda2ed8140a330634c0a2704a3cf0311a89de Tested: Instructions in linked bug. No longer repro after applying this CL. Bug: webrtc:10584 Change-Id: I87a90e8cf58d82f615217e05ea401d3259887769 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161942 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30065}
97 lines
3.1 KiB
C
97 lines
3.1 KiB
C
/*
|
|
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
/*
|
|
* lpc_tables.h
|
|
*
|
|
* header file for coding tables for the LPC coefficients
|
|
*
|
|
*/
|
|
|
|
#ifndef MODULES_AUDIO_CODING_CODECS_ISAC_FIX_SOURCE_LPC_TABLES_H_
|
|
#define MODULES_AUDIO_CODING_CODECS_ISAC_FIX_SOURCE_LPC_TABLES_H_
|
|
|
|
#include <stdint.h>
|
|
|
|
/* indices of KLT coefficients used */
|
|
extern const uint16_t WebRtcIsacfix_kSelIndGain[12];
|
|
|
|
extern const uint16_t WebRtcIsacfix_kSelIndShape[108];
|
|
|
|
/* cdf array for model indicator */
|
|
extern const uint16_t WebRtcIsacfix_kModelCdf[KLT_NUM_MODELS + 1];
|
|
|
|
/* pointer to cdf array for model indicator */
|
|
extern const uint16_t* WebRtcIsacfix_kModelCdfPtr[1];
|
|
|
|
/* initial cdf index for decoder of model indicator */
|
|
extern const uint16_t WebRtcIsacfix_kModelInitIndex[1];
|
|
|
|
/* offset to go from rounded value to quantization index */
|
|
extern const int16_t WebRtcIsacfix_kQuantMinGain[12];
|
|
|
|
extern const int16_t WebRtcIsacfix_kQuantMinShape[108];
|
|
|
|
/* maximum quantization index */
|
|
extern const uint16_t WebRtcIsacfix_kMaxIndGain[12];
|
|
|
|
extern const uint16_t WebRtcIsacfix_kMaxIndShape[108];
|
|
|
|
/* index offset */
|
|
extern const uint16_t WebRtcIsacfix_kOffsetGain[KLT_NUM_MODELS][12];
|
|
|
|
extern const uint16_t WebRtcIsacfix_kOffsetShape[KLT_NUM_MODELS][108];
|
|
|
|
/* initial cdf index for KLT coefficients */
|
|
extern const uint16_t WebRtcIsacfix_kInitIndexGain[KLT_NUM_MODELS][12];
|
|
|
|
extern const uint16_t WebRtcIsacfix_kInitIndexShape[KLT_NUM_MODELS][108];
|
|
|
|
/* offsets for quantizer representation levels */
|
|
extern const uint16_t WebRtcIsacfix_kOfLevelsGain[3];
|
|
|
|
extern const uint16_t WebRtcIsacfix_kOfLevelsShape[3];
|
|
|
|
/* quantizer representation levels */
|
|
extern const int32_t WebRtcIsacfix_kLevelsGainQ17[1176];
|
|
|
|
extern const int16_t WebRtcIsacfix_kLevelsShapeQ10[1735];
|
|
|
|
/* cdf tables for quantizer indices */
|
|
extern const uint16_t WebRtcIsacfix_kCdfGain[1212];
|
|
|
|
extern const uint16_t WebRtcIsacfix_kCdfShape[2059];
|
|
|
|
/* pointers to cdf tables for quantizer indices */
|
|
extern const uint16_t* WebRtcIsacfix_kCdfGainPtr[KLT_NUM_MODELS][12];
|
|
|
|
extern const uint16_t* WebRtcIsacfix_kCdfShapePtr[KLT_NUM_MODELS][108];
|
|
|
|
/* code length for all coefficients using different models */
|
|
extern const int16_t WebRtcIsacfix_kCodeLenGainQ11[392];
|
|
|
|
extern const int16_t WebRtcIsacfix_kCodeLenShapeQ11[578];
|
|
|
|
/* left KLT transforms */
|
|
extern const int16_t WebRtcIsacfix_kT1GainQ15[KLT_NUM_MODELS][4];
|
|
|
|
extern const int16_t WebRtcIsacfix_kT1ShapeQ15[KLT_NUM_MODELS][324];
|
|
|
|
/* right KLT transforms */
|
|
extern const int16_t WebRtcIsacfix_kT2GainQ15[KLT_NUM_MODELS][36];
|
|
|
|
extern const int16_t WebRtcIsacfix_kT2ShapeQ15[KLT_NUM_MODELS][36];
|
|
|
|
/* means of log gains and LAR coefficients */
|
|
extern const int16_t WebRtcIsacfix_kMeansGainQ8[KLT_NUM_MODELS][12];
|
|
|
|
extern const int32_t WebRtcIsacfix_kMeansShapeQ17[3][108];
|
|
|
|
#endif /* MODULES_AUDIO_CODING_CODECS_ISAC_FIX_SOURCE_LPC_TABLES_H_ */
|