mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-19 08:37:54 +01:00

This reverts commit 181ea6e414
.
Reason for revert: Breaks downstream project. Kári will help to land it next week.
Original change's description:
> Add a prefix for objc category.
>
> According to the Google Objective-C style [1], category names should
> start with an appropriate prefix. WebRTC has some category definitions
> for system interfaces, but it doesn't use prefixes.
>
> $ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC"
> 0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile
> 0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition
> 0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString
> 0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView
>
> To avoid conflicts, prefix the names and methods of those categories.
> Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as
> it is not used by any other files.
>
> [1] https://google.github.io/styleguide/objcguide.html#category-naming
>
> Bug: webrtc:13884
> Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36880}
Bug: webrtc:13884
Change-Id: I85257088e4a3a62e01ff925ab5e77af83b078ef3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262420
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36885}
174 lines
5.6 KiB
Text
174 lines
5.6 KiB
Text
/*
|
|
* Copyright 2017 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import <UIKit/UIKit.h>
|
|
|
|
#include "test/ios/coverage_util_ios.h"
|
|
#include "test/ios/google_test_runner_delegate.h"
|
|
#include "test/ios/test_support.h"
|
|
#include "test/testsupport/perf_test.h"
|
|
|
|
#import "sdk/objc/helpers/NSString+StdString.h"
|
|
|
|
// Springboard will kill any iOS app that fails to check in after launch within
|
|
// a given time. Starting a UIApplication before invoking TestSuite::Run
|
|
// prevents this from happening.
|
|
|
|
// InitIOSRunHook saves the TestSuite and argc/argv, then invoking
|
|
// RunTestsFromIOSApp calls UIApplicationMain(), providing an application
|
|
// delegate class: WebRtcUnitTestDelegate. The delegate implements
|
|
// application:didFinishLaunchingWithOptions: to invoke the TestSuite's Run
|
|
// method.
|
|
|
|
// Since the executable isn't likely to be a real iOS UI, the delegate puts up a
|
|
// window displaying the app name. If a bunch of apps using MainHook are being
|
|
// run in a row, this provides an indication of which one is currently running.
|
|
|
|
// If enabled, runs unittests using the XCTest test runner.
|
|
const char kEnableRunIOSUnittestsWithXCTest[] = "enable-run-ios-unittests-with-xctest";
|
|
|
|
static int (*g_test_suite)(void) = NULL;
|
|
static int g_argc;
|
|
static char **g_argv;
|
|
static bool g_write_perf_output;
|
|
static absl::optional<bool> g_is_xctest;
|
|
static absl::optional<std::vector<std::string>> g_metrics_to_plot;
|
|
|
|
@interface UIApplication (Testing)
|
|
- (void)_terminateWithStatus:(int)status;
|
|
@end
|
|
|
|
@interface WebRtcUnitTestDelegate : NSObject <GoogleTestRunnerDelegate> {
|
|
UIWindow *_window;
|
|
}
|
|
- (void)runTests;
|
|
@end
|
|
|
|
@implementation WebRtcUnitTestDelegate
|
|
|
|
- (BOOL)application:(UIApplication *)application
|
|
didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
|
|
CGRect bounds = [[UIScreen mainScreen] bounds];
|
|
|
|
_window = [[UIWindow alloc] initWithFrame:bounds];
|
|
[_window setBackgroundColor:[UIColor whiteColor]];
|
|
[_window makeKeyAndVisible];
|
|
|
|
// Add a label with the app name.
|
|
UILabel *label = [[UILabel alloc] initWithFrame:bounds];
|
|
label.text = [[NSProcessInfo processInfo] processName];
|
|
label.textAlignment = NSTextAlignmentCenter;
|
|
[_window addSubview:label];
|
|
|
|
// An NSInternalInconsistencyException is thrown if the app doesn't have a
|
|
// root view controller. Set an empty one here.
|
|
[_window setRootViewController:[[UIViewController alloc] init]];
|
|
|
|
if (!rtc::test::ShouldRunIOSUnittestsWithXCTest()) {
|
|
// When running in XCTest mode, XCTest will invoke `runGoogleTest` directly.
|
|
// Otherwise, schedule a call to `runTests`.
|
|
[self performSelector:@selector(runTests) withObject:nil afterDelay:0.1];
|
|
}
|
|
|
|
return YES;
|
|
}
|
|
|
|
- (BOOL)supportsRunningGoogleTests {
|
|
return rtc::test::ShouldRunIOSUnittestsWithXCTest();
|
|
}
|
|
|
|
- (int)runGoogleTests {
|
|
rtc::test::ConfigureCoverageReportPath();
|
|
|
|
int exitStatus = g_test_suite();
|
|
|
|
if (g_write_perf_output) {
|
|
// Stores data into a proto file under the app's document directory.
|
|
NSString *fileName = @"perftest-output.pb";
|
|
NSArray<NSString *> *outputDirectories =
|
|
NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
|
|
if ([outputDirectories count] != 0) {
|
|
NSString *outputPath = [outputDirectories[0] stringByAppendingPathComponent:fileName];
|
|
|
|
if (!webrtc::test::WritePerfResults([NSString stdStringForString:outputPath])) {
|
|
return 1;
|
|
}
|
|
}
|
|
}
|
|
if (g_metrics_to_plot) {
|
|
webrtc::test::PrintPlottableResults(*g_metrics_to_plot);
|
|
}
|
|
|
|
return exitStatus;
|
|
}
|
|
|
|
- (void)runTests {
|
|
RTC_DCHECK(!rtc::test::ShouldRunIOSUnittestsWithXCTest());
|
|
rtc::test::ConfigureCoverageReportPath();
|
|
|
|
int exitStatus = [self runGoogleTests];
|
|
|
|
// If a test app is too fast, it will exit before Instruments has has a
|
|
// a chance to initialize and no test results will be seen.
|
|
// TODO(crbug.com/137010): Figure out how much time is actually needed, and
|
|
// sleep only to make sure that much time has elapsed since launch.
|
|
[NSThread sleepUntilDate:[NSDate dateWithTimeIntervalSinceNow:2.0]];
|
|
|
|
// Use the hidden selector to try and cleanly take down the app (otherwise
|
|
// things can think the app crashed even on a zero exit status).
|
|
UIApplication *application = [UIApplication sharedApplication];
|
|
[application _terminateWithStatus:exitStatus];
|
|
|
|
exit(exitStatus);
|
|
}
|
|
|
|
@end
|
|
namespace rtc {
|
|
namespace test {
|
|
|
|
// Note: This is not thread safe, and must be called from the same thread as
|
|
// runTests above.
|
|
void InitTestSuite(int (*test_suite)(void),
|
|
int argc,
|
|
char *argv[],
|
|
bool write_perf_output,
|
|
absl::optional<std::vector<std::string>> metrics_to_plot) {
|
|
g_test_suite = test_suite;
|
|
g_argc = argc;
|
|
g_argv = argv;
|
|
g_write_perf_output = write_perf_output;
|
|
g_metrics_to_plot = std::move(metrics_to_plot);
|
|
}
|
|
|
|
void RunTestsFromIOSApp() {
|
|
@autoreleasepool {
|
|
exit(UIApplicationMain(g_argc, g_argv, nil, @"WebRtcUnitTestDelegate"));
|
|
}
|
|
}
|
|
|
|
bool ShouldRunIOSUnittestsWithXCTest() {
|
|
if (g_is_xctest.has_value()) {
|
|
return g_is_xctest.value();
|
|
}
|
|
|
|
char **argv = g_argv;
|
|
while (*argv != nullptr) {
|
|
if (strstr(*argv, kEnableRunIOSUnittestsWithXCTest) != nullptr) {
|
|
g_is_xctest = absl::optional<bool>(true);
|
|
return true;
|
|
}
|
|
argv++;
|
|
}
|
|
g_is_xctest = absl::optional<bool>(false);
|
|
return false;
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace rtc
|