mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 06:40:43 +01:00
2394977f74
This CL includes: * set Pylint to 2.7 in tools_webrtc/mb/PRESUBMIT.py * fix some style warnings caused by scripts in tools_webrtc/mb/ * pass skip_shebang_check=True within tools_webrtc/mb/PRESUBMIT.py Bug: chromium:1262287, chromium:1262352 Change-Id: Iae4f111942d724db6a7f4585c97a7c26c1e6ccc0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239660 Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35477}
60 lines
1.9 KiB
Python
60 lines
1.9 KiB
Python
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
results = []
|
|
|
|
# Run Pylint over the files in the directory.
|
|
pylint_checks = input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
version='2.7',
|
|
# Disabling certain python3-specific warnings until the conversion
|
|
# is complete.
|
|
disabled_warnings=[
|
|
'super-with-arguments',
|
|
'raise-missing-from',
|
|
'useless-object-inheritance',
|
|
'arguments-differ',
|
|
],
|
|
)
|
|
results.extend(input_api.RunTests(pylint_checks))
|
|
|
|
# Run the MB unittests.
|
|
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
'.',
|
|
[ r'^.+_unittest\.py$'],
|
|
skip_shebang_check=True))
|
|
|
|
# Validate the format of the mb_config.pyl file.
|
|
cmd = [input_api.python_executable, 'mb.py', 'validate']
|
|
kwargs = {'cwd': input_api.PresubmitLocalPath()}
|
|
results.extend(input_api.RunTests([
|
|
input_api.Command(name='mb_validate',
|
|
cmd=cmd, kwargs=kwargs,
|
|
message=output_api.PresubmitError)]))
|
|
|
|
results.extend(
|
|
input_api.canned_checks.CheckLongLines(
|
|
input_api,
|
|
output_api,
|
|
maxlen=80,
|
|
source_file_filter=lambda x: 'mb_config.pyl' in x.LocalPath()))
|
|
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|