webrtc/sdk/objc/Framework/Classes/Common/RTCCallbackLogger.mm
Jiawei Ou 9bb8f80c40 Make the default severity level of RTCCallbackLogger match the comment on its header.
The comment here said it is kRTCLoggingSeverityInfo

https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCallbackLogger.h?type=cs&q=RTCCallbacklogger&sq=package:chromium&g=0&l=23

Which is not true since objective c auto initailize all member to 0, the severity level will be verbose.


Bug: webrtc:9509
Change-Id: I894e2d8df33bf12bdf041cdee9e6dd3adef7fb12
Reviewed-on: https://webrtc-review.googlesource.com/87800
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23898}
2018-07-10 08:43:58 +00:00

92 lines
2 KiB
Text

/*
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#import "WebRTC/RTCCallbackLogger.h"
#include <memory>
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/logsinks.h"
class CallbackLogSink : public rtc::LogSink {
public:
CallbackLogSink(void (^callbackHandler)(NSString *message)) {
callback_handler_ = callbackHandler;
}
~CallbackLogSink() override { callback_handler_ = nil; }
void OnLogMessage(const std::string &message) override {
if (callback_handler_) {
callback_handler_([NSString stringWithUTF8String:message.c_str()]);
}
}
private:
void (^callback_handler_)(NSString *message);
};
@implementation RTCCallbackLogger {
BOOL _hasStarted;
std::unique_ptr<CallbackLogSink> _logSink;
}
@synthesize severity = _severity;
- (instancetype)init {
self = [super init];
if (self != nil) {
_severity = RTCLoggingSeverityInfo;
}
return self;
}
- (void)dealloc {
[self stop];
}
- (void)start:(nullable void (^)(NSString *))callback {
if (_hasStarted) {
return;
}
_logSink.reset(new CallbackLogSink(callback));
rtc::LogMessage::AddLogToStream(_logSink.get(), [self rtcSeverity]);
_hasStarted = YES;
}
- (void)stop {
if (!_hasStarted) {
return;
}
RTC_DCHECK(_logSink);
rtc::LogMessage::RemoveLogToStream(_logSink.get());
_hasStarted = NO;
_logSink.reset();
}
#pragma mark - Private
- (rtc::LoggingSeverity)rtcSeverity {
switch (_severity) {
case RTCLoggingSeverityVerbose:
return rtc::LS_VERBOSE;
case RTCLoggingSeverityInfo:
return rtc::LS_INFO;
case RTCLoggingSeverityWarning:
return rtc::LS_WARNING;
case RTCLoggingSeverityError:
return rtc::LS_ERROR;
}
}
@end