mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 06:10:40 +01:00
1c54605e77
This CL is a manual spin-off of [1], which tried to apply clang-tidy's performance-move-const-arg [1] to the WebRTC codebase. Since there were some wrong fixes to correct, this CL lands a few different fixes, like adding a constructor overload to take an rvalue reference or remove 'const' to make std::move effective. [1] - https://webrtc-review.googlesource.com/c/src/+/120350 [2] - https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html Bug: webrtc:10252 Change-Id: I42a777247fee2cb788efcd7c2035148330056b7a Reviewed-on: https://webrtc-review.googlesource.com/c/120928 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26553}
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef MODULES_AUDIO_DEVICE_AUDIO_DEVICE_NAME_H_
|
|
#define MODULES_AUDIO_DEVICE_AUDIO_DEVICE_NAME_H_
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
namespace webrtc {
|
|
|
|
struct AudioDeviceName {
|
|
// Unique ID of the generic default device.
|
|
static const char kDefaultDeviceId[];
|
|
|
|
// Unique ID of the generic default communications device.
|
|
static const char kDefaultCommunicationsDeviceId[];
|
|
|
|
AudioDeviceName() = default;
|
|
AudioDeviceName(std::string device_name, std::string unique_id);
|
|
|
|
~AudioDeviceName() = default;
|
|
|
|
// Support copy and move.
|
|
AudioDeviceName(const AudioDeviceName& other) = default;
|
|
AudioDeviceName(AudioDeviceName&&) = default;
|
|
AudioDeviceName& operator=(const AudioDeviceName&) = default;
|
|
AudioDeviceName& operator=(AudioDeviceName&&) = default;
|
|
|
|
bool IsValid();
|
|
|
|
std::string device_name; // Friendly name of the device.
|
|
std::string unique_id; // Unique identifier for the device.
|
|
};
|
|
|
|
typedef std::vector<AudioDeviceName> AudioDeviceNames;
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // MODULES_AUDIO_DEVICE_AUDIO_DEVICE_NAME_H_
|