mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
5b2eda4895
It's easy to make small errors when building field trial strings, and those errors can cause all sorts of weird problems. This CL checks if the FT string has an odd number of delimiters, duplicate names or any trailing chars. If so we'll log a error message. On debug builds we'll also crash. Bug: webrtc:10729 Change-Id: Iebf7155d9b117a02d1e9cfe7f64408e11df2aec5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140866 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28234}
53 lines
2.2 KiB
C++
53 lines
2.2 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "system_wrappers/include/field_trial.h"
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace field_trial {
|
|
#if GTEST_HAS_DEATH_TEST && RTC_DCHECK_IS_ON && !defined(WEBRTC_ANDROID) && \
|
|
!defined(WEBRTC_EXCLUDE_FIELD_TRIAL_DEFAULT)
|
|
TEST(FieldTrialValidationTest, AcceptsValidInputs) {
|
|
InitFieldTrialsFromString("");
|
|
InitFieldTrialsFromString("Audio/Enabled/");
|
|
InitFieldTrialsFromString("Audio/Enabled/Video/Disabled/");
|
|
|
|
// Duplicate trials with the same value is fine
|
|
InitFieldTrialsFromString("Audio/Enabled/Audio/Enabled/");
|
|
InitFieldTrialsFromString("Audio/Enabled/B/C/Audio/Enabled/");
|
|
}
|
|
|
|
TEST(FieldTrialValidationTest, RejectsBadInputs) {
|
|
// Bad delimiters
|
|
EXPECT_DEATH(InitFieldTrialsFromString("Audio/EnabledVideo/Disabled/"),
|
|
"Invalid field trials string:");
|
|
EXPECT_DEATH(InitFieldTrialsFromString("Audio/Enabled//Video/Disabled/"),
|
|
"Invalid field trials string:");
|
|
EXPECT_DEATH(InitFieldTrialsFromString("/Audio/Enabled/Video/Disabled/"),
|
|
"Invalid field trials string:");
|
|
EXPECT_DEATH(InitFieldTrialsFromString("Audio/Enabled/Video/Disabled"),
|
|
"Invalid field trials string:");
|
|
EXPECT_DEATH(
|
|
InitFieldTrialsFromString("Audio/Enabled/Video/Disabled/garbage"),
|
|
"Invalid field trials string:");
|
|
|
|
// Duplicate trials with different values is not fine
|
|
EXPECT_DEATH(InitFieldTrialsFromString("Audio/Enabled/Audio/Disabled/"),
|
|
"Invalid field trials string:");
|
|
EXPECT_DEATH(InitFieldTrialsFromString("Audio/Enabled/B/C/Audio/Disabled/"),
|
|
"Invalid field trials string:");
|
|
}
|
|
#endif // GTEST_HAS_DEATH_TEST && RTC_DCHECK_IS_ON && !defined(WEBRTC_ANDROID)
|
|
// && !defined(WEBRTC_EXCLUDE_FIELD_TRIAL_DEFAULT)
|
|
|
|
} // namespace field_trial
|
|
} // namespace webrtc
|