mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00

When a HEARTBEAT is sent out, the current timestamp is stored in the parameter that will be returned by the HEARTBEAT-ACK. If the timestamp from the HEARTBEAT-ACK would be from the future (either by jumping clocks, bit errors, exploiting peer or a fuzzer), the measured RTT would become really large, and when it was calculated, it would result in an integer overflow; a wrapping subtraction. This isn't a problem, as RetransmissionTimeout::ObserveRTT method would discard measurements that were negative or too large, but it would trigger an UBSAN violation. Adding an additional check so that the subtraction doesn't ever wrap. Bug: chromium:1252515 Change-Id: I1f97b1e773a4639b8193a528716ebd6a27fcb740 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232904 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35095}
181 lines
5.8 KiB
C++
181 lines
5.8 KiB
C++
/*
|
|
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "net/dcsctp/socket/heartbeat_handler.h"
|
|
|
|
#include <memory>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "net/dcsctp/packet/chunk/heartbeat_ack_chunk.h"
|
|
#include "net/dcsctp/packet/chunk/heartbeat_request_chunk.h"
|
|
#include "net/dcsctp/packet/parameter/heartbeat_info_parameter.h"
|
|
#include "net/dcsctp/public/types.h"
|
|
#include "net/dcsctp/socket/mock_context.h"
|
|
#include "net/dcsctp/testing/testing_macros.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "test/gmock.h"
|
|
|
|
namespace dcsctp {
|
|
namespace {
|
|
using ::testing::ElementsAre;
|
|
using ::testing::IsEmpty;
|
|
using ::testing::NiceMock;
|
|
using ::testing::Return;
|
|
using ::testing::SizeIs;
|
|
|
|
constexpr DurationMs kHeartbeatInterval = DurationMs(30'000);
|
|
|
|
DcSctpOptions MakeOptions(DurationMs heartbeat_interval) {
|
|
DcSctpOptions options;
|
|
options.heartbeat_interval_include_rtt = false;
|
|
options.heartbeat_interval = heartbeat_interval;
|
|
return options;
|
|
}
|
|
|
|
class HeartbeatHandlerTestBase : public testing::Test {
|
|
protected:
|
|
explicit HeartbeatHandlerTestBase(DurationMs heartbeat_interval)
|
|
: options_(MakeOptions(heartbeat_interval)),
|
|
context_(&callbacks_),
|
|
timer_manager_([this]() { return callbacks_.CreateTimeout(); }),
|
|
handler_("log: ", options_, &context_, &timer_manager_) {}
|
|
|
|
void AdvanceTime(DurationMs duration) {
|
|
callbacks_.AdvanceTime(duration);
|
|
for (;;) {
|
|
absl::optional<TimeoutID> timeout_id = callbacks_.GetNextExpiredTimeout();
|
|
if (!timeout_id.has_value()) {
|
|
break;
|
|
}
|
|
timer_manager_.HandleTimeout(*timeout_id);
|
|
}
|
|
}
|
|
|
|
const DcSctpOptions options_;
|
|
NiceMock<MockDcSctpSocketCallbacks> callbacks_;
|
|
NiceMock<MockContext> context_;
|
|
TimerManager timer_manager_;
|
|
HeartbeatHandler handler_;
|
|
};
|
|
|
|
class HeartbeatHandlerTest : public HeartbeatHandlerTestBase {
|
|
protected:
|
|
HeartbeatHandlerTest() : HeartbeatHandlerTestBase(kHeartbeatInterval) {}
|
|
};
|
|
|
|
class DisabledHeartbeatHandlerTest : public HeartbeatHandlerTestBase {
|
|
protected:
|
|
DisabledHeartbeatHandlerTest() : HeartbeatHandlerTestBase(DurationMs(0)) {}
|
|
};
|
|
|
|
TEST_F(HeartbeatHandlerTest, HasRunningHeartbeatIntervalTimer) {
|
|
AdvanceTime(options_.heartbeat_interval);
|
|
|
|
// Validate that a heartbeat request was sent.
|
|
std::vector<uint8_t> payload = callbacks_.ConsumeSentPacket();
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(SctpPacket packet, SctpPacket::Parse(payload));
|
|
ASSERT_THAT(packet.descriptors(), SizeIs(1));
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
HeartbeatRequestChunk request,
|
|
HeartbeatRequestChunk::Parse(packet.descriptors()[0].data));
|
|
|
|
EXPECT_TRUE(request.info().has_value());
|
|
}
|
|
|
|
TEST_F(HeartbeatHandlerTest, RepliesToHeartbeatRequests) {
|
|
uint8_t info_data[] = {1, 2, 3, 4, 5};
|
|
HeartbeatRequestChunk request(
|
|
Parameters::Builder().Add(HeartbeatInfoParameter(info_data)).Build());
|
|
|
|
handler_.HandleHeartbeatRequest(std::move(request));
|
|
|
|
std::vector<uint8_t> payload = callbacks_.ConsumeSentPacket();
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(SctpPacket packet, SctpPacket::Parse(payload));
|
|
ASSERT_THAT(packet.descriptors(), SizeIs(1));
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
HeartbeatAckChunk response,
|
|
HeartbeatAckChunk::Parse(packet.descriptors()[0].data));
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
HeartbeatInfoParameter param,
|
|
response.parameters().get<HeartbeatInfoParameter>());
|
|
|
|
EXPECT_THAT(param.info(), ElementsAre(1, 2, 3, 4, 5));
|
|
}
|
|
|
|
TEST_F(HeartbeatHandlerTest, SendsHeartbeatRequestsOnIdleChannel) {
|
|
AdvanceTime(options_.heartbeat_interval);
|
|
|
|
// Grab the request, and make a response.
|
|
std::vector<uint8_t> payload = callbacks_.ConsumeSentPacket();
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(SctpPacket packet, SctpPacket::Parse(payload));
|
|
ASSERT_THAT(packet.descriptors(), SizeIs(1));
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
HeartbeatRequestChunk req,
|
|
HeartbeatRequestChunk::Parse(packet.descriptors()[0].data));
|
|
|
|
HeartbeatAckChunk ack(std::move(req).extract_parameters());
|
|
|
|
// Respond a while later. This RTT will be measured by the handler
|
|
constexpr DurationMs rtt(313);
|
|
|
|
EXPECT_CALL(context_, ObserveRTT(rtt)).Times(1);
|
|
|
|
callbacks_.AdvanceTime(rtt);
|
|
handler_.HandleHeartbeatAck(std::move(ack));
|
|
}
|
|
|
|
TEST_F(HeartbeatHandlerTest, DoesntObserveInvalidHeartbeats) {
|
|
AdvanceTime(options_.heartbeat_interval);
|
|
|
|
// Grab the request, and make a response.
|
|
std::vector<uint8_t> payload = callbacks_.ConsumeSentPacket();
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(SctpPacket packet, SctpPacket::Parse(payload));
|
|
ASSERT_THAT(packet.descriptors(), SizeIs(1));
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
HeartbeatRequestChunk req,
|
|
HeartbeatRequestChunk::Parse(packet.descriptors()[0].data));
|
|
|
|
HeartbeatAckChunk ack(std::move(req).extract_parameters());
|
|
|
|
EXPECT_CALL(context_, ObserveRTT).Times(0);
|
|
|
|
// Go backwards in time - which make the HEARTBEAT-ACK have an invalid
|
|
// timestamp in it, as it will be in the future.
|
|
callbacks_.AdvanceTime(DurationMs(-100));
|
|
|
|
handler_.HandleHeartbeatAck(std::move(ack));
|
|
}
|
|
|
|
TEST_F(HeartbeatHandlerTest, IncreasesErrorIfNotAckedInTime) {
|
|
DurationMs rto(105);
|
|
EXPECT_CALL(context_, current_rto).WillOnce(Return(rto));
|
|
AdvanceTime(options_.heartbeat_interval);
|
|
|
|
// Validate that a request was sent.
|
|
EXPECT_THAT(callbacks_.ConsumeSentPacket(), Not(IsEmpty()));
|
|
|
|
EXPECT_CALL(context_, IncrementTxErrorCounter).Times(1);
|
|
AdvanceTime(rto);
|
|
}
|
|
|
|
TEST_F(DisabledHeartbeatHandlerTest, IsReallyDisabled) {
|
|
AdvanceTime(options_.heartbeat_interval);
|
|
|
|
// Validate that a request was NOT sent.
|
|
EXPECT_THAT(callbacks_.ConsumeSentPacket(), IsEmpty());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace dcsctp
|