mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
2c74d85c16
Removed the need to create a custom parser function and reuses some of the code to reduce binary overhead of enums. Bug: webrtc:9346 Change-Id: I51c9da713ed5456a86a2afbcf0991477bb83b894 Reviewed-on: https://webrtc-review.googlesource.com/83623 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23752}
125 lines
4.6 KiB
C++
125 lines
4.6 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "rtc_base/experiments/field_trial_parser.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "system_wrappers/include/field_trial.h"
|
|
#include "test/field_trial.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
const char kDummyExperiment[] = "WebRTC-DummyExperiment";
|
|
|
|
struct DummyExperiment {
|
|
FieldTrialFlag enabled = FieldTrialFlag("Enabled");
|
|
FieldTrialParameter<double> factor = FieldTrialParameter<double>("f", 0.5);
|
|
FieldTrialParameter<int> retries = FieldTrialParameter<int>("r", 5);
|
|
FieldTrialParameter<bool> ping = FieldTrialParameter<bool>("p", 0);
|
|
FieldTrialParameter<std::string> hash =
|
|
FieldTrialParameter<std::string>("h", "a80");
|
|
|
|
explicit DummyExperiment(std::string field_trial) {
|
|
ParseFieldTrial({&enabled, &factor, &retries, &ping, &hash}, field_trial);
|
|
}
|
|
DummyExperiment() {
|
|
std::string trial_string = field_trial::FindFullName(kDummyExperiment);
|
|
ParseFieldTrial({&enabled, &factor, &retries, &ping, &hash}, trial_string);
|
|
}
|
|
};
|
|
|
|
enum class CustomEnum {
|
|
kDefault = 0,
|
|
kRed = 1,
|
|
kBlue = 2,
|
|
};
|
|
} // namespace
|
|
|
|
TEST(FieldTrialParserTest, ParsesValidParameters) {
|
|
DummyExperiment exp("Enabled,f:-1.7,r:2,p:1,h:x7c");
|
|
EXPECT_TRUE(exp.enabled.Get());
|
|
EXPECT_EQ(exp.factor.Get(), -1.7);
|
|
EXPECT_EQ(exp.retries.Get(), 2);
|
|
EXPECT_EQ(exp.ping.Get(), true);
|
|
EXPECT_EQ(exp.hash.Get(), "x7c");
|
|
}
|
|
TEST(FieldTrialParserTest, InitializesFromFieldTrial) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-OtherExperiment/Disabled/"
|
|
"WebRTC-DummyExperiment/Enabled,f:-1.7,r:2,p:1,h:x7c/"
|
|
"WebRTC-AnotherExperiment/Enabled,f:-3.1,otherstuff:beef/");
|
|
DummyExperiment exp;
|
|
EXPECT_TRUE(exp.enabled.Get());
|
|
EXPECT_EQ(exp.factor.Get(), -1.7);
|
|
EXPECT_EQ(exp.retries.Get(), 2);
|
|
EXPECT_EQ(exp.ping.Get(), true);
|
|
EXPECT_EQ(exp.hash.Get(), "x7c");
|
|
}
|
|
TEST(FieldTrialParserTest, UsesDefaults) {
|
|
DummyExperiment exp("");
|
|
EXPECT_FALSE(exp.enabled.Get());
|
|
EXPECT_EQ(exp.factor.Get(), 0.5);
|
|
EXPECT_EQ(exp.retries.Get(), 5);
|
|
EXPECT_EQ(exp.ping.Get(), false);
|
|
EXPECT_EQ(exp.hash.Get(), "a80");
|
|
}
|
|
TEST(FieldTrialParserTest, CanHandleMixedInput) {
|
|
DummyExperiment exp("p:true,h:,Enabled");
|
|
EXPECT_TRUE(exp.enabled.Get());
|
|
EXPECT_EQ(exp.factor.Get(), 0.5);
|
|
EXPECT_EQ(exp.retries.Get(), 5);
|
|
EXPECT_EQ(exp.ping.Get(), true);
|
|
EXPECT_EQ(exp.hash.Get(), "");
|
|
}
|
|
TEST(FieldTrialParserTest, IgnoresNewKey) {
|
|
DummyExperiment exp("Disabled,r:-11,foo");
|
|
EXPECT_FALSE(exp.enabled.Get());
|
|
EXPECT_EQ(exp.factor.Get(), 0.5);
|
|
EXPECT_EQ(exp.retries.Get(), -11);
|
|
}
|
|
TEST(FieldTrialParserTest, IgnoresInvalid) {
|
|
DummyExperiment exp("Enabled,f,p:,r:%,,:foo,h");
|
|
EXPECT_TRUE(exp.enabled.Get());
|
|
EXPECT_EQ(exp.factor.Get(), 0.5);
|
|
EXPECT_EQ(exp.retries.Get(), 5);
|
|
EXPECT_EQ(exp.ping.Get(), false);
|
|
EXPECT_EQ(exp.hash.Get(), "a80");
|
|
}
|
|
TEST(FieldTrialParserTest, ParsesOptionalParameters) {
|
|
FieldTrialOptional<int> max_count("c", absl::nullopt);
|
|
ParseFieldTrial({&max_count}, "");
|
|
EXPECT_FALSE(max_count.Get().has_value());
|
|
ParseFieldTrial({&max_count}, "c:10");
|
|
EXPECT_EQ(max_count.Get().value(), 10);
|
|
ParseFieldTrial({&max_count}, "c");
|
|
EXPECT_FALSE(max_count.Get().has_value());
|
|
ParseFieldTrial({&max_count}, "c:20");
|
|
EXPECT_EQ(max_count.Get().value(), 20);
|
|
ParseFieldTrial({&max_count}, "c:");
|
|
EXPECT_EQ(max_count.Get().value(), 20);
|
|
FieldTrialOptional<std::string> optional_string("s", std::string("ab"));
|
|
ParseFieldTrial({&optional_string}, "s:");
|
|
EXPECT_EQ(optional_string.Get().value(), "");
|
|
ParseFieldTrial({&optional_string}, "s");
|
|
EXPECT_FALSE(optional_string.Get().has_value());
|
|
}
|
|
TEST(FieldTrialParserTest, ParsesCustomEnumParameter) {
|
|
FieldTrialEnum<CustomEnum> my_enum("e", CustomEnum::kDefault,
|
|
{{"default", CustomEnum::kDefault},
|
|
{"red", CustomEnum::kRed},
|
|
{"blue", CustomEnum::kBlue}});
|
|
ParseFieldTrial({&my_enum}, "");
|
|
EXPECT_EQ(my_enum.Get(), CustomEnum::kDefault);
|
|
ParseFieldTrial({&my_enum}, "e:red");
|
|
EXPECT_EQ(my_enum.Get(), CustomEnum::kRed);
|
|
ParseFieldTrial({&my_enum}, "e:2");
|
|
EXPECT_EQ(my_enum.Get(), CustomEnum::kBlue);
|
|
ParseFieldTrial({&my_enum}, "e:5");
|
|
EXPECT_EQ(my_enum.Get(), CustomEnum::kBlue);
|
|
}
|
|
} // namespace webrtc
|