mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/examples
History
Mirko Bonadei 317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
..
aarproject Fix outdated android sdk path in tests. 2019-03-21 12:18:19 +00:00
androidapp Adds setAudio[Track/Record]StateCallback interfaces to the Java ADM 2019-09-09 08:10:41 +00:00
androidjunit Increase test timeouts in TCPChannelClientTest 2018-11-22 13:16:18 +00:00
androidnativeapi Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
androidtests Remove loopback video quality analysis test. 2019-04-12 13:03:22 +00:00
objc Implement JNI and objc implementation for Ice Candidate Pair Change event surfacing 2019-08-12 23:58:50 +00:00
objcnativeapi Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
peerconnection Add usage message to peerconnection_server. 2019-07-19 11:18:08 +00:00
relayserver (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
stunprober Switch pc client and stunprober to ABSL_FLAG. 2019-07-17 14:03:59 +00:00
stunserver (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
turnserver Format almost everything. 2019-07-08 13:45:15 +00:00
unityplugin Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
BUILD.gn Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
DEPS Remove +absl/flags exceptions from non root DEPS files. 2019-07-16 16:52:41 +00:00
OWNERS Moving src/webrtc into src/. 2017-09-15 04:25:06 +00:00