mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 22:00:47 +01:00
33728152ca
There are two problems with setLocalDescription / setRemoteDescription in ObjC SDK. First, RTCSessionDescription.nativeDescription returns a raw nullableSessionDescriptionInterface pointer, where sLD/sRD are calling Clone() method unconditionally, so it might crash. Second, unnecessary sLD/sRD calls Clone() of the raw pointer and does not delete it, so this pointer will leak. To solve these problems, I changed the return type of nativeDescription to std::unique_ptr and removed the call to Clone() method. Bug: webrtc:13022, webrtc:13035 Change-Id: Icbb87dda62d3a11af47ec74621cf64b8a6c05228 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227380 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/master@{#34647} |
||
|---|---|---|
| .. | ||
| audio_short16.pcm | ||
| audio_short44.pcm | ||
| audio_short48.pcm | ||
| avformatmappertests.mm | ||
| foreman.mp4 | ||
| frame_buffer_helpers.h | ||
| frame_buffer_helpers.mm | ||
| main.mm | ||
| nalu_rewriter_xctest.mm | ||
| objc_video_decoder_factory_tests.mm | ||
| objc_video_encoder_factory_tests.mm | ||
| ObjCVideoTrackSource_xctest.mm | ||
| RTCAudioDevice_xctest.mm | ||
| RTCAudioDeviceModule_xctest.mm | ||
| RTCAudioSessionTest.mm | ||
| RTCCallbackLogger_xctest.m | ||
| RTCCameraVideoCapturerTests.mm | ||
| RTCCertificateTest.mm | ||
| RTCConfigurationTest.mm | ||
| RTCCVPixelBuffer_xctest.mm | ||
| RTCDataChannelConfigurationTest.mm | ||
| RTCDoNotPutCPlusPlusInFrameworkHeaders_xctest.m | ||
| RTCEncodedImage_xctest.mm | ||
| RTCFileVideoCapturer_xctest.mm | ||
| RTCH264ProfileLevelId_xctest.m | ||
| RTCIceCandidateTest.mm | ||
| RTCIceServerTest.mm | ||
| RTCMediaConstraintsTest.mm | ||
| RTCMTLVideoView_xctest.m | ||
| RTCNV12TextureCache_xctest.m | ||
| RTCPeerConnectionFactory_xctest.m | ||
| RTCPeerConnectionFactoryBuilderTest.mm | ||
| RTCPeerConnectionTest.mm | ||
| RTCSessionDescriptionTest.mm | ||
| RTCTracingTest.mm | ||
| scoped_cftyperef_tests.mm | ||