mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 06:40:43 +01:00
0f9a8e33c0
Previous implementation assumes that though RepeatingTask is owned by the task queue, it will stay alive until RepeatingTaskHandler stops it. That assumption doesn't hold by one of downstream TaskQueue implementaions. That TaskQueue implementation shortly before destruction deletes pending delayed tasks because it doesn't plan to run them, and then runs remaining regular tasks. Bug: None Change-Id: Ic95fec2e9961b3f05727ff6fbdaf0664434a995b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221984 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34274}
73 lines
2.1 KiB
C++
73 lines
2.1 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/task_utils/repeating_task.h"
|
|
|
|
#include "absl/memory/memory.h"
|
|
#include "rtc_base/logging.h"
|
|
#include "rtc_base/task_utils/pending_task_safety_flag.h"
|
|
#include "rtc_base/task_utils/to_queued_task.h"
|
|
#include "rtc_base/time_utils.h"
|
|
|
|
namespace webrtc {
|
|
namespace webrtc_repeating_task_impl {
|
|
|
|
RepeatingTaskBase::RepeatingTaskBase(
|
|
TaskQueueBase* task_queue,
|
|
TimeDelta first_delay,
|
|
Clock* clock,
|
|
rtc::scoped_refptr<PendingTaskSafetyFlag> alive_flag)
|
|
: task_queue_(task_queue),
|
|
clock_(clock),
|
|
next_run_time_(clock_->CurrentTime() + first_delay),
|
|
alive_flag_(std::move(alive_flag)) {}
|
|
|
|
RepeatingTaskBase::~RepeatingTaskBase() = default;
|
|
|
|
bool RepeatingTaskBase::Run() {
|
|
RTC_DCHECK_RUN_ON(task_queue_);
|
|
// Return true to tell the TaskQueue to destruct this object.
|
|
if (!alive_flag_->alive())
|
|
return true;
|
|
|
|
TimeDelta delay = RunClosure();
|
|
|
|
// The closure might have stopped this task, in which case we return true to
|
|
// destruct this object.
|
|
if (!alive_flag_->alive())
|
|
return true;
|
|
|
|
RTC_DCHECK(delay.IsFinite());
|
|
TimeDelta lost_time = clock_->CurrentTime() - next_run_time_;
|
|
next_run_time_ += delay;
|
|
delay -= lost_time;
|
|
delay = std::max(delay, TimeDelta::Zero());
|
|
|
|
task_queue_->PostDelayedTask(absl::WrapUnique(this), delay.ms());
|
|
|
|
// Return false to tell the TaskQueue to not destruct this object since we
|
|
// have taken ownership with absl::WrapUnique.
|
|
return false;
|
|
}
|
|
|
|
} // namespace webrtc_repeating_task_impl
|
|
|
|
void RepeatingTaskHandle::Stop() {
|
|
if (repeating_task_) {
|
|
repeating_task_->SetNotAlive();
|
|
repeating_task_ = nullptr;
|
|
}
|
|
}
|
|
|
|
bool RepeatingTaskHandle::Running() const {
|
|
return repeating_task_ != nullptr;
|
|
}
|
|
|
|
} // namespace webrtc
|