webrtc/modules/audio_coding/codecs/ilbc/smooth_out_data.c
Karl Wiberg e058568cc5 iLBC decoding: Ignore a signed overflow
It's always been there, and there's no security risk.

Bug: chromium:843477
Change-Id: I6121943f23b477300cf60ffc4858ef0ab43466dc
Reviewed-on: https://webrtc-review.googlesource.com/78782
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23393}
2018-05-25 08:34:44 +00:00

54 lines
1.5 KiB
C

/*
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
/******************************************************************
iLBC Speech Coder ANSI-C Source Code
WebRtcIlbcfix_Smooth_odata.c
******************************************************************/
#include "modules/audio_coding/codecs/ilbc/defines.h"
#include "modules/audio_coding/codecs/ilbc/constants.h"
#include "rtc_base/sanitizer.h"
// An s32 + s32 -> s32 addition that's allowed to overflow. (It's still
// undefined behavior, so not a good idea; this just makes UBSan ignore the
// violation, so that our old code can continue to do what it's always been
// doing.)
static inline int32_t RTC_NO_SANITIZE("signed-integer-overflow")
OverflowingAdd_S32_S32_To_S32(int32_t a, int32_t b) {
return a + b;
}
int32_t WebRtcIlbcfix_Smooth_odata(
int16_t *odata,
int16_t *psseq,
int16_t *surround,
int16_t C)
{
int i;
int16_t err;
int32_t errs;
for(i=0;i<80;i++) {
odata[i]= (int16_t)((C * surround[i] + 1024) >> 11);
}
errs=0;
for(i=0;i<80;i++) {
err = (psseq[i] - odata[i]) >> 3;
errs = OverflowingAdd_S32_S32_To_S32(errs, err * err); // errs in Q-6
}
return errs;
}