mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00

This reverts commit793bac569f
. Reason for revert: rare compilation error fixed Original change's description: > Revert "Refactor the PlatformThread API." > > This reverts commitc89fdd716c
. > > Reason for revert: Causes rare compilation error on win-libfuzzer-asan trybot. > See https://ci.chromium.org/p/chromium/builders/try/win-libfuzzer-asan-rel/713745? > > Original change's description: > > Refactor the PlatformThread API. > > > > PlatformThread's API is using old style function pointers, causes > > casting, is unintuitive and forces artificial call sequences, and > > is additionally possible to misuse in release mode. > > > > Fix this by an API face lift: > > 1. The class is turned into a handle, which can be empty. > > 2. The only way of getting a non-empty PlatformThread is by calling > > SpawnJoinable or SpawnDetached, clearly conveying the semantics to the > > code reader. > > 3. Handles can be Finalized, which works differently for joinable and > > detached threads: > > a) Handles for detached threads are simply closed where applicable. > > b) Joinable threads are joined before handles are closed. > > 4. The destructor finalizes handles. No explicit call is needed. > > > > Fixed: webrtc:12727 > > Change-Id: Id00a0464edf4fc9e552b6a1fbb5d2e1280e88811 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215075 > > Commit-Queue: Markus Handell <handellm@webrtc.org> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Tommi <tommi@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#33923} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR=handellm@webrtc.org > > Bug: webrtc:12727 > Change-Id: Ic0146be8866f6dd3ad9c364fb8646650b8e07419 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217583 > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Reviewed-by: Markus Handell <handellm@webrtc.org> > Commit-Queue: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33936} # Not skipping CQ checks because this is a reland. Bug: webrtc:12727 Change-Id: Ifd6f44eac72fed84474277a1be03eb84d2f4376e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217881 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33950}
113 lines
3.7 KiB
C++
113 lines
3.7 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef RTC_BASE_PLATFORM_THREAD_H_
|
|
#define RTC_BASE_PLATFORM_THREAD_H_
|
|
|
|
#include <functional>
|
|
#include <string>
|
|
|
|
#include "absl/strings/string_view.h"
|
|
#include "absl/types/optional.h"
|
|
#include "rtc_base/platform_thread_types.h"
|
|
|
|
namespace rtc {
|
|
|
|
enum class ThreadPriority {
|
|
kLow = 1,
|
|
kNormal,
|
|
kHigh,
|
|
kRealtime,
|
|
};
|
|
|
|
struct ThreadAttributes {
|
|
ThreadPriority priority = ThreadPriority::kNormal;
|
|
ThreadAttributes& SetPriority(ThreadPriority priority_param) {
|
|
priority = priority_param;
|
|
return *this;
|
|
}
|
|
};
|
|
|
|
// Represents a simple worker thread.
|
|
class PlatformThread final {
|
|
public:
|
|
// Handle is the base platform thread handle.
|
|
#if defined(WEBRTC_WIN)
|
|
using Handle = HANDLE;
|
|
#else
|
|
using Handle = pthread_t;
|
|
#endif // defined(WEBRTC_WIN)
|
|
// This ctor creates the PlatformThread with an unset handle (returning true
|
|
// in empty()) and is provided for convenience.
|
|
// TODO(bugs.webrtc.org/12727) Look into if default and move support can be
|
|
// removed.
|
|
PlatformThread() = default;
|
|
|
|
// Moves |rhs| into this, storing an empty state in |rhs|.
|
|
// TODO(bugs.webrtc.org/12727) Look into if default and move support can be
|
|
// removed.
|
|
PlatformThread(PlatformThread&& rhs);
|
|
|
|
// Moves |rhs| into this, storing an empty state in |rhs|.
|
|
// TODO(bugs.webrtc.org/12727) Look into if default and move support can be
|
|
// removed.
|
|
PlatformThread& operator=(PlatformThread&& rhs);
|
|
|
|
// For a PlatformThread that's been spawned joinable, the destructor suspends
|
|
// the calling thread until the created thread exits unless the thread has
|
|
// already exited.
|
|
virtual ~PlatformThread();
|
|
|
|
// Finalizes any allocated resources.
|
|
// For a PlatformThread that's been spawned joinable, Finalize() suspends
|
|
// the calling thread until the created thread exits unless the thread has
|
|
// already exited.
|
|
// empty() returns true after completion.
|
|
void Finalize();
|
|
|
|
// Returns true if default constructed, moved from, or Finalize()ed.
|
|
bool empty() const { return !handle_.has_value(); }
|
|
|
|
// Creates a started joinable thread which will be joined when the returned
|
|
// PlatformThread destructs or Finalize() is called.
|
|
static PlatformThread SpawnJoinable(
|
|
std::function<void()> thread_function,
|
|
absl::string_view name,
|
|
ThreadAttributes attributes = ThreadAttributes());
|
|
|
|
// Creates a started detached thread. The caller has to use external
|
|
// synchronization as nothing is provided by the PlatformThread construct.
|
|
static PlatformThread SpawnDetached(
|
|
std::function<void()> thread_function,
|
|
absl::string_view name,
|
|
ThreadAttributes attributes = ThreadAttributes());
|
|
|
|
// Returns the base platform thread handle of this thread.
|
|
absl::optional<Handle> GetHandle() const;
|
|
|
|
#if defined(WEBRTC_WIN)
|
|
// Queue a Windows APC function that runs when the thread is alertable.
|
|
bool QueueAPC(PAPCFUNC apc_function, ULONG_PTR data);
|
|
#endif
|
|
|
|
private:
|
|
PlatformThread(Handle handle, bool joinable);
|
|
static PlatformThread SpawnThread(std::function<void()> thread_function,
|
|
absl::string_view name,
|
|
ThreadAttributes attributes,
|
|
bool joinable);
|
|
|
|
absl::optional<Handle> handle_;
|
|
bool joinable_ = false;
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // RTC_BASE_PLATFORM_THREAD_H_
|