mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 06:10:40 +01:00

This is a reland of 11dfff0878
Now that I am sure that WebRTC code is not calling the obsolete
versions, I will just remove the NOT_REACHED and call the
new version from the old ones, so as not to trip up downstream
projects.
Original change's description:
> Inform VideoEncoder of negotiated capabilities
>
> After this CL lands, an announcement will be made to
> discuss-webrtc about the deprecation of one version
> of InitEncode().
>
> Bug: webrtc:10720
> Change-Id: Ib992af0272bbb16ae16ef7e69491f365702d179e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140884
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Elad Alon <eladalon@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28224}
TBR=sakal@webrtc.org,kwiberg@webrtc.org,sprang@webrtc.org
Bug: webrtc:10720
Change-Id: I46c69e45c190805c07f7e51acbe277d7eebd1600
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141412
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28236}
124 lines
5.4 KiB
Text
124 lines
5.4 KiB
Text
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import <Foundation/Foundation.h>
|
|
#import <OCMock/OCMock.h>
|
|
|
|
#include "sdk/objc/native/src/objc_video_encoder_factory.h"
|
|
|
|
#include "api/video_codecs/sdp_video_format.h"
|
|
#include "api/video_codecs/video_encoder.h"
|
|
#import "base/RTCVideoEncoder.h"
|
|
#import "base/RTCVideoEncoderFactory.h"
|
|
#import "base/RTCVideoFrameBuffer.h"
|
|
#import "components/video_frame_buffer/RTCCVPixelBuffer.h"
|
|
#include "modules/include/module_common_types.h"
|
|
#include "modules/video_coding/include/video_codec_interface.h"
|
|
#include "modules/video_coding/include/video_error_codes.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "sdk/objc/native/src/objc_frame_buffer.h"
|
|
|
|
id<RTCVideoEncoderFactory> CreateEncoderFactoryReturning(int return_code) {
|
|
id encoderMock = OCMProtocolMock(@protocol(RTCVideoEncoder));
|
|
OCMStub([encoderMock startEncodeWithSettings:[OCMArg any] numberOfCores:1])
|
|
.andReturn(return_code);
|
|
OCMStub([encoderMock encode:[OCMArg any] codecSpecificInfo:[OCMArg any] frameTypes:[OCMArg any]])
|
|
.andReturn(return_code);
|
|
OCMStub([encoderMock releaseEncoder]).andReturn(return_code);
|
|
OCMStub([encoderMock setBitrate:0 framerate:0]).andReturn(return_code);
|
|
|
|
id encoderFactoryMock = OCMProtocolMock(@protocol(RTCVideoEncoderFactory));
|
|
RTCVideoCodecInfo *supported = [[RTCVideoCodecInfo alloc] initWithName:@"H264" parameters:nil];
|
|
OCMStub([encoderFactoryMock supportedCodecs]).andReturn(@[ supported ]);
|
|
OCMStub([encoderFactoryMock createEncoder:[OCMArg any]]).andReturn(encoderMock);
|
|
return encoderFactoryMock;
|
|
}
|
|
|
|
id<RTCVideoEncoderFactory> CreateOKEncoderFactory() {
|
|
return CreateEncoderFactoryReturning(WEBRTC_VIDEO_CODEC_OK);
|
|
}
|
|
|
|
id<RTCVideoEncoderFactory> CreateErrorEncoderFactory() {
|
|
return CreateEncoderFactoryReturning(WEBRTC_VIDEO_CODEC_ERROR);
|
|
}
|
|
|
|
std::unique_ptr<webrtc::VideoEncoder> GetObjCEncoder(id<RTCVideoEncoderFactory> factory) {
|
|
webrtc::ObjCVideoEncoderFactory encoder_factory(factory);
|
|
webrtc::SdpVideoFormat format("H264");
|
|
return encoder_factory.CreateVideoEncoder(format);
|
|
}
|
|
|
|
#pragma mark -
|
|
|
|
TEST(ObjCVideoEncoderFactoryTest, InitEncodeReturnsOKOnSuccess) {
|
|
std::unique_ptr<webrtc::VideoEncoder> encoder = GetObjCEncoder(CreateOKEncoderFactory());
|
|
|
|
auto* settings = new webrtc::VideoCodec();
|
|
const webrtc::VideoEncoder::Capabilities kCapabilities(false);
|
|
EXPECT_EQ(encoder->InitEncode(settings, webrtc::VideoEncoder::Settings(kCapabilities, 1, 0)),
|
|
WEBRTC_VIDEO_CODEC_OK);
|
|
}
|
|
|
|
TEST(ObjCVideoEncoderFactoryTest, InitEncodeReturnsErrorOnFail) {
|
|
std::unique_ptr<webrtc::VideoEncoder> encoder = GetObjCEncoder(CreateErrorEncoderFactory());
|
|
|
|
auto* settings = new webrtc::VideoCodec();
|
|
const webrtc::VideoEncoder::Capabilities kCapabilities(false);
|
|
EXPECT_EQ(encoder->InitEncode(settings, webrtc::VideoEncoder::Settings(kCapabilities, 1, 0)),
|
|
WEBRTC_VIDEO_CODEC_ERROR);
|
|
}
|
|
|
|
TEST(ObjCVideoEncoderFactoryTest, EncodeReturnsOKOnSuccess) {
|
|
std::unique_ptr<webrtc::VideoEncoder> encoder = GetObjCEncoder(CreateOKEncoderFactory());
|
|
|
|
CVPixelBufferRef pixel_buffer;
|
|
CVPixelBufferCreate(kCFAllocatorDefault, 640, 480, kCVPixelFormatType_32ARGB, nil, &pixel_buffer);
|
|
rtc::scoped_refptr<webrtc::VideoFrameBuffer> buffer =
|
|
new rtc::RefCountedObject<webrtc::ObjCFrameBuffer>(
|
|
[[RTCCVPixelBuffer alloc] initWithPixelBuffer:pixel_buffer]);
|
|
webrtc::VideoFrame frame = webrtc::VideoFrame::Builder()
|
|
.set_video_frame_buffer(buffer)
|
|
.set_rotation(webrtc::kVideoRotation_0)
|
|
.set_timestamp_us(0)
|
|
.build();
|
|
std::vector<webrtc::VideoFrameType> frame_types;
|
|
|
|
EXPECT_EQ(encoder->Encode(frame, &frame_types), WEBRTC_VIDEO_CODEC_OK);
|
|
}
|
|
|
|
TEST(ObjCVideoEncoderFactoryTest, EncodeReturnsErrorOnFail) {
|
|
std::unique_ptr<webrtc::VideoEncoder> encoder = GetObjCEncoder(CreateErrorEncoderFactory());
|
|
|
|
CVPixelBufferRef pixel_buffer;
|
|
CVPixelBufferCreate(kCFAllocatorDefault, 640, 480, kCVPixelFormatType_32ARGB, nil, &pixel_buffer);
|
|
rtc::scoped_refptr<webrtc::VideoFrameBuffer> buffer =
|
|
new rtc::RefCountedObject<webrtc::ObjCFrameBuffer>(
|
|
[[RTCCVPixelBuffer alloc] initWithPixelBuffer:pixel_buffer]);
|
|
webrtc::VideoFrame frame = webrtc::VideoFrame::Builder()
|
|
.set_video_frame_buffer(buffer)
|
|
.set_rotation(webrtc::kVideoRotation_0)
|
|
.set_timestamp_us(0)
|
|
.build();
|
|
std::vector<webrtc::VideoFrameType> frame_types;
|
|
|
|
EXPECT_EQ(encoder->Encode(frame, &frame_types), WEBRTC_VIDEO_CODEC_ERROR);
|
|
}
|
|
|
|
TEST(ObjCVideoEncoderFactoryTest, ReleaseEncodeReturnsOKOnSuccess) {
|
|
std::unique_ptr<webrtc::VideoEncoder> encoder = GetObjCEncoder(CreateOKEncoderFactory());
|
|
|
|
EXPECT_EQ(encoder->Release(), WEBRTC_VIDEO_CODEC_OK);
|
|
}
|
|
|
|
TEST(ObjCVideoEncoderFactoryTest, ReleaseEncodeReturnsErrorOnFail) {
|
|
std::unique_ptr<webrtc::VideoEncoder> encoder = GetObjCEncoder(CreateErrorEncoderFactory());
|
|
|
|
EXPECT_EQ(encoder->Release(), WEBRTC_VIDEO_CODEC_ERROR);
|
|
}
|