mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
317a1f09ed
WebRTC is now using C++14 so there is no need to use the Abseil version of std::make_unique. This CL has been created with the following steps: git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \ uniq > /tmp/only_make_unique.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/only_make_unique.txt /tmp/memory.txt | \ xargs grep -l "absl/memory" > /tmp/add-memory.txt git grep -l "\babsl::make_unique\b" | \ xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g" git checkout PRESUBMIT.py abseil-in-webrtc.md cat /tmp/add-memory.txt | \ xargs sed -i \ 's/#include "absl\/memory\/memory.h"/#include <memory>/g' git cl format # Manual fix order of the new inserted #include <memory> cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \ xargs sed -i '/#include "absl\/memory\/memory.h"/d' git ls-files | grep BUILD.gn | \ xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d' python tools_webrtc/gn_check_autofix.py \ -m tryserver.webrtc -b linux_rel # Repead the gn_check_autofix step for other platforms git ls-files | grep BUILD.gn | \ xargs sed -i 's/absl\/memory:memory/absl\/memory/g' git cl format Bug: webrtc:10945 Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29209}
123 lines
2.6 KiB
C++
123 lines
2.6 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
|
|
#include <memory>
|
|
#include <random>
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/null_socket_server.h"
|
|
#include "rtc_base/thread.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace rtc {
|
|
|
|
namespace {
|
|
|
|
#if defined(MEMORY_SANITIZER)
|
|
void UseOfUninitializedValue() {
|
|
int* buf = new int[2];
|
|
std::random_device engine;
|
|
if (buf[engine() % 2]) { // Non-deterministic conditional.
|
|
printf("Externally visible action.");
|
|
}
|
|
delete[] buf;
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, MemorySanitizer) {
|
|
EXPECT_DEATH(UseOfUninitializedValue(), "use-of-uninitialized-value");
|
|
}
|
|
#endif
|
|
|
|
#if defined(ADDRESS_SANITIZER)
|
|
void HeapUseAfterFree() {
|
|
char* buf = new char[2];
|
|
delete[] buf;
|
|
buf[0] = buf[1];
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, AddressSanitizer) {
|
|
EXPECT_DEATH(HeapUseAfterFree(), "heap-use-after-free");
|
|
}
|
|
#endif
|
|
|
|
#if defined(UNDEFINED_SANITIZER)
|
|
// For ubsan:
|
|
void SignedIntegerOverflow() {
|
|
int32_t x = 1234567890;
|
|
x *= 2;
|
|
}
|
|
|
|
// For ubsan_vptr:
|
|
struct Base {
|
|
virtual void f() {}
|
|
virtual ~Base() {}
|
|
};
|
|
struct Derived : public Base {};
|
|
|
|
void InvalidVptr() {
|
|
Base b;
|
|
auto* d = static_cast<Derived*>(&b); // Bad downcast.
|
|
d->f(); // Virtual function call with object of wrong dynamic type.
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, UndefinedSanitizer) {
|
|
EXPECT_DEATH(
|
|
{
|
|
SignedIntegerOverflow();
|
|
InvalidVptr();
|
|
},
|
|
"runtime error");
|
|
}
|
|
#endif
|
|
|
|
#if defined(THREAD_SANITIZER)
|
|
class IncrementThread : public Thread {
|
|
public:
|
|
explicit IncrementThread(int* value)
|
|
: Thread(std::make_unique<NullSocketServer>()), value_(value) {}
|
|
|
|
void Run() override {
|
|
++*value_;
|
|
Thread::Current()->SleepMs(100);
|
|
}
|
|
|
|
// Un-protect Thread::Join for the test.
|
|
void Join() { Thread::Join(); }
|
|
|
|
private:
|
|
int* value_;
|
|
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(IncrementThread);
|
|
};
|
|
|
|
void DataRace() {
|
|
int value = 0;
|
|
IncrementThread thread1(&value);
|
|
IncrementThread thread2(&value);
|
|
thread1.Start();
|
|
thread2.Start();
|
|
thread1.Join();
|
|
thread2.Join();
|
|
// TSan seems to mess with gtest's death detection.
|
|
// Fail intentionally, and rely on detecting the error message.
|
|
RTC_CHECK(false);
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, ThreadSanitizer) {
|
|
EXPECT_DEATH(DataRace(), "data race");
|
|
}
|
|
#endif
|
|
|
|
} // namespace
|
|
|
|
} // namespace rtc
|