mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 07:10:38 +01:00
9da7c7480b
Adds a unittest to test this. A Reset() with unsupported frequencies will fail, but currently leaves the resampler in an illegal state. Subsequent calls to ResetIfNeeded(), which depends on the internal state, will then have unreliable behavior. The following sequence of calls demonstrate this: It appears as though the resampler is successfully reinitialized to upsample from 44 kHz to 48 kHz, but will in fact crash on Push(). Resampler::Reset() with in=44000, out=32000 // Returns 0 Resampler::ResetIfNeeded() with in=44000, out=48000 // Returns -1 Resampler::ResetIfNeeded() with in=44000, out=48000 // Returns 0 Resampler::Push() with some data Bug: webrtc:8426 Change-Id: Id1e0528ffcb7a86702d4c2f4c5103a1db419c07d Reviewed-on: https://webrtc-review.googlesource.com/16424 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20474} |
||
|---|---|---|
| .. | ||
| include | ||
| push_resampler.cc | ||
| push_resampler_unittest.cc | ||
| push_sinc_resampler.cc | ||
| push_sinc_resampler.h | ||
| push_sinc_resampler_unittest.cc | ||
| resampler.cc | ||
| resampler_unittest.cc | ||
| sinc_resampler.cc | ||
| sinc_resampler.h | ||
| sinc_resampler_neon.cc | ||
| sinc_resampler_sse.cc | ||
| sinc_resampler_unittest.cc | ||
| sinusoidal_linear_chirp_source.cc | ||
| sinusoidal_linear_chirp_source.h | ||