mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
47faf32287
When built for chromium, some webrtc implementations are overridden and are implemented by chrome's "//base". For instance webrtc::Location is implemented by base::Location. So far so good, the affected targets are correctly defined in GN to depend on base. The problem: Most targets in webrtc do not declare correctly their public_deps. When a public header of a target includes one from its dependency, the dependency must be a public_deps. The public_deps instruct GN to forward the capability to use code from the dependency toward the dependent. Unfortunately, it is not possible to fix the `public_deps` in webrtc, because its is disallowed via a presubmit. See: https://webrtc-review.googlesource.com/c/src/+/30262 WebRTC developers decided not to use `public_deps`, because GN config are "translated" toward different kind of downstream build system who do not really support the `public` dependencies concept. Instead WebRTC is using some "common" configuration applied to all of its targets. This patch add `rtc_common_public_deps` argument, to let embedders add the dependencies WebRTC depends on. Bug: chromium:1467773 Change-Id: I7de43372414a09886fcb07905451e6339c8ecc64 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316660 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40595} |
||
|---|---|---|
| .. | ||
| acm2 | ||
| audio_network_adaptor | ||
| codecs | ||
| g3doc | ||
| include | ||
| neteq | ||
| test | ||
| audio_coding.gni | ||
| BUILD.gn | ||
| DEPS | ||
| OWNERS | ||