mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/sdk/android
History
Guy Hershenbaum 94dfe1cc59 Fix NetworkMonitor race condition when dispatching native observers 
There is a race condition in NetworkMonitor where native observers may be removed concurrently with a notification being dispatched, leading to a dangling pointer dereference (trying to dispatch an observer that was already removed and destroyed), and from there a crash with access violation.

By ensuring dispatching to native observers is done within the synchronization lock that guards additions/removals of native observers protects against this race condition.
Since native observers callbacks are posted to the networking thread in the C++ side anyway, there should be no risk of deadlock/starvation due to long-running observers.

Bug: webrtc:15837
Change-Id: Id2b788f102dbd25de76ceed434c4cd68aa9a569e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338643
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42256}
2024-05-08 08:27:19 +00:00
..
api/org/webrtc Fix NetworkMonitor race condition when dispatching native observers 2024-05-08 08:27:19 +00:00
instrumentationtests Migrate webrtc to stop using its own JniZero mirror classes 2024-04-23 12:50:19 +00:00
native_api Migrate webrtc to stop using its own JniZero mirror classes 2024-04-23 12:50:19 +00:00
native_unittests Move webrtc::AudioDeviceModule include to api/ folder 2024-04-22 08:56:31 +00:00
src Migrate webrtc to stop using its own JniZero mirror classes 2024-04-23 12:50:19 +00:00
tests Add unit test to RenderSynchronizer 2023-11-07 09:58:37 +00:00
AndroidManifest.xml Roll chromium_revision 4d95e6c77b..71a0e1904e (776481:782339) 2020-06-26 05:33:14 +00:00
BUILD.gn Migrate webrtc to stop using its own JniZero mirror classes 2024-04-23 12:50:19 +00:00
OWNERS Remove redundant PRESUBMIT.py files. 2022-03-31 10:48:31 +00:00
README Updating android/README. 2018-03-01 20:22:48 +00:00

README 

This directory holds a Java implementation of the webrtc::PeerConnection API, as
well as the JNI glue C++ code that lets the Java implementation reuse the C++
implementation of the same API.

To build the Java API and related tests, make sure you have a WebRTC checkout
with Android specific parts. This can be used for linux development as well by
configuring gn appropriately, as it is a superset of the webrtc checkout:
fetch --nohooks webrtc_android
gclient sync

You also must generate GN projects with:
--args='target_os="android" target_cpu="arm"'

More information on getting the code, compiling and running the AppRTCMobile
app can be found at:
https://webrtc.org/native-code/android/

To use the Java API, start by looking at the public interface of
org.webrtc.PeerConnection{,Factory} and the org.webrtc.PeerConnectionTest.

To understand the implementation of the API, see the native code in src/jni/pc/.