mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
4dc4e259ce
This reverts commit034a6b8a4c. Reason for revert: Trying to fix the issue of rtc_base:rtc_base which has 2 kind of source files but in exclusive if branches. Original change's description: > Revert "Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++." > > This reverts commit0c15c5332f. > > Reason for revert: This causes problems in this moment. I have to fix a target in rtc_base before landing this presubmit check. > > Original change's description: > > Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++. > > > > The error message will be something like: > > > > GN targets cannot mix .c (or .cc) and .m (or .mm) source files. > > Please create a separate target for each collection of sources. > > Mixed sources: > > { > > BUILD_GN_PATH: [ > > [ > > TARGET_NAME, > > [ > > SOURCES > > ] > > ], > > ... > > ], > > ... > > } > > > > Bug: webrtc:7743 > > Change-Id: I45dd2c621b830e5aeb081fa8d17c9497a49c2554 > > Reviewed-on: https://webrtc-review.googlesource.com/1980 > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#19897} > > TBR=kjellander@webrtc.org,mbonadei@webrtc.org > > Change-Id: I73ff609b0140719473afd36ead1632e5cc3b41f6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:7743 > Reviewed-on: https://webrtc-review.googlesource.com/2180 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#19898} TBR=kjellander@webrtc.org,mbonadei@webrtc.org Change-Id: I18dbb5a6a01ac2a184446542c29b25a3e33508ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:7743 Reviewed-on: https://webrtc-review.googlesource.com/2181 Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19900}
85 lines
2.4 KiB
Python
85 lines
2.4 KiB
Python
# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
# This file is inspired to [1].
|
|
# [1] - https://cs.chromium.org/chromium/src/PRESUBMIT_test_mocks.py
|
|
|
|
|
|
class MockInputApi(object):
|
|
"""Mock class for the InputApi class.
|
|
|
|
This class can be used for unittests for presubmit by initializing the files
|
|
attribute as the list of changed files.
|
|
"""
|
|
|
|
def __init__(self):
|
|
self.change = MockChange([])
|
|
self.files = []
|
|
|
|
def AffectedSourceFiles(self, file_filter=None):
|
|
# pylint: disable=unused-argument
|
|
return self.files
|
|
|
|
def ReadFile(self, affected_file, mode='rU'):
|
|
filename = affected_file.AbsoluteLocalPath()
|
|
for f in self.files:
|
|
if f.LocalPath() == filename:
|
|
with open(filename, mode) as f:
|
|
return f.read()
|
|
# Otherwise, file is not in our mock API.
|
|
raise IOError, "No such file or directory: '%s'" % filename
|
|
|
|
|
|
class MockOutputApi(object):
|
|
"""Mock class for the OutputApi class.
|
|
|
|
An instance of this class can be passed to presubmit unittests for outputing
|
|
various types of results.
|
|
"""
|
|
|
|
class PresubmitResult(object):
|
|
def __init__(self, message, items=None, long_text=''):
|
|
self.message = message
|
|
self.items = items
|
|
self.long_text = long_text
|
|
|
|
def __repr__(self):
|
|
return self.message
|
|
|
|
class PresubmitError(PresubmitResult):
|
|
def __init__(self, message, items=None, long_text=''):
|
|
MockOutputApi.PresubmitResult.__init__(self, message, items, long_text)
|
|
self.type = 'error'
|
|
|
|
|
|
class MockChange(object):
|
|
"""Mock class for Change class.
|
|
|
|
This class can be used in presubmit unittests to mock the query of the
|
|
current change.
|
|
"""
|
|
|
|
def __init__(self, changed_files):
|
|
self._changed_files = changed_files
|
|
|
|
|
|
class MockFile(object):
|
|
"""Mock class for the File class.
|
|
|
|
This class can be used to form the mock list of changed files in
|
|
MockInputApi for presubmit unittests.
|
|
"""
|
|
|
|
def __init__(self, local_path):
|
|
self._local_path = local_path
|
|
|
|
def LocalPath(self):
|
|
return self._local_path
|
|
|
|
def AbsoluteLocalPath(self):
|
|
return self._local_path
|