mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 15:20:42 +01:00
63ee39d0be
This reverts commit 181ea6e414.
Reason for revert: Breaks downstream project. Kári will help to land it next week.
Original change's description:
> Add a prefix for objc category.
>
> According to the Google Objective-C style [1], category names should
> start with an appropriate prefix. WebRTC has some category definitions
> for system interfaces, but it doesn't use prefixes.
>
> $ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC"
> 0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile
> 0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition
> 0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString
> 0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView
>
> To avoid conflicts, prefix the names and methods of those categories.
> Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as
> it is not used by any other files.
>
> [1] https://google.github.io/styleguide/objcguide.html#category-naming
>
> Bug: webrtc:13884
> Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36880}
Bug: webrtc:13884
Change-Id: I85257088e4a3a62e01ff925ab5e77af83b078ef3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262420
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36885}
74 lines
2.4 KiB
Text
74 lines
2.4 KiB
Text
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCDtmfSender+Private.h"
|
|
|
|
#import "base/RTCLogging.h"
|
|
#import "helpers/NSString+StdString.h"
|
|
|
|
#include "rtc_base/time_utils.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCDtmfSender) {
|
|
rtc::scoped_refptr<webrtc::DtmfSenderInterface> _nativeDtmfSender;
|
|
}
|
|
|
|
- (BOOL)canInsertDtmf {
|
|
return _nativeDtmfSender->CanInsertDtmf();
|
|
}
|
|
|
|
- (BOOL)insertDtmf:(nonnull NSString *)tones
|
|
duration:(NSTimeInterval)duration
|
|
interToneGap:(NSTimeInterval)interToneGap {
|
|
RTC_DCHECK(tones != nil);
|
|
|
|
int durationMs = static_cast<int>(duration * rtc::kNumMillisecsPerSec);
|
|
int interToneGapMs = static_cast<int>(interToneGap * rtc::kNumMillisecsPerSec);
|
|
return _nativeDtmfSender->InsertDtmf(
|
|
[NSString stdStringForString:tones], durationMs, interToneGapMs);
|
|
}
|
|
|
|
- (nonnull NSString *)remainingTones {
|
|
return [NSString stringForStdString:_nativeDtmfSender->tones()];
|
|
}
|
|
|
|
- (NSTimeInterval)duration {
|
|
return static_cast<NSTimeInterval>(_nativeDtmfSender->duration()) / rtc::kNumMillisecsPerSec;
|
|
}
|
|
|
|
- (NSTimeInterval)interToneGap {
|
|
return static_cast<NSTimeInterval>(_nativeDtmfSender->inter_tone_gap()) /
|
|
rtc::kNumMillisecsPerSec;
|
|
}
|
|
|
|
- (NSString *)description {
|
|
return [NSString stringWithFormat:@"RTC_OBJC_TYPE(RTCDtmfSender) {\n remainingTones: %@\n "
|
|
@"duration: %f sec\n interToneGap: %f sec\n}",
|
|
[self remainingTones],
|
|
[self duration],
|
|
[self interToneGap]];
|
|
}
|
|
|
|
#pragma mark - Private
|
|
|
|
- (rtc::scoped_refptr<webrtc::DtmfSenderInterface>)nativeDtmfSender {
|
|
return _nativeDtmfSender;
|
|
}
|
|
|
|
- (instancetype)initWithNativeDtmfSender:
|
|
(rtc::scoped_refptr<webrtc::DtmfSenderInterface>)nativeDtmfSender {
|
|
NSParameterAssert(nativeDtmfSender);
|
|
if (self = [super init]) {
|
|
_nativeDtmfSender = nativeDtmfSender;
|
|
RTCLogInfo(
|
|
@"RTC_OBJC_TYPE(RTCDtmfSender)(%p): created DTMF sender: %@", self, self.description);
|
|
}
|
|
return self;
|
|
}
|
|
@end
|