mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 14:50:39 +01:00
317a1f09ed
WebRTC is now using C++14 so there is no need to use the Abseil version of std::make_unique. This CL has been created with the following steps: git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \ uniq > /tmp/only_make_unique.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/only_make_unique.txt /tmp/memory.txt | \ xargs grep -l "absl/memory" > /tmp/add-memory.txt git grep -l "\babsl::make_unique\b" | \ xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g" git checkout PRESUBMIT.py abseil-in-webrtc.md cat /tmp/add-memory.txt | \ xargs sed -i \ 's/#include "absl\/memory\/memory.h"/#include <memory>/g' git cl format # Manual fix order of the new inserted #include <memory> cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \ xargs sed -i '/#include "absl\/memory\/memory.h"/d' git ls-files | grep BUILD.gn | \ xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d' python tools_webrtc/gn_check_autofix.py \ -m tryserver.webrtc -b linux_rel # Repead the gn_check_autofix step for other platforms git ls-files | grep BUILD.gn | \ xargs sed -i 's/absl\/memory:memory/absl\/memory/g' git cl format Bug: webrtc:10945 Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29209}
88 lines
3.2 KiB
C++
88 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "api/test/create_videocodec_test_fixture.h"
|
|
#include "media/base/media_constants.h"
|
|
#include "modules/video_coding/codecs/test/objc_codec_factory_helper.h"
|
|
#include "modules/video_coding/codecs/test/videocodec_test_fixture_impl.h"
|
|
#include "test/gtest.h"
|
|
#include "test/testsupport/file_utils.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
namespace {
|
|
const int kForemanNumFrames = 300;
|
|
|
|
VideoCodecTestFixture::Config CreateConfig() {
|
|
VideoCodecTestFixture::Config config;
|
|
config.filename = "foreman_cif";
|
|
config.filepath = ResourcePath(config.filename, "yuv");
|
|
config.num_frames = kForemanNumFrames;
|
|
return config;
|
|
}
|
|
|
|
std::unique_ptr<VideoCodecTestFixture> CreateTestFixtureWithConfig(
|
|
VideoCodecTestFixture::Config config) {
|
|
auto decoder_factory = CreateObjCDecoderFactory();
|
|
auto encoder_factory = CreateObjCEncoderFactory();
|
|
return CreateVideoCodecTestFixture(config, std::move(decoder_factory),
|
|
std::move(encoder_factory));
|
|
}
|
|
} // namespace
|
|
|
|
// TODO(webrtc:9099): Disabled until the issue is fixed.
|
|
// HW codecs don't work on simulators. Only run these tests on device.
|
|
// #if TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR
|
|
// #define MAYBE_TEST TEST
|
|
// #else
|
|
#define MAYBE_TEST(s, name) TEST(s, DISABLED_##name)
|
|
// #endif
|
|
|
|
// TODO(kthelgason): Use RC Thresholds when the internal bitrateAdjuster is no
|
|
// longer in use.
|
|
MAYBE_TEST(VideoCodecTestVideoToolbox, ForemanCif500kbpsH264CBP) {
|
|
const auto frame_checker =
|
|
std::make_unique<VideoCodecTestFixtureImpl::H264KeyframeChecker>();
|
|
auto config = CreateConfig();
|
|
config.SetCodecSettings(cricket::kH264CodecName, 1, 1, 1, false, false, false,
|
|
352, 288);
|
|
config.encoded_frame_checker = frame_checker.get();
|
|
auto fixture = CreateTestFixtureWithConfig(config);
|
|
|
|
std::vector<RateProfile> rate_profiles = {{500, 30, 0}};
|
|
|
|
std::vector<QualityThresholds> quality_thresholds = {{33, 29, 0.9, 0.82}};
|
|
|
|
fixture->RunTest(rate_profiles, nullptr, &quality_thresholds, nullptr);
|
|
}
|
|
|
|
MAYBE_TEST(VideoCodecTestVideoToolbox, ForemanCif500kbpsH264CHP) {
|
|
const auto frame_checker =
|
|
std::make_unique<VideoCodecTestFixtureImpl::H264KeyframeChecker>();
|
|
auto config = CreateConfig();
|
|
config.h264_codec_settings.profile = H264::kProfileConstrainedHigh;
|
|
config.SetCodecSettings(cricket::kH264CodecName, 1, 1, 1, false, false, false,
|
|
352, 288);
|
|
config.encoded_frame_checker = frame_checker.get();
|
|
auto fixture = CreateTestFixtureWithConfig(config);
|
|
|
|
std::vector<RateProfile> rate_profiles = {{500, 30, 0}};
|
|
|
|
std::vector<QualityThresholds> quality_thresholds = {{33, 30, 0.91, 0.83}};
|
|
|
|
fixture->RunTest(rate_profiles, nullptr, &quality_thresholds, nullptr);
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|