mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 14:20:45 +01:00
3111783aa1
Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896}
56 lines
1.6 KiB
C
56 lines
1.6 KiB
C
/*
|
|
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
/******************************************************************
|
|
|
|
iLBC Speech Coder ANSI-C Source Code
|
|
|
|
WebRtcIlbcfix_Smooth_odata.c
|
|
|
|
******************************************************************/
|
|
|
|
#include "modules/audio_coding/codecs/ilbc/smooth_out_data.h"
|
|
|
|
#include "modules/audio_coding/codecs/ilbc/constants.h"
|
|
#include "modules/audio_coding/codecs/ilbc/defines.h"
|
|
#include "rtc_base/sanitizer.h"
|
|
|
|
// An s32 + s32 -> s32 addition that's allowed to overflow. (It's still
|
|
// undefined behavior, so not a good idea; this just makes UBSan ignore the
|
|
// violation, so that our old code can continue to do what it's always been
|
|
// doing.)
|
|
static inline int32_t RTC_NO_SANITIZE("signed-integer-overflow")
|
|
OverflowingAdd_S32_S32_To_S32(int32_t a, int32_t b) {
|
|
return a + b;
|
|
}
|
|
|
|
int32_t WebRtcIlbcfix_Smooth_odata(
|
|
int16_t *odata,
|
|
int16_t *psseq,
|
|
int16_t *surround,
|
|
int16_t C)
|
|
{
|
|
int i;
|
|
|
|
int16_t err;
|
|
int32_t errs;
|
|
|
|
for(i=0;i<80;i++) {
|
|
odata[i]= (int16_t)((C * surround[i] + 1024) >> 11);
|
|
}
|
|
|
|
errs=0;
|
|
for(i=0;i<80;i++) {
|
|
err = (psseq[i] - odata[i]) >> 3;
|
|
errs = OverflowingAdd_S32_S32_To_S32(errs, err * err); // errs in Q-6
|
|
}
|
|
|
|
return errs;
|
|
}
|