mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 06:40:43 +01:00
fcf1af3049
The `recommended_stream_analog_level()` getter is used to retrieve both the applied and the recommended input volume. This behavior is error-prone since the caller must know what is returned based on the point in the code (namely, before/after the AGC has changed the last applied input volume into a recommended level). This CL is a first step to make clarity on which input volume is handled in different parts of APM. Next in the pipeline: make `recommended_stream_analog_level()` a trivial getter that always returns the recommended level. Main changes: - When `recommended_stream_analog_level()` is called but `set_stream_analog_level()` is not called, APM logs an error and returns a fall-back volume (which should not be applied since, when `set_stream_analog_level()` is not called, no external input volume is expected to be present - When APM is used without calling the `*_stream_analog_level()` methods (e.g., when the caller does not provide any input volume), the recorded AEC dumps won't store `Stream::applied_input_level` Other changes: - Removed `AudioProcessingImpl::capture_::prev_analog_mic_level` - Removed redundant code in `GainController2` around detecting input volume changes (already done by APM) - Adapted the `audioproc_f` and `unpack_aecdump` tools - Data dumps clean-up: the applied and the recommended input volumes are now recorded in an AGC implementation agnostic way Bug: webrtc:7494, b/241923537 Change-Id: I3cb4a731fd9f3dc19bf6ac679b7ed8c969ea283b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271544 Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38054} |
||
|---|---|---|
| .. | ||
| android/apmtest | ||
| conversational_speech | ||
| py_quality_assessment | ||
| aec_dump_based_simulator.cc | ||
| aec_dump_based_simulator.h | ||
| api_call_statistics.cc | ||
| api_call_statistics.h | ||
| apmtest.m | ||
| audio_buffer_tools.cc | ||
| audio_buffer_tools.h | ||
| audio_processing_builder_for_testing.cc | ||
| audio_processing_builder_for_testing.h | ||
| audio_processing_simulator.cc | ||
| audio_processing_simulator.h | ||
| audioproc_float_impl.cc | ||
| audioproc_float_impl.h | ||
| bitexactness_tools.cc | ||
| bitexactness_tools.h | ||
| debug_dump_replayer.cc | ||
| debug_dump_replayer.h | ||
| debug_dump_test.cc | ||
| echo_canceller_test_tools.cc | ||
| echo_canceller_test_tools.h | ||
| echo_canceller_test_tools_unittest.cc | ||
| echo_control_mock.h | ||
| fake_recording_device.cc | ||
| fake_recording_device.h | ||
| fake_recording_device_unittest.cc | ||
| performance_timer.cc | ||
| performance_timer.h | ||
| protobuf_utils.cc | ||
| protobuf_utils.h | ||
| runtime_setting_util.cc | ||
| runtime_setting_util.h | ||
| simulator_buffers.cc | ||
| simulator_buffers.h | ||
| test_utils.cc | ||
| test_utils.h | ||
| unittest.proto | ||
| wav_based_simulator.cc | ||
| wav_based_simulator.h | ||