mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-20 00:57:49 +01:00
de939432dc
This reverts commit33c5c7f5e4. Reason for revert: Fix broken API change. TBR=sprang@webrtc.org,solenberg@webrtc.org TBRing because only pc/ and api/ have changed since last LGTMed version. Original change's description: > Revert "Encode log events periodically instead of for every event." > > This reverts commitb154c27e72. > > Reason for revert: Broke the internal project. > > Original change's description: > > Encode log events periodically instead of for every event. > > > > Updated unit test to take output_period and random seed as parameters. > > Updated the peerconnection interface to allow passing in an output_period. > > > > This is in preparation of some upcoming CLs that will change the format > > to store batches of delta-encoded values. > > > > > > Bug: webrtc:8111 > > Change-Id: Id5d9844dfad8d8edad346cd7cbebc7eadaaa5416 > > Reviewed-on: https://webrtc-review.googlesource.com/22600 > > Commit-Queue: Björn Terelius <terelius@webrtc.org> > > Reviewed-by: Elad Alon <eladalon@webrtc.org> > > Reviewed-by: Tommi <tommi@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#20736} > > Change-Id: I2257c46c014adb8c7c4fb28538635cabed1f2229 > Bug: webrtc:8111 > Reviewed-on: https://webrtc-review.googlesource.com/24160 > Reviewed-by: Zhi Huang <zhihuang@webrtc.org> > Commit-Queue: Zhi Huang <zhihuang@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20738} Bug: webrtc:8111 Change-Id: Ie69862cd52d11c1e15adeb6e2caacafe16863c80 Reviewed-on: https://webrtc-review.googlesource.com/24620 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20811}
78 lines
2.6 KiB
C++
78 lines
2.6 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
|
|
#define LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <utility>
|
|
|
|
#include "api/rtceventlogoutput.h"
|
|
#include "logging/rtc_event_log/events/rtc_event.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class Clock;
|
|
|
|
enum PacketDirection { kIncomingPacket = 0, kOutgoingPacket };
|
|
|
|
class RtcEventLog {
|
|
public:
|
|
enum : size_t { kUnlimitedOutput = 0 };
|
|
enum : int64_t { kImmediateOutput = 0 };
|
|
|
|
// TODO(eladalon): Two stages are upcoming.
|
|
// 1. Extend this to actually support the new encoding.
|
|
// 2. Get rid of the legacy encoding, allowing us to get rid of this enum.
|
|
enum class EncodingType { Legacy };
|
|
|
|
virtual ~RtcEventLog() {}
|
|
|
|
// Factory method to create an RtcEventLog object.
|
|
static std::unique_ptr<RtcEventLog> Create(EncodingType encoding_type);
|
|
// TODO(nisse): webrtc::Clock is deprecated. Delete this method and
|
|
// above forward declaration of Clock when
|
|
// webrtc/system_wrappers/include/clock.h is deleted.
|
|
static std::unique_ptr<RtcEventLog> Create(const Clock* clock,
|
|
EncodingType encoding_type) {
|
|
return Create(encoding_type);
|
|
}
|
|
|
|
// Create an RtcEventLog object that does nothing.
|
|
static std::unique_ptr<RtcEventLog> CreateNull();
|
|
|
|
// Starts logging to a given output. The output might be limited in size,
|
|
// and may close itself once it has reached the maximum size.
|
|
virtual bool StartLogging(std::unique_ptr<RtcEventLogOutput> output,
|
|
int64_t output_period_ms) = 0;
|
|
|
|
// Stops logging to file and waits until the file has been closed, after
|
|
// which it would be permissible to read and/or modify it.
|
|
virtual void StopLogging() = 0;
|
|
|
|
// Log an RTC event (the type of event is determined by the subclass).
|
|
virtual void Log(std::unique_ptr<RtcEvent> event) = 0;
|
|
};
|
|
|
|
// No-op implementation is used if flag is not set, or in tests.
|
|
class RtcEventLogNullImpl : public RtcEventLog {
|
|
public:
|
|
bool StartLogging(std::unique_ptr<RtcEventLogOutput> output,
|
|
int64_t output_period_ms) override {
|
|
return false;
|
|
}
|
|
void StopLogging() override {}
|
|
void Log(std::unique_ptr<RtcEvent> event) override {}
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
|