mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 06:10:40 +01:00
5d436ac0bf
MockAudioEncoder was calling a mocked Die function on itself in its destructor. This outputs "Uninteresting mock function call" warning if the Die call was not expected. This is true even if a NiceMock is used to suppress the warnings. The purpose of testing that the destructor is called might be to protect against memory leaks when audio encoder ownership is transferred using a raw pointer. However, this case is already covered by msan checks. Bug: None Change-Id: I0603c417b4b239027859228e05ebcf83ff5aaf18 Reviewed-on: https://webrtc-review.googlesource.com/56183 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22146}
70 lines
2.3 KiB
C++
70 lines
2.3 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <memory>
|
|
|
|
#include "modules/audio_coding/acm2/codec_manager.h"
|
|
#include "modules/audio_coding/acm2/rent_a_codec.h"
|
|
#include "test/gtest.h"
|
|
#include "test/mock_audio_encoder.h"
|
|
|
|
namespace webrtc {
|
|
namespace acm2 {
|
|
|
|
using ::testing::Return;
|
|
|
|
namespace {
|
|
|
|
// Create a MockAudioEncoder with some reasonable default behavior.
|
|
std::unique_ptr<MockAudioEncoder> CreateMockEncoder() {
|
|
auto enc = std::unique_ptr<MockAudioEncoder>(new MockAudioEncoder);
|
|
EXPECT_CALL(*enc, SampleRateHz()).WillRepeatedly(Return(8000));
|
|
EXPECT_CALL(*enc, NumChannels()).WillRepeatedly(Return(1));
|
|
EXPECT_CALL(*enc, Max10MsFramesInAPacket()).WillRepeatedly(Return(1));
|
|
return enc;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST(CodecManagerTest, ExternalEncoderFec) {
|
|
auto enc0 = CreateMockEncoder();
|
|
auto enc1 = CreateMockEncoder();
|
|
auto enc2 = CreateMockEncoder();
|
|
{
|
|
::testing::InSequence s;
|
|
EXPECT_CALL(*enc0, SetFec(false)).WillOnce(Return(true));
|
|
EXPECT_CALL(*enc1, SetFec(true)).WillOnce(Return(true));
|
|
EXPECT_CALL(*enc2, SetFec(true)).WillOnce(Return(false));
|
|
}
|
|
|
|
CodecManager cm;
|
|
RentACodec rac;
|
|
|
|
// use_codec_fec starts out false.
|
|
EXPECT_FALSE(cm.GetStackParams()->use_codec_fec);
|
|
cm.GetStackParams()->speech_encoder = std::move(enc0);
|
|
EXPECT_TRUE(rac.RentEncoderStack(cm.GetStackParams()));
|
|
EXPECT_FALSE(cm.GetStackParams()->use_codec_fec);
|
|
|
|
// Set it to true.
|
|
EXPECT_EQ(true, cm.SetCodecFEC(true));
|
|
EXPECT_TRUE(cm.GetStackParams()->use_codec_fec);
|
|
cm.GetStackParams()->speech_encoder = std::move(enc1);
|
|
EXPECT_TRUE(rac.RentEncoderStack(cm.GetStackParams()));
|
|
EXPECT_TRUE(cm.GetStackParams()->use_codec_fec);
|
|
|
|
// Switch to a codec that doesn't support it.
|
|
cm.GetStackParams()->speech_encoder = std::move(enc2);
|
|
EXPECT_TRUE(rac.RentEncoderStack(cm.GetStackParams()));
|
|
EXPECT_FALSE(cm.GetStackParams()->use_codec_fec);
|
|
}
|
|
|
|
} // namespace acm2
|
|
} // namespace webrtc
|