mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
9b7232a68c
Several tests leave pending tasks behind after executing, which may affect the state of subsequent tests. This CL isolates each test in the sense that a dedicated Thread instance is created per test and then pending tasks are flushed and the Thread instance deleted. Down the line we may want to improve on this and flag those tests that leave pending tasks/timers etc. Change-Id: Ibaf3719a9974c57ac2169edca0e2a06a9ea6c78f Bug: webrtc:11574 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175132 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31268}
54 lines
1.7 KiB
C++
54 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/test/test_dependency_factory.h"
|
|
|
|
#include <memory>
|
|
#include <utility>
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/platform_thread_types.h"
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
// This checks everything in this file gets called on the same thread. It's
|
|
// static because it needs to look at the static methods too.
|
|
bool IsValidTestDependencyFactoryThread() {
|
|
const rtc::PlatformThreadRef main_thread = rtc::CurrentThreadRef();
|
|
return rtc::IsThreadRefEqual(main_thread, rtc::CurrentThreadRef());
|
|
}
|
|
} // namespace
|
|
|
|
std::unique_ptr<TestDependencyFactory> TestDependencyFactory::instance_ =
|
|
nullptr;
|
|
|
|
const TestDependencyFactory& TestDependencyFactory::GetInstance() {
|
|
RTC_DCHECK(IsValidTestDependencyFactoryThread());
|
|
if (instance_ == nullptr) {
|
|
instance_ = std::make_unique<TestDependencyFactory>();
|
|
}
|
|
return *instance_;
|
|
}
|
|
|
|
void TestDependencyFactory::SetInstance(
|
|
std::unique_ptr<TestDependencyFactory> instance) {
|
|
RTC_DCHECK(IsValidTestDependencyFactoryThread());
|
|
RTC_CHECK(instance_ == nullptr);
|
|
instance_ = std::move(instance);
|
|
}
|
|
|
|
std::unique_ptr<VideoQualityTestFixtureInterface::InjectionComponents>
|
|
TestDependencyFactory::CreateComponents() const {
|
|
RTC_DCHECK(IsValidTestDependencyFactoryThread());
|
|
return nullptr;
|
|
}
|
|
|
|
} // namespace webrtc
|