mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/sdk/objc/api/peerconnection
History
Artem Titov 63ee39d0be Revert "Add a prefix for objc category." 
This reverts commit 181ea6e414.

Reason for revert: Breaks downstream project. Kári will help to land it next week.

Original change's description:
> Add a prefix for objc category.
>
> According to the Google Objective-C style [1], category names should
> start with an appropriate prefix. WebRTC has some category definitions
> for system interfaces, but it doesn't use prefixes.
>
> $ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC"
> 0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile
> 0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition
> 0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString
> 0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView
>
> To avoid conflicts, prefix the names and methods of those categories.
> Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as
> it is not used by any other files.
>
> [1] https://google.github.io/styleguide/objcguide.html#category-naming
>
> Bug: webrtc:13884
> Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36880}

Bug: webrtc:13884
Change-Id: I85257088e4a3a62e01ff925ab5e77af83b078ef3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262420
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36885}
2022-05-13 14:47:54 +00:00
..
RTCAudioSource+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCAudioSource.h Use backticks not vertical bars to denote variables in comments for /sdk 2021-07-27 14:39:06 +00:00
RTCAudioSource.mm Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED 2021-11-15 21:44:59 +00:00
RTCAudioTrack+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCAudioTrack.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCAudioTrack.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCCertificate.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCCertificate.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCConfiguration+Native.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCConfiguration+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCConfiguration.h [ObjC] Change default sdpSemantics to UnifiedPlan. 2022-01-21 09:43:11 +00:00
RTCConfiguration.mm [C++] Change default sdp_semantics to kUnifiedPlan. 2022-01-21 10:44:56 +00:00
RTCCryptoOptions.h Rename rtc_base/ssl_stream_adapter.h constants. 2021-07-26 16:33:54 +00:00
RTCCryptoOptions.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDataChannel+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDataChannel.h Use backticks not vertical bars to denote variables in comments 2021-08-10 10:40:03 +00:00
RTCDataChannel.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCDataChannelConfiguration+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDataChannelConfiguration.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDataChannelConfiguration.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCDtmfSender+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDtmfSender.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCDtmfSender.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCEncodedImage+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCEncodedImage+Private.mm Prepare for deleting implicit conversion from raw pointer to scoped_refptr. 2022-01-18 08:22:15 +00:00
RTCFieldTrials.h remove last traces of WebRTC-Audio-SendSideBwe 2021-12-09 15:14:14 +00:00
RTCFieldTrials.mm remove last traces of WebRTC-Audio-SendSideBwe 2021-12-09 15:14:14 +00:00
RTCFileLogger.h Use backticks not vertical bars to denote variables in comments for /sdk 2021-07-27 14:39:06 +00:00
RTCFileLogger.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCIceCandidate+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCIceCandidate.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCIceCandidate.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCIceCandidateErrorEvent+Private.h Implement JNI and objc implementation for icecandidateerror event 2021-12-14 14:19:38 +00:00
RTCIceCandidateErrorEvent.h Implement JNI and objc implementation for icecandidateerror event 2021-12-14 14:19:38 +00:00
RTCIceCandidateErrorEvent.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCIceServer+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCIceServer.h Use backticks not vertical bars to denote variables in comments for /sdk 2021-07-27 14:39:06 +00:00
RTCIceServer.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCLegacyStatsReport+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCLegacyStatsReport.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCLegacyStatsReport.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCMediaConstraints+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaConstraints.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaConstraints.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCMediaSource+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaSource.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaSource.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaStream+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaStream.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaStream.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCMediaStreamTrack+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaStreamTrack.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMediaStreamTrack.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCMetrics.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMetrics.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMetricsSampleInfo+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMetricsSampleInfo.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCMetricsSampleInfo.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCPeerConnection+DataChannel.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCPeerConnection+Private.h Expose RTCSSLCertificateVerifier from iOS SDK. 2022-03-21 17:24:12 +00:00
RTCPeerConnection+Stats.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCPeerConnection.h Implement JNI and objc implementation for icecandidateerror event 2021-12-14 14:19:38 +00:00
RTCPeerConnection.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCPeerConnectionFactory+Native.h Added missing nullable annotations to iOS SDK. 2021-03-04 13:22:26 +00:00
RTCPeerConnectionFactory+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactory.h Expose RTCSSLCertificateVerifier from iOS SDK. 2022-03-21 17:24:12 +00:00
RTCPeerConnectionFactory.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCPeerConnectionFactoryBuilder+DefaultComponents.h Obj-C SDK Cleanup 2018-08-30 10:42:41 +00:00
RTCPeerConnectionFactoryBuilder+DefaultComponents.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryBuilder.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryBuilder.mm Update sdk/ to not use implicit conversion from scoped_refptr<T> to T*. 2022-04-28 08:10:15 +00:00
RTCPeerConnectionFactoryOptions+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryOptions.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryOptions.mm Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCRtcpParameters+Private.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtcpParameters.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtcpParameters.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpCodecParameters+Private.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtpCodecParameters.h Fix typo in a URL in the comment 2021-05-31 20:15:17 +00:00
RTCRtpCodecParameters.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpEncodingParameters+Private.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtpEncodingParameters.h Expose adaptive_ptime from iOS SDK. 2021-04-18 21:53:32 +00:00
RTCRtpEncodingParameters.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpHeaderExtension+Private.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpParameters+Private.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtpParameters.h Use default rtp parameters to init wrappers in iOS 2021-04-14 12:20:17 +00:00
RTCRtpParameters.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpReceiver+Native.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCRtpReceiver+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCRtpReceiver.h Reland "introduce an unsupported content description type" 2020-10-21 08:20:05 +00:00
RTCRtpReceiver.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpSender+Native.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCRtpSender+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCRtpSender.h Add presubmit test to use RTC_OBJC_TYPE on RTC_OBJC_EXPORT types. 2020-07-17 09:57:50 +00:00
RTCRtpSender.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCRtpTransceiver+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCRtpTransceiver.h Make Objective-C interface use SetDirectionWithError 2020-08-17 10:01:49 +00:00
RTCRtpTransceiver.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCSessionDescription+Private.h Fix crash of ObjC SDK sLD / sRD with incorrect SDP. 2021-08-04 20:39:00 +00:00
RTCSessionDescription.h Revert "An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid." 2021-07-31 09:53:46 +00:00
RTCSessionDescription.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCSSLAdapter.h Obj-C SDK Cleanup 2018-08-30 10:42:41 +00:00
RTCSSLAdapter.mm (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
RTCStatisticsReport+Private.h objc: Export RTCStatistics and RTCStatisticsReport 2020-05-14 13:26:01 +00:00
RTCStatisticsReport.h Support for map of string keys to uint64_t / double values in RTCStats 2021-05-25 20:38:08 +00:00
RTCStatisticsReport.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCTracing.h Obj-C SDK Cleanup 2018-08-30 10:42:41 +00:00
RTCTracing.mm Obj-C SDK Cleanup 2018-08-30 10:42:41 +00:00
RTCVideoCodecInfo+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCVideoCodecInfo+Private.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCVideoEncoderSettings+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCVideoEncoderSettings+Private.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00
RTCVideoSource+Private.h Add ability to mark video sources for screen casting in ObjC 2021-08-21 08:19:12 +00:00
RTCVideoSource.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCVideoSource.mm Prepare for deleting implicit conversion from raw pointer to scoped_refptr. 2022-01-18 08:22:15 +00:00
RTCVideoTrack+Private.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCVideoTrack.h Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. 2020-05-04 15:01:26 +00:00
RTCVideoTrack.mm Revert "Add a prefix for objc category." 2022-05-13 14:47:54 +00:00