mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-19 00:27:51 +01:00
09e9a83d91
This CL changes the way that AecDumps are created in APM. Instead of being injected, they are now created via the API. This removes the AecDumpFactory from the API surface of APM and makes the API more explicit. The CL will be followed by one more CL that deprecates the usage of the AttachAecDump API also within the audio_processing and the fuzzer folders. The CL also moves the aec_dump.* files from the include folder to the aec_dump folder and changes the build files. The reasons for this are that 1) The content of aec_dump.h is not really part of the API surface of APM. 2) Those files anyway needed to be moved to a separate build- target to avoid a circular build-file dependency caused by the other changes in this CL Bug: webrtc:5298 Change-Id: I7dd6b49de76eb44158472874e1d4ae17dca9be54 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174750 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31207}
110 lines
2.7 KiB
Text
110 lines
2.7 KiB
Text
# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import("../../../webrtc.gni") # This contains def of 'rtc_enable_protobuf'
|
|
|
|
rtc_source_set("aec_dump") {
|
|
visibility = [ "*" ]
|
|
sources = [ "aec_dump_factory.h" ]
|
|
|
|
deps = [
|
|
"..:aec_dump_interface",
|
|
"../../../rtc_base:rtc_base_approved",
|
|
"../../../rtc_base/system:file_wrapper",
|
|
"../../../rtc_base/system:rtc_export",
|
|
]
|
|
}
|
|
|
|
if (rtc_include_tests) {
|
|
rtc_library("mock_aec_dump") {
|
|
testonly = true
|
|
sources = [
|
|
"mock_aec_dump.cc",
|
|
"mock_aec_dump.h",
|
|
]
|
|
|
|
deps = [
|
|
"..:aec_dump_interface",
|
|
"..:audioproc_test_utils",
|
|
"../",
|
|
"../../../test:test_support",
|
|
]
|
|
}
|
|
|
|
rtc_library("mock_aec_dump_unittests") {
|
|
testonly = true
|
|
configs += [ "..:apm_debug_dump" ]
|
|
sources = [ "aec_dump_integration_test.cc" ]
|
|
|
|
deps = [
|
|
":mock_aec_dump",
|
|
"..:api",
|
|
"..:audioproc_test_utils",
|
|
"../",
|
|
"../../../rtc_base:rtc_base_approved",
|
|
"//testing/gtest",
|
|
]
|
|
}
|
|
}
|
|
|
|
if (rtc_enable_protobuf) {
|
|
rtc_library("aec_dump_impl") {
|
|
sources = [
|
|
"aec_dump_impl.cc",
|
|
"aec_dump_impl.h",
|
|
"capture_stream_info.cc",
|
|
"capture_stream_info.h",
|
|
"write_to_file_task.cc",
|
|
"write_to_file_task.h",
|
|
]
|
|
|
|
deps = [
|
|
":aec_dump",
|
|
"..:aec_dump_interface",
|
|
"../../../api/audio:audio_frame_api",
|
|
"../../../api/task_queue",
|
|
"../../../rtc_base:checks",
|
|
"../../../rtc_base:ignore_wundef",
|
|
"../../../rtc_base:protobuf_utils",
|
|
"../../../rtc_base:rtc_base_approved",
|
|
"../../../rtc_base:rtc_task_queue",
|
|
"../../../rtc_base/system:file_wrapper",
|
|
"../../../system_wrappers",
|
|
]
|
|
|
|
deps += [ "../:audioproc_debug_proto" ]
|
|
}
|
|
|
|
if (rtc_include_tests) {
|
|
rtc_library("aec_dump_unittests") {
|
|
testonly = true
|
|
defines = []
|
|
deps = [
|
|
":aec_dump",
|
|
":aec_dump_impl",
|
|
"..:audioproc_debug_proto",
|
|
"../",
|
|
"../../../rtc_base:task_queue_for_test",
|
|
"../../../test:fileutils",
|
|
"../../../test:test_support",
|
|
"//testing/gtest",
|
|
]
|
|
sources = [ "aec_dump_unittest.cc" ]
|
|
}
|
|
}
|
|
}
|
|
|
|
rtc_library("null_aec_dump_factory") {
|
|
assert_no_deps = [ ":aec_dump_impl" ]
|
|
sources = [ "null_aec_dump_factory.cc" ]
|
|
|
|
deps = [
|
|
":aec_dump",
|
|
"..:aec_dump_interface",
|
|
]
|
|
}
|