mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00

- Add `WebRTC-Audio-OpusDecodeStereoByDefault` field trial - Behind that field trial, `AudioDecoderOpus::SdpToConfig` uses 2 instead of 1 as default number of channels when the `stereo` codec param is unspecified - Instead of wiring up `FieldTrialsView` to `SdpToConfig`, which requires API changes that break downstream projects, a change in `AudioDecoderOpus::Config` is made to signal when the number of channels is forced via SDP config Bug: webrtc:379996136 Change-Id: If70eb19bc7e3bc74dd0423610cb04ae33ea602fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368860 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43440}
49 lines
1.7 KiB
C++
49 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef API_AUDIO_CODECS_OPUS_AUDIO_DECODER_OPUS_H_
|
|
#define API_AUDIO_CODECS_OPUS_AUDIO_DECODER_OPUS_H_
|
|
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
#include "api/audio_codecs/audio_codec_pair_id.h"
|
|
#include "api/audio_codecs/audio_decoder.h"
|
|
#include "api/audio_codecs/audio_format.h"
|
|
#include "api/environment/environment.h"
|
|
#include "rtc_base/system/rtc_export.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Opus decoder API for use as a template parameter to
|
|
// CreateAudioDecoderFactory<...>().
|
|
struct RTC_EXPORT AudioDecoderOpus {
|
|
struct Config {
|
|
bool IsOk() const; // Checks if the values are currently OK.
|
|
int sample_rate_hz = 48000;
|
|
std::optional<int> num_channels;
|
|
};
|
|
static std::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format);
|
|
static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs);
|
|
|
|
static std::unique_ptr<AudioDecoder> MakeAudioDecoder(const Environment& env,
|
|
Config config);
|
|
static std::unique_ptr<AudioDecoder> MakeAudioDecoder(
|
|
const Environment& env,
|
|
Config config,
|
|
std::optional<AudioCodecPairId> /*codec_pair_id*/) {
|
|
return MakeAudioDecoder(env, config);
|
|
}
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // API_AUDIO_CODECS_OPUS_AUDIO_DECODER_OPUS_H_
|