mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 23:01:21 +01:00
1aec594018
Merges the two targets in modules/audio_processing and removes some redundant code. This enables not writing a bunch of redundant code in https://webrtc-review.googlesource.com/c/src/+/70502 ':audio_processing' did depend on ':aec_dump_interface'. 'modules/audio_processing/aec_dump' did depend on 'aec_dump_interface' but not ':audio_processing'. Having the AecDump implementation not depending on 'audio_processing' allows to have faster compilation time and reduces the dependencies. However, maintaining such a decoupling makes APM and AecDump client code more complex. NOTRY=true # want this in and 'ios_api_framework' seems stuck. Bug: webrtc:7404 Change-Id: I75a5f234591014ac42d52bc1a36526072f5be89c Reviewed-on: https://webrtc-review.googlesource.com/76603 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23244}
70 lines
2.1 KiB
C++
70 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <utility>
|
|
|
|
#include "modules/audio_processing/aec_dump/aec_dump_factory.h"
|
|
|
|
#include "rtc_base/task_queue.h"
|
|
#include "test/gtest.h"
|
|
#include "test/testsupport/fileutils.h"
|
|
|
|
TEST(AecDumper, APICallsDoNotCrash) {
|
|
// Note order of initialization: Task queue has to be initialized
|
|
// before AecDump.
|
|
rtc::TaskQueue file_writer_queue("file_writer_queue");
|
|
|
|
const std::string filename =
|
|
webrtc::test::TempFilename(webrtc::test::OutputPath(), "aec_dump");
|
|
|
|
{
|
|
std::unique_ptr<webrtc::AecDump> aec_dump =
|
|
webrtc::AecDumpFactory::Create(filename, -1, &file_writer_queue);
|
|
|
|
const webrtc::AudioFrame frame;
|
|
aec_dump->WriteRenderStreamMessage(frame);
|
|
|
|
aec_dump->AddCaptureStreamInput(frame);
|
|
aec_dump->AddCaptureStreamOutput(frame);
|
|
|
|
aec_dump->WriteCaptureStreamMessage();
|
|
|
|
webrtc::InternalAPMConfig apm_config;
|
|
aec_dump->WriteConfig(apm_config);
|
|
|
|
webrtc::ProcessingConfig api_format;
|
|
aec_dump->WriteInitMessage(api_format);
|
|
}
|
|
// Remove file after the AecDump d-tor has finished.
|
|
ASSERT_EQ(0, remove(filename.c_str()));
|
|
}
|
|
|
|
TEST(AecDumper, WriteToFile) {
|
|
rtc::TaskQueue file_writer_queue("file_writer_queue");
|
|
|
|
const std::string filename =
|
|
webrtc::test::TempFilename(webrtc::test::OutputPath(), "aec_dump");
|
|
|
|
{
|
|
std::unique_ptr<webrtc::AecDump> aec_dump =
|
|
webrtc::AecDumpFactory::Create(filename, -1, &file_writer_queue);
|
|
const webrtc::AudioFrame frame;
|
|
aec_dump->WriteRenderStreamMessage(frame);
|
|
}
|
|
|
|
// Verify the file has been written after the AecDump d-tor has
|
|
// finished.
|
|
FILE* fid = fopen(filename.c_str(), "r");
|
|
ASSERT_TRUE(fid != NULL);
|
|
|
|
// Clean it up.
|
|
ASSERT_EQ(0, fclose(fid));
|
|
ASSERT_EQ(0, remove(filename.c_str()));
|
|
}
|