mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 15:20:42 +01:00
73ac90863d
It is actually fine to use streams in testonly code. This CL relaxes the presubmit check in order allow streams usage in tests. Bug: webrtc:8982 Change-Id: I18bbf079e804815956cd94ac761cc13022c0761e No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/61701 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#22482}
70 lines
2.2 KiB
Python
70 lines
2.2 KiB
Python
# Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
import tempfile
|
|
from contextlib import contextmanager
|
|
|
|
|
|
# The module find_depot_tools lives into the ./build directory.
|
|
SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
|
|
SRC_DIR = os.path.normpath(os.path.join(SCRIPT_DIR, os.pardir, os.pardir))
|
|
sys.path.append(os.path.join(SRC_DIR, 'build'))
|
|
import find_depot_tools
|
|
|
|
|
|
@contextmanager
|
|
def DefaultGnProject():
|
|
"""Generates a GN projects with defaul args and returns the path to it."""
|
|
out_dir = tempfile.mkdtemp('gn')
|
|
gen_command = [
|
|
sys.executable,
|
|
os.path.join(find_depot_tools.DEPOT_TOOLS_PATH, 'gn.py'),
|
|
'gen',
|
|
out_dir,
|
|
]
|
|
subprocess.check_output(gen_command)
|
|
try:
|
|
yield out_dir
|
|
finally:
|
|
shutil.rmtree(out_dir, ignore_errors=True)
|
|
|
|
|
|
def BelongsToTestTarget(file_path, out_dir):
|
|
"""Returns True if file_path is part of a testonly build target.
|
|
|
|
This function relies on 'gn refs'. It actually runs:
|
|
$ gn refs <out_dir> file_path --testonly=true`
|
|
|
|
Which returns a list of build targets containing file_path (well, only
|
|
one build target should own a file, but that is not a strict rule).
|
|
|
|
If the list is empty, it means the file is owned by a non-testonly build
|
|
target and the function will return False. Otherwise it will return True.
|
|
|
|
Args:
|
|
file_path: string with the local path of the file to analyze.
|
|
out_dir: the path to the GN out directory to analyze.
|
|
|
|
Returns:
|
|
boolean: True if the file belongs to a testonly build target.
|
|
"""
|
|
refs_command = [
|
|
sys.executable,
|
|
os.path.join(find_depot_tools.DEPOT_TOOLS_PATH, 'gn.py'),
|
|
'refs',
|
|
out_dir,
|
|
file_path,
|
|
'--testonly=true'
|
|
]
|
|
output = subprocess.check_output(refs_command)
|
|
# If file_path belongs to a test target, output will contain a list of them.
|
|
return output != ''
|