mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
157b7814b9
This CL removes two deprecated methods from the VideoEncoder interface:
* int32_t SetRates(uint32_t, uint32_t);
* int32_t SetRateAllocation(const VideoBitrateAllocation&, uint32_t);
These are no longer used, instead the new version must be implemented:
void SetRates(const RateControlParameters&) = 0;
Migrating is straight forward. For the old SetRates, simple replace:
int32_t MyEncoder::SetRates(uint32_t bitrate, uint32_t framerate) {
with
void MyEncoder::SetRates(const RateControlParameters& parameters) {
uint32_t bitrate = parameters.bitrate.get_sum_kbps();
uint32_t framerate =
static_cast<uint32_t>(parameters.framerate_fps + 0.5);
For SetRateAllocation, replace:
int32_t MyEncoder::SetRateAllocation(
const VideoBitrateAllocation& allocation,
uint32_t framerate) {
with
void MyEncoder::SetRates(const RateControlParameters& parameters) {
const VideoBitrateAllocation& allocation = parameters.bitrate;
uint32_t framerate =
static_cast<uint32_t>(parameters.framerate_fps + 0.5);
Two more things to note:
1. The new method is void. Previously the only use of the return value
in production code was to log a more or less generic error message.
Instead, log the actual error from the encoder when it happens,
then just return.
2. The new method is pure virtual; it must be overriden even in test.
This CL is intended to be landed two weeks after creation, on Thursday
May 9th 2019.
Bug: webrtc:10481
Change-Id: I61349571a280bd40cd100ca9f93c4aa7748ed30d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134214
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27926}
|
||
|---|---|---|
| .. | ||
| test | ||
| bitstream_parser.h | ||
| BUILD.gn | ||
| builtin_video_decoder_factory.cc | ||
| builtin_video_decoder_factory.h | ||
| builtin_video_encoder_factory.cc | ||
| builtin_video_encoder_factory.h | ||
| OWNERS | ||
| sdp_video_format.cc | ||
| sdp_video_format.h | ||
| video_codec.cc | ||
| video_codec.h | ||
| video_decoder.cc | ||
| video_decoder.h | ||
| video_decoder_factory.cc | ||
| video_decoder_factory.h | ||
| video_decoder_software_fallback_wrapper.cc | ||
| video_decoder_software_fallback_wrapper.h | ||
| video_encoder.cc | ||
| video_encoder.h | ||
| video_encoder_config.cc | ||
| video_encoder_config.h | ||
| video_encoder_factory.h | ||
| video_encoder_software_fallback_wrapper.cc | ||
| video_encoder_software_fallback_wrapper.h | ||
| vp8_frame_buffer_controller.h | ||
| vp8_frame_config.cc | ||
| vp8_frame_config.h | ||
| vp8_temporal_layers.cc | ||
| vp8_temporal_layers.h | ||
| vp8_temporal_layers_factory.cc | ||
| vp8_temporal_layers_factory.h | ||