webrtc/modules/rtp_rtcp/source/rtcp_packet
Harald Alvestrand 70206d6608 Reland "Make RTCP cumulative_lost be a signed value"
Instead of modifying the API, we'll add a new function to return
the true value, and have a shim that returns what other code expects.

> This reverts commit 4c34f435db.
>
> Reason for revert: Broke internal projects. Type mismatch.
>
> Original change's description:
> > Make RTCP cumulative_lost be a signed value
> >
> > This is formally defined as a signed 24-bit value in RFC 3550 section 6.4.1.
> > See RFC 3550 Appendix A.3 for the reason why it may turn negative.
> >
> > Noticed on discuss-webrtc mailing list.
> >
> > BUG=webrtc:8626
> >
> > Change-Id: I7317f73e9490a876e8445bd3d6b66095ce53ca0a
> > Reviewed-on: https://webrtc-review.googlesource.com/30901
> > Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21142}
>
> TBR=stefan@webrtc.org,hta@webrtc.org
>
> Change-Id: I544f7979d584cfb72a2d0d526f4fef84aebeecb3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8626
> Reviewed-on: https://webrtc-review.googlesource.com/31040
> Reviewed-by: Zhi Huang <zhihuang@webrtc.org>
> Commit-Queue: Zhi Huang <zhihuang@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21144}

Change-Id: I95c8c248f4f85c4d1aa2a47424d8c4d954d4ae7a
Bug: webrtc:8626
Reviewed-on: https://webrtc-review.googlesource.com/31220
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21154}
2017-12-08 08:47:09 +00:00
..
app.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
app.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
app_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
bye.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
bye.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
bye_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
common_header.cc Stop using LOG macros in favor of RTC_ prefixed macros. 2017-11-09 11:56:32 +00:00
common_header.h Add rtcp::CommonHeader::packet_size function 2017-11-09 10:50:15 +00:00
common_header_unittest.cc Add rtcp::CommonHeader::packet_size function 2017-11-09 10:50:15 +00:00
compound_packet.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
compound_packet.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
compound_packet_unittest.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
dlrr.cc Move some numeric utility code from rtc_base/ to rtc_base/numerics/ 2017-11-22 11:21:47 +00:00
dlrr.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
dlrr_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
extended_jitter_report.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
extended_jitter_report.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
extended_jitter_report_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
extended_reports.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
extended_reports.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
extended_reports_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
fir.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
fir.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
fir_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
nack.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
nack.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
nack_unittest.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
pli.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
pli.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
pli_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
psfb.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
psfb.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
rapid_resync_request.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
rapid_resync_request.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
rapid_resync_request_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
receiver_report.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
receiver_report.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
receiver_report_unittest.cc Reland "Make RTCP cumulative_lost be a signed value" 2017-12-08 08:47:09 +00:00
remb.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
remb.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
remb_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
report_block.cc Reland "Make RTCP cumulative_lost be a signed value" 2017-12-08 08:47:09 +00:00
report_block.h Reland "Make RTCP cumulative_lost be a signed value" 2017-12-08 08:47:09 +00:00
report_block_unittest.cc Reland "Make RTCP cumulative_lost be a signed value" 2017-12-08 08:47:09 +00:00
rrtr.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
rrtr.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
rrtr_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
rtpfb.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
rtpfb.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
sdes.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
sdes.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
sdes_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
sender_report.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
sender_report.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
sender_report_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
target_bitrate.cc Move some numeric utility code from rtc_base/ to rtc_base/numerics/ 2017-11-22 11:21:47 +00:00
target_bitrate.h Move rtcp packet classes from rtp_rtcp to rtp_rtcp_format target 2017-09-15 17:36:30 +00:00
target_bitrate_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
tmmb_item.cc Stop using LOG macros in favor of RTC_ prefixed macros. 2017-11-09 11:56:32 +00:00
tmmb_item.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
tmmbn.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
tmmbn.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
tmmbn_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
tmmbr.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
tmmbr.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
tmmbr_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
transport_feedback.cc Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
transport_feedback.h Change RtcpPacket::PacketReadyCallback to rtc::FunctionView 2017-12-07 11:20:08 +00:00
transport_feedback_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
voip_metric.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
voip_metric.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
voip_metric_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00