mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 23:57:59 +01:00
fef0500aa7
This is a fairly minimalistic string building class that can be used instead of stringstream, which is discouraged but tempting to use due to its convenient interface and familiarity for anyone using our logging macros. As a starter, I'm changing the string building code in ReceiveStatisticsProxy and SendStatisticsProxy from using stringstream and using SimpleStringBuilder instead. In the case of SimpleStringBuilder, there's a single allocation, it's done on the stack (fast), and minimal code is required for each concatenation. The developer is responsible for ensuring that the buffer size is adequate but the class won't overflow the buffer. In dcheck-enabled builds, a check will go off if we run out of buffer space. As part of using SimpleStringBuilder for a small part of rtc::LogMessage, a few more changes were made: - SimpleStringBuilder is used for formatting errors instead of ostringstream. - A new 'noop' state has been introduced for log messages that will be dropped. - Use a static (singleton) noop ostream object for noop logging messages instead of building up an actual ostringstream object that will be dropped. - Add a LogMessageForTest class for better state inspection/testing. - Fix benign bug in LogTest.Perf, change the test to not use File IO and always enable it. - Ensure that minimal work is done for noop messages. - Remove dependency on rtc::Thread. - Add tests for the extra_ field, correctly parsed paths and noop handling. Bug: webrtc:8529, webrtc:4364, webrtc:8933 Change-Id: Ifa258c135135945e4560d9e24315f7d96f784acb Reviewed-on: https://webrtc-review.googlesource.com/55520 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22203}
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/strings/string_builder.h"
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "rtc_base/stringutils.h"
|
|
|
|
namespace rtc {
|
|
|
|
TEST(SimpleStringBuilder, Limit) {
|
|
SimpleStringBuilder<10> sb;
|
|
EXPECT_EQ(0u, strlen(sb.str()));
|
|
|
|
// Test that for a SSB with a buffer size of 10, that we can write 9 chars
|
|
// into it.
|
|
sb << "012345678"; // 9 characters + '\0'.
|
|
EXPECT_EQ(0, strcmp(sb.str(), "012345678"));
|
|
}
|
|
|
|
TEST(SimpleStringBuilder, NumbersAndChars) {
|
|
SimpleStringBuilder<100> sb;
|
|
sb << 1 << ':' << 2.1 << ":" << 2.2f << ':' << 78187493520ll << ':'
|
|
<< 78187493520ul;
|
|
EXPECT_EQ(0, strcmp(sb.str(), "1:2.100000:2.200000:78187493520:78187493520"));
|
|
}
|
|
|
|
TEST(SimpleStringBuilder, Format) {
|
|
SimpleStringBuilder<100> sb;
|
|
sb << "Here we go - ";
|
|
sb.AppendFormat("This is a hex formatted value: 0x%08x", 3735928559);
|
|
EXPECT_EQ(0,
|
|
strcmp(sb.str(),
|
|
"Here we go - This is a hex formatted value: 0xdeadbeef"));
|
|
}
|
|
|
|
TEST(SimpleStringBuilder, StdString) {
|
|
SimpleStringBuilder<100> sb;
|
|
std::string str = "does this work?";
|
|
sb << str;
|
|
EXPECT_EQ(str, sb.str());
|
|
}
|
|
|
|
} // namespace rtc
|