mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
97df932ecc
The feature isn't in use by Google and has proven to contain security issues. It's time to remove it. Bug: b/324864439 Change-Id: I80344eb2f2060469d2d69a54dc4519fdd02ab4ea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340324 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41808}
140 lines
5.9 KiB
C++
140 lines
5.9 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/experiments/min_video_bitrate_experiment.h"
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/units/data_rate.h"
|
|
#include "api/video/video_codec_type.h"
|
|
#include "test/field_trial.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
NulloptForAllCodecsIfFieldTrialUndefined) {
|
|
test::ScopedFieldTrials field_trials("");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
NulloptForAllCodecsIfFieldTrialDisabled) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/Disabled,br:123kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest, BrForAllCodecsIfDefined) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/Enabled,br:123kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest, BrTrumpsSpecificCodecConfigs) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,br:123kbps,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::KilobitsPerSec(123)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
SpecificCodecConfigsIgnoredIfExpDisabled) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Disabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest, SpecificCodecConfigsUsedIfExpEnabled) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::KilobitsPerSec(100)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::KilobitsPerSec(200)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::KilobitsPerSec(300)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
Vp8BitrateValueTakenFromFallbackIfAvailable) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/"
|
|
"WebRTC-VP8-Forced-Fallback-Encoder-v2/"
|
|
"Enabled-444444,555555,666666/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::BitsPerSec(666666)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
NonVp8BitrateValuesTakenFromMinVideoBitrate) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/"
|
|
"WebRTC-VP8-Forced-Fallback-Encoder-v2/"
|
|
"Enabled-444444,555555,666666/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::KilobitsPerSec(200)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::KilobitsPerSec(300)));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace webrtc
|