mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-18 08:07:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/api/task_queue
History
Mirko Bonadei 317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
..
BUILD.gn Poison default task queue factory 2019-07-10 14:08:20 +00:00
default_task_queue_factory.h Introduce global task queue factory. 2019-01-18 11:25:15 +00:00
default_task_queue_factory_gcd.cc Migrate gcd task queue implementation to TaskQueueBase interface 2019-02-20 17:08:53 +00:00
default_task_queue_factory_libevent.cc Migrate libevent task queue implementation to TaskQueueBase interface 2019-02-12 10:58:36 +00:00
default_task_queue_factory_stdlib.cc Migrate stdlib task queue to TaskQueueBase interface 2019-02-21 14:36:07 +00:00
default_task_queue_factory_unittest.cc Test default TaskQueue implementation via TaskQueueBase interface 2019-02-26 14:01:45 +00:00
default_task_queue_factory_win.cc Migrate win task queue to TaskQueueBase interface 2019-02-21 09:33:42 +00:00
DEPS Migrate RepeatingTask to take raw pointer to TaskQueueBase instead of TaskQueue 2019-03-06 18:44:35 +00:00
queued_task.h Publish rtc::QueuedTask in api as webrtc::QueuedTask 2019-01-14 14:48:12 +00:00
task_queue_base.cc Migrate gcd task queue implementation to TaskQueueBase interface 2019-02-20 17:08:53 +00:00
task_queue_base.h Reland "Delete rtc::TaskQueue::Current in favor of webrtc::TaskQueueBase::Current" 2019-03-11 12:32:49 +00:00
task_queue_factory.h Drop support for link-time injection of the rtc::TaskQueue::Impl 2019-02-27 10:07:34 +00:00
task_queue_test.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
task_queue_test.h Use task queue factory factory as parameter for TaskQueueTest 2019-02-07 11:00:17 +00:00