mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
8c68845090
Variance calculation isn't currently used but overflow checks there may cause unnecessary crash. Instead of completely deleting useful feature it's now easy to disable it by choosing an appropriate Counter class. Bug: None Change-Id: Ifa8bbf2d023553504caa768e08e59ebccfb2fbb4 Reviewed-on: https://webrtc-review.googlesource.com/99561 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24699}
79 lines
2.2 KiB
C++
79 lines
2.2 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/numerics/sample_counter.h"
|
|
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "test/gmock.h"
|
|
#include "test/gtest.h"
|
|
|
|
using testing::Eq;
|
|
|
|
namespace rtc {
|
|
|
|
TEST(SampleCounterTest, ProcessesNoSamples) {
|
|
constexpr int kMinSamples = 1;
|
|
SampleCounter counter;
|
|
EXPECT_THAT(counter.Avg(kMinSamples), Eq(absl::nullopt));
|
|
EXPECT_THAT(counter.Max(), Eq(absl::nullopt));
|
|
}
|
|
|
|
TEST(SampleCounterTest, NotEnoughSamples) {
|
|
constexpr int kMinSamples = 6;
|
|
SampleCounter counter;
|
|
for (int value : {1, 2, 3, 4, 5}) {
|
|
counter.Add(value);
|
|
}
|
|
EXPECT_THAT(counter.Avg(kMinSamples), Eq(absl::nullopt));
|
|
EXPECT_THAT(counter.Max(), Eq(5));
|
|
}
|
|
|
|
TEST(SampleCounterTest, EnoughSamples) {
|
|
constexpr int kMinSamples = 5;
|
|
SampleCounter counter;
|
|
for (int value : {1, 2, 3, 4, 5}) {
|
|
counter.Add(value);
|
|
}
|
|
EXPECT_THAT(counter.Avg(kMinSamples), Eq(3));
|
|
EXPECT_THAT(counter.Max(), Eq(5));
|
|
}
|
|
|
|
TEST(SampleCounterTest, ComputesVariance) {
|
|
constexpr int kMinSamples = 5;
|
|
SampleCounterWithVariance counter;
|
|
for (int value : {1, 2, 3, 4, 5}) {
|
|
counter.Add(value);
|
|
}
|
|
EXPECT_THAT(counter.Variance(kMinSamples), Eq(2));
|
|
}
|
|
|
|
TEST(SampleCounterTest, AggregatesTwoCounters) {
|
|
constexpr int kMinSamples = 5;
|
|
SampleCounterWithVariance counter1;
|
|
for (int value : {1, 2, 3}) {
|
|
counter1.Add(value);
|
|
}
|
|
SampleCounterWithVariance counter2;
|
|
for (int value : {4, 5}) {
|
|
counter2.Add(value);
|
|
}
|
|
// Before aggregation there is not enough samples.
|
|
EXPECT_THAT(counter1.Avg(kMinSamples), Eq(absl::nullopt));
|
|
EXPECT_THAT(counter1.Variance(kMinSamples), Eq(absl::nullopt));
|
|
// Aggregate counter2 in counter1.
|
|
counter1.Add(counter2);
|
|
EXPECT_THAT(counter1.Avg(kMinSamples), Eq(3));
|
|
EXPECT_THAT(counter1.Max(), Eq(5));
|
|
EXPECT_THAT(counter1.Variance(kMinSamples), Eq(2));
|
|
}
|
|
|
|
} // namespace rtc
|