mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 23:57:59 +01:00

The initial implementation forced the sender to use different sizes of the RTP header extension depending on if a feedback request is included or not. This can be a problem if the RTP header is pre- allocated. This CL changes this so that a static size of 4 bytes can be used for the TransportSequenceNumberV2 RTP header extension. The change in the protocol to get this to work is that FeedbackRequest::sequence_count == 0 means that no feedback is requested, and FeedbackRequest::sequence_count == 1 means that feedback is requested for the current packet only. Bug: webrtc:10262 Change-Id: Ia5134b3daf49f8a5b89f6c717894f6e055f39c8e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125420 Commit-Queue: Johannes Kron <kron@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26985}
259 lines
9.9 KiB
C++
259 lines
9.9 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/remote_bitrate_estimator/remote_estimator_proxy.h"
|
|
|
|
#include <algorithm>
|
|
#include <limits>
|
|
|
|
#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/logging.h"
|
|
#include "rtc_base/numerics/safe_minmax.h"
|
|
#include "system_wrappers/include/clock.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// TODO(sprang): Tune these!
|
|
const int RemoteEstimatorProxy::kBackWindowMs = 500;
|
|
const int RemoteEstimatorProxy::kMinSendIntervalMs = 50;
|
|
const int RemoteEstimatorProxy::kMaxSendIntervalMs = 250;
|
|
const int RemoteEstimatorProxy::kDefaultSendIntervalMs = 100;
|
|
// Impossible to request feedback older than what can be represented by 15 bits.
|
|
const int RemoteEstimatorProxy::kMaxNumberOfPackets = (1 << 15);
|
|
|
|
// The maximum allowed value for a timestamp in milliseconds. This is lower
|
|
// than the numerical limit since we often convert to microseconds.
|
|
static constexpr int64_t kMaxTimeMs =
|
|
std::numeric_limits<int64_t>::max() / 1000;
|
|
|
|
RemoteEstimatorProxy::RemoteEstimatorProxy(
|
|
Clock* clock,
|
|
TransportFeedbackSenderInterface* feedback_sender)
|
|
: clock_(clock),
|
|
feedback_sender_(feedback_sender),
|
|
last_process_time_ms_(-1),
|
|
media_ssrc_(0),
|
|
feedback_packet_count_(0),
|
|
window_start_seq_(-1),
|
|
send_interval_ms_(kDefaultSendIntervalMs),
|
|
send_feedback_on_request_only_(false) {}
|
|
|
|
RemoteEstimatorProxy::~RemoteEstimatorProxy() {}
|
|
|
|
void RemoteEstimatorProxy::IncomingPacket(int64_t arrival_time_ms,
|
|
size_t payload_size,
|
|
const RTPHeader& header) {
|
|
if (!header.extension.hasTransportSequenceNumber) {
|
|
RTC_LOG(LS_WARNING)
|
|
<< "RemoteEstimatorProxy: Incoming packet "
|
|
"is missing the transport sequence number extension!";
|
|
return;
|
|
}
|
|
rtc::CritScope cs(&lock_);
|
|
media_ssrc_ = header.ssrc;
|
|
OnPacketArrival(header.extension.transportSequenceNumber, arrival_time_ms,
|
|
header.extension.feedback_request);
|
|
}
|
|
|
|
bool RemoteEstimatorProxy::LatestEstimate(std::vector<unsigned int>* ssrcs,
|
|
unsigned int* bitrate_bps) const {
|
|
return false;
|
|
}
|
|
|
|
int64_t RemoteEstimatorProxy::TimeUntilNextProcess() {
|
|
rtc::CritScope cs(&lock_);
|
|
if (send_feedback_on_request_only_) {
|
|
// Wait a day until next process.
|
|
return 24 * 60 * 60 * 1000;
|
|
} else if (last_process_time_ms_ != -1) {
|
|
int64_t now = clock_->TimeInMilliseconds();
|
|
if (now - last_process_time_ms_ < send_interval_ms_)
|
|
return last_process_time_ms_ + send_interval_ms_ - now;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
void RemoteEstimatorProxy::Process() {
|
|
rtc::CritScope cs(&lock_);
|
|
if (send_feedback_on_request_only_) {
|
|
return;
|
|
}
|
|
last_process_time_ms_ = clock_->TimeInMilliseconds();
|
|
|
|
SendPeriodicFeedbacks();
|
|
}
|
|
|
|
void RemoteEstimatorProxy::OnBitrateChanged(int bitrate_bps) {
|
|
// TwccReportSize = Ipv4(20B) + UDP(8B) + SRTP(10B) +
|
|
// AverageTwccReport(30B)
|
|
// TwccReport size at 50ms interval is 24 byte.
|
|
// TwccReport size at 250ms interval is 36 byte.
|
|
// AverageTwccReport = (TwccReport(50ms) + TwccReport(250ms)) / 2
|
|
constexpr int kTwccReportSize = 20 + 8 + 10 + 30;
|
|
constexpr double kMinTwccRate =
|
|
kTwccReportSize * 8.0 * 1000.0 / kMaxSendIntervalMs;
|
|
constexpr double kMaxTwccRate =
|
|
kTwccReportSize * 8.0 * 1000.0 / kMinSendIntervalMs;
|
|
|
|
// Let TWCC reports occupy 5% of total bandwidth.
|
|
rtc::CritScope cs(&lock_);
|
|
send_interval_ms_ = static_cast<int>(
|
|
0.5 + kTwccReportSize * 8.0 * 1000.0 /
|
|
rtc::SafeClamp(0.05 * bitrate_bps, kMinTwccRate, kMaxTwccRate));
|
|
}
|
|
|
|
void RemoteEstimatorProxy::SetSendFeedbackOnRequestOnly(
|
|
bool send_feedback_on_request_only) {
|
|
rtc::CritScope cs(&lock_);
|
|
send_feedback_on_request_only_ = send_feedback_on_request_only;
|
|
}
|
|
|
|
void RemoteEstimatorProxy::OnPacketArrival(
|
|
uint16_t sequence_number,
|
|
int64_t arrival_time,
|
|
absl::optional<FeedbackRequest> feedback_request) {
|
|
if (arrival_time < 0 || arrival_time > kMaxTimeMs) {
|
|
RTC_LOG(LS_WARNING) << "Arrival time out of bounds: " << arrival_time;
|
|
return;
|
|
}
|
|
|
|
// TODO(holmer): We should handle a backwards wrap here if the first
|
|
// sequence number was small and the new sequence number is large. The
|
|
// SequenceNumberUnwrapper doesn't do this, so we should replace this with
|
|
// calls to IsNewerSequenceNumber instead.
|
|
int64_t seq = unwrapper_.Unwrap(sequence_number);
|
|
if (window_start_seq_ != -1 && seq > window_start_seq_ + 0xFFFF / 2) {
|
|
RTC_LOG(LS_WARNING) << "Skipping this sequence number (" << sequence_number
|
|
<< ") since it likely is reordered, but the unwrapper"
|
|
"failed to handle it. Feedback window starts at "
|
|
<< window_start_seq_ << ".";
|
|
return;
|
|
}
|
|
|
|
if (send_feedback_on_request_only_) {
|
|
// Remove old packet arrival times.
|
|
auto clear_to_it =
|
|
packet_arrival_times_.lower_bound(seq - kMaxNumberOfPackets);
|
|
packet_arrival_times_.erase(packet_arrival_times_.begin(), clear_to_it);
|
|
} else if (packet_arrival_times_.lower_bound(window_start_seq_) ==
|
|
packet_arrival_times_.end()) {
|
|
// Start new feedback packet, cull old packets.
|
|
for (auto it = packet_arrival_times_.begin();
|
|
it != packet_arrival_times_.end() && it->first < seq &&
|
|
arrival_time - it->second >= kBackWindowMs;) {
|
|
auto delete_it = it;
|
|
++it;
|
|
packet_arrival_times_.erase(delete_it);
|
|
}
|
|
}
|
|
|
|
if (window_start_seq_ == -1) {
|
|
window_start_seq_ = sequence_number;
|
|
} else if (seq < window_start_seq_) {
|
|
window_start_seq_ = seq;
|
|
}
|
|
|
|
// We are only interested in the first time a packet is received.
|
|
if (packet_arrival_times_.find(seq) != packet_arrival_times_.end())
|
|
return;
|
|
|
|
packet_arrival_times_[seq] = arrival_time;
|
|
|
|
if (feedback_request) {
|
|
// Send feedback packet immediately.
|
|
SendFeedbackOnRequest(seq, *feedback_request);
|
|
}
|
|
}
|
|
|
|
void RemoteEstimatorProxy::SendPeriodicFeedbacks() {
|
|
// |window_start_seq_| is the first sequence number to include in the current
|
|
// feedback packet. Some older may still be in the map, in case a reordering
|
|
// happens and we need to retransmit them.
|
|
for (auto begin_iterator =
|
|
packet_arrival_times_.lower_bound(window_start_seq_);
|
|
begin_iterator != packet_arrival_times_.cend();
|
|
begin_iterator = packet_arrival_times_.lower_bound(window_start_seq_)) {
|
|
rtcp::TransportFeedback feedback_packet;
|
|
window_start_seq_ = BuildFeedbackPacket(
|
|
feedback_packet_count_++, media_ssrc_, window_start_seq_,
|
|
begin_iterator, packet_arrival_times_.cend(), &feedback_packet);
|
|
|
|
RTC_DCHECK(feedback_sender_ != nullptr);
|
|
feedback_sender_->SendTransportFeedback(&feedback_packet);
|
|
// Note: Don't erase items from packet_arrival_times_ after sending, in case
|
|
// they need to be re-sent after a reordering. Removal will be handled
|
|
// by OnPacketArrival once packets are too old.
|
|
}
|
|
}
|
|
|
|
void RemoteEstimatorProxy::SendFeedbackOnRequest(
|
|
int64_t sequence_number,
|
|
const FeedbackRequest& feedback_request) {
|
|
if (feedback_request.sequence_count == 0) {
|
|
return;
|
|
}
|
|
rtcp::TransportFeedback feedback_packet(feedback_request.include_timestamps);
|
|
|
|
int64_t first_sequence_number =
|
|
sequence_number - feedback_request.sequence_count + 1;
|
|
auto begin_iterator =
|
|
packet_arrival_times_.lower_bound(first_sequence_number);
|
|
auto end_iterator = packet_arrival_times_.upper_bound(sequence_number);
|
|
|
|
// window_start_seq must be updated to make sure that we detect incorrectly
|
|
// unwrapped sequence_numbers in OnPacketArrival().
|
|
window_start_seq_ = BuildFeedbackPacket(feedback_packet_count_++, media_ssrc_,
|
|
first_sequence_number, begin_iterator,
|
|
end_iterator, &feedback_packet);
|
|
|
|
// Clear up to the first packet that is included in this feedback packet.
|
|
packet_arrival_times_.erase(packet_arrival_times_.begin(), begin_iterator);
|
|
|
|
RTC_DCHECK(feedback_sender_ != nullptr);
|
|
feedback_sender_->SendTransportFeedback(&feedback_packet);
|
|
}
|
|
|
|
int64_t RemoteEstimatorProxy::BuildFeedbackPacket(
|
|
uint8_t feedback_packet_count,
|
|
uint32_t media_ssrc,
|
|
int64_t base_sequence_number,
|
|
std::map<int64_t, int64_t>::const_iterator begin_iterator,
|
|
std::map<int64_t, int64_t>::const_iterator end_iterator,
|
|
rtcp::TransportFeedback* feedback_packet) {
|
|
RTC_DCHECK(begin_iterator != end_iterator);
|
|
|
|
// TODO(sprang): Measure receive times in microseconds and remove the
|
|
// conversions below.
|
|
feedback_packet->SetMediaSsrc(media_ssrc);
|
|
// Base sequence number is the expected first sequence number. This is known,
|
|
// but we might not have actually received it, so the base time shall be the
|
|
// time of the first received packet in the feedback.
|
|
feedback_packet->SetBase(static_cast<uint16_t>(base_sequence_number & 0xFFFF),
|
|
begin_iterator->second * 1000);
|
|
feedback_packet->SetFeedbackSequenceNumber(feedback_packet_count);
|
|
int64_t next_sequence_number = base_sequence_number;
|
|
for (auto it = begin_iterator; it != end_iterator; ++it) {
|
|
if (!feedback_packet->AddReceivedPacket(
|
|
static_cast<uint16_t>(it->first & 0xFFFF), it->second * 1000)) {
|
|
// If we can't even add the first seq to the feedback packet, we won't be
|
|
// able to build it at all.
|
|
RTC_CHECK(begin_iterator != it);
|
|
|
|
// Could not add timestamp, feedback packet might be full. Return and
|
|
// try again with a fresh packet.
|
|
break;
|
|
}
|
|
next_sequence_number = it->first + 1;
|
|
}
|
|
return next_sequence_number;
|
|
}
|
|
|
|
} // namespace webrtc
|