mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 23:57:59 +01:00

Before this change, there was no way for a client to indicate to the dcSCTP library if a packet that was supposed to be sent, was actually sent. It was assumed that it always was. To handle temporary failures better, such as retrying to send packets that failed to be sent when the send buffer was full, this information is propagated to the library. Note that this change only covers the API and adaptations to clients. The actual implementation to make use of this information is done as a follow-up change. Bug: webrtc:12943 Change-Id: I8f9c62e17f1de1566fa6b0f13a57a3db9f4e7684 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228563 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34767}
550 lines
21 KiB
C++
550 lines
21 KiB
C++
/*
|
|
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "net/dcsctp/socket/stream_reset_handler.h"
|
|
|
|
#include <array>
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <type_traits>
|
|
#include <vector>
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/array_view.h"
|
|
#include "net/dcsctp/common/internal_types.h"
|
|
#include "net/dcsctp/packet/chunk/reconfig_chunk.h"
|
|
#include "net/dcsctp/packet/parameter/incoming_ssn_reset_request_parameter.h"
|
|
#include "net/dcsctp/packet/parameter/outgoing_ssn_reset_request_parameter.h"
|
|
#include "net/dcsctp/packet/parameter/parameter.h"
|
|
#include "net/dcsctp/packet/parameter/reconfiguration_response_parameter.h"
|
|
#include "net/dcsctp/public/dcsctp_message.h"
|
|
#include "net/dcsctp/rx/data_tracker.h"
|
|
#include "net/dcsctp/rx/reassembly_queue.h"
|
|
#include "net/dcsctp/socket/mock_context.h"
|
|
#include "net/dcsctp/socket/mock_dcsctp_socket_callbacks.h"
|
|
#include "net/dcsctp/testing/data_generator.h"
|
|
#include "net/dcsctp/testing/testing_macros.h"
|
|
#include "net/dcsctp/timer/timer.h"
|
|
#include "net/dcsctp/tx/mock_send_queue.h"
|
|
#include "net/dcsctp/tx/retransmission_queue.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "test/gmock.h"
|
|
|
|
namespace dcsctp {
|
|
namespace {
|
|
using ::testing::_;
|
|
using ::testing::IsEmpty;
|
|
using ::testing::NiceMock;
|
|
using ::testing::Return;
|
|
using ::testing::SizeIs;
|
|
using ::testing::UnorderedElementsAre;
|
|
using ResponseResult = ReconfigurationResponseParameter::Result;
|
|
|
|
constexpr TSN kMyInitialTsn = MockContext::MyInitialTsn();
|
|
constexpr ReconfigRequestSN kMyInitialReqSn = ReconfigRequestSN(*kMyInitialTsn);
|
|
constexpr TSN kPeerInitialTsn = MockContext::PeerInitialTsn();
|
|
constexpr ReconfigRequestSN kPeerInitialReqSn =
|
|
ReconfigRequestSN(*kPeerInitialTsn);
|
|
constexpr uint32_t kArwnd = 131072;
|
|
constexpr DurationMs kRto = DurationMs(250);
|
|
|
|
constexpr std::array<uint8_t, 4> kShortPayload = {1, 2, 3, 4};
|
|
|
|
MATCHER_P3(SctpMessageIs, stream_id, ppid, expected_payload, "") {
|
|
if (arg.stream_id() != stream_id) {
|
|
*result_listener << "the stream_id is " << *arg.stream_id();
|
|
return false;
|
|
}
|
|
|
|
if (arg.ppid() != ppid) {
|
|
*result_listener << "the ppid is " << *arg.ppid();
|
|
return false;
|
|
}
|
|
|
|
if (std::vector<uint8_t>(arg.payload().begin(), arg.payload().end()) !=
|
|
std::vector<uint8_t>(expected_payload.begin(), expected_payload.end())) {
|
|
*result_listener << "the payload is wrong";
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
TSN AddTo(TSN tsn, int delta) {
|
|
return TSN(*tsn + delta);
|
|
}
|
|
|
|
ReconfigRequestSN AddTo(ReconfigRequestSN req_sn, int delta) {
|
|
return ReconfigRequestSN(*req_sn + delta);
|
|
}
|
|
|
|
class StreamResetHandlerTest : public testing::Test {
|
|
protected:
|
|
StreamResetHandlerTest()
|
|
: ctx_(&callbacks_),
|
|
timer_manager_([this]() { return callbacks_.CreateTimeout(); }),
|
|
delayed_ack_timer_(timer_manager_.CreateTimer(
|
|
"test/delayed_ack",
|
|
[]() { return absl::nullopt; },
|
|
TimerOptions(DurationMs(0)))),
|
|
t3_rtx_timer_(timer_manager_.CreateTimer(
|
|
"test/t3_rtx",
|
|
[]() { return absl::nullopt; },
|
|
TimerOptions(DurationMs(0)))),
|
|
buf_("log: ", delayed_ack_timer_.get(), kPeerInitialTsn),
|
|
reasm_("log: ", kPeerInitialTsn, kArwnd),
|
|
retransmission_queue_(
|
|
"",
|
|
kMyInitialTsn,
|
|
kArwnd,
|
|
producer_,
|
|
[](DurationMs rtt_ms) {},
|
|
[]() {},
|
|
*t3_rtx_timer_,
|
|
/*options=*/{}),
|
|
handler_("log: ",
|
|
&ctx_,
|
|
&timer_manager_,
|
|
&buf_,
|
|
&reasm_,
|
|
&retransmission_queue_) {
|
|
EXPECT_CALL(ctx_, current_rto).WillRepeatedly(Return(kRto));
|
|
}
|
|
|
|
void AdvanceTime(DurationMs duration) {
|
|
callbacks_.AdvanceTime(kRto);
|
|
for (;;) {
|
|
absl::optional<TimeoutID> timeout_id = callbacks_.GetNextExpiredTimeout();
|
|
if (!timeout_id.has_value()) {
|
|
break;
|
|
}
|
|
timer_manager_.HandleTimeout(*timeout_id);
|
|
}
|
|
}
|
|
|
|
// Handles the passed in RE-CONFIG `chunk` and returns the responses
|
|
// that are sent in the response RE-CONFIG.
|
|
std::vector<ReconfigurationResponseParameter> HandleAndCatchResponse(
|
|
ReConfigChunk chunk) {
|
|
handler_.HandleReConfig(std::move(chunk));
|
|
|
|
std::vector<uint8_t> payload = callbacks_.ConsumeSentPacket();
|
|
if (payload.empty()) {
|
|
EXPECT_TRUE(false);
|
|
return {};
|
|
}
|
|
|
|
std::vector<ReconfigurationResponseParameter> responses;
|
|
absl::optional<SctpPacket> p = SctpPacket::Parse(payload);
|
|
if (!p.has_value()) {
|
|
EXPECT_TRUE(false);
|
|
return {};
|
|
}
|
|
if (p->descriptors().size() != 1) {
|
|
EXPECT_TRUE(false);
|
|
return {};
|
|
}
|
|
absl::optional<ReConfigChunk> response_chunk =
|
|
ReConfigChunk::Parse(p->descriptors()[0].data);
|
|
if (!response_chunk.has_value()) {
|
|
EXPECT_TRUE(false);
|
|
return {};
|
|
}
|
|
for (const auto& desc : response_chunk->parameters().descriptors()) {
|
|
if (desc.type == ReconfigurationResponseParameter::kType) {
|
|
absl::optional<ReconfigurationResponseParameter> response =
|
|
ReconfigurationResponseParameter::Parse(desc.data);
|
|
if (!response.has_value()) {
|
|
EXPECT_TRUE(false);
|
|
return {};
|
|
}
|
|
responses.emplace_back(*std::move(response));
|
|
}
|
|
}
|
|
return responses;
|
|
}
|
|
|
|
DataGenerator gen_;
|
|
NiceMock<MockDcSctpSocketCallbacks> callbacks_;
|
|
NiceMock<MockContext> ctx_;
|
|
NiceMock<MockSendQueue> producer_;
|
|
TimerManager timer_manager_;
|
|
std::unique_ptr<Timer> delayed_ack_timer_;
|
|
std::unique_ptr<Timer> t3_rtx_timer_;
|
|
DataTracker buf_;
|
|
ReassemblyQueue reasm_;
|
|
RetransmissionQueue retransmission_queue_;
|
|
StreamResetHandler handler_;
|
|
};
|
|
|
|
TEST_F(StreamResetHandlerTest, ChunkWithNoParametersReturnsError) {
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(0);
|
|
EXPECT_CALL(callbacks_, OnError).Times(1);
|
|
handler_.HandleReConfig(ReConfigChunk(Parameters()));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, ChunkWithInvalidParametersReturnsError) {
|
|
Parameters::Builder builder;
|
|
// Two OutgoingSSNResetRequestParameter in a RE-CONFIG is not valid.
|
|
builder.Add(OutgoingSSNResetRequestParameter(ReconfigRequestSN(1),
|
|
ReconfigRequestSN(10),
|
|
kPeerInitialTsn, {StreamID(1)}));
|
|
builder.Add(OutgoingSSNResetRequestParameter(ReconfigRequestSN(2),
|
|
ReconfigRequestSN(10),
|
|
kPeerInitialTsn, {StreamID(2)}));
|
|
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(0);
|
|
EXPECT_CALL(callbacks_, OnError).Times(1);
|
|
handler_.HandleReConfig(ReConfigChunk(builder.Build()));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, FailToDeliverWithoutResettingStream) {
|
|
reasm_.Add(kPeerInitialTsn, gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 1), gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
|
|
buf_.Observe(kPeerInitialTsn);
|
|
buf_.Observe(AddTo(kPeerInitialTsn, 1));
|
|
EXPECT_THAT(reasm_.FlushMessages(),
|
|
UnorderedElementsAre(
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload)));
|
|
|
|
gen_.ResetStream();
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 2), gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
EXPECT_THAT(reasm_.FlushMessages(), IsEmpty());
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, ResetStreamsNotDeferred) {
|
|
reasm_.Add(kPeerInitialTsn, gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 1), gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
|
|
buf_.Observe(kPeerInitialTsn);
|
|
buf_.Observe(AddTo(kPeerInitialTsn, 1));
|
|
EXPECT_THAT(reasm_.FlushMessages(),
|
|
UnorderedElementsAre(
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload)));
|
|
|
|
Parameters::Builder builder;
|
|
builder.Add(OutgoingSSNResetRequestParameter(
|
|
kPeerInitialReqSn, ReconfigRequestSN(3), AddTo(kPeerInitialTsn, 1),
|
|
{StreamID(1)}));
|
|
|
|
std::vector<ReconfigurationResponseParameter> responses =
|
|
HandleAndCatchResponse(ReConfigChunk(builder.Build()));
|
|
EXPECT_THAT(responses, SizeIs(1));
|
|
EXPECT_EQ(responses[0].result(), ResponseResult::kSuccessPerformed);
|
|
|
|
gen_.ResetStream();
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 2), gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
EXPECT_THAT(reasm_.FlushMessages(),
|
|
UnorderedElementsAre(
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload)));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, ResetStreamsDeferred) {
|
|
DataGeneratorOptions opts;
|
|
opts.message_id = MID(0);
|
|
reasm_.Add(kPeerInitialTsn, gen_.Ordered({1, 2, 3, 4}, "BE", opts));
|
|
|
|
opts.message_id = MID(1);
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 1), gen_.Ordered({1, 2, 3, 4}, "BE", opts));
|
|
|
|
buf_.Observe(kPeerInitialTsn);
|
|
buf_.Observe(AddTo(kPeerInitialTsn, 1));
|
|
EXPECT_THAT(reasm_.FlushMessages(),
|
|
UnorderedElementsAre(
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload)));
|
|
|
|
Parameters::Builder builder;
|
|
builder.Add(OutgoingSSNResetRequestParameter(
|
|
kPeerInitialReqSn, ReconfigRequestSN(3), AddTo(kPeerInitialTsn, 3),
|
|
{StreamID(1)}));
|
|
|
|
std::vector<ReconfigurationResponseParameter> responses =
|
|
HandleAndCatchResponse(ReConfigChunk(builder.Build()));
|
|
EXPECT_THAT(responses, SizeIs(1));
|
|
EXPECT_EQ(responses[0].result(), ResponseResult::kInProgress);
|
|
|
|
opts.message_id = MID(1);
|
|
opts.ppid = PPID(5);
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 5), gen_.Ordered({1, 2, 3, 4}, "BE", opts));
|
|
reasm_.MaybeResetStreamsDeferred(AddTo(kPeerInitialTsn, 1));
|
|
|
|
opts.message_id = MID(0);
|
|
opts.ppid = PPID(4);
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 4), gen_.Ordered({1, 2, 3, 4}, "BE", opts));
|
|
reasm_.MaybeResetStreamsDeferred(AddTo(kPeerInitialTsn, 1));
|
|
|
|
opts.message_id = MID(3);
|
|
opts.ppid = PPID(3);
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 3), gen_.Ordered({1, 2, 3, 4}, "BE", opts));
|
|
reasm_.MaybeResetStreamsDeferred(AddTo(kPeerInitialTsn, 1));
|
|
|
|
opts.message_id = MID(2);
|
|
opts.ppid = PPID(2);
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 2), gen_.Ordered({1, 2, 3, 4}, "BE", opts));
|
|
reasm_.MaybeResetStreamsDeferred(AddTo(kPeerInitialTsn, 5));
|
|
|
|
EXPECT_THAT(
|
|
reasm_.FlushMessages(),
|
|
UnorderedElementsAre(SctpMessageIs(StreamID(1), PPID(2), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(3), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(4), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(5), kShortPayload)));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendOutgoingRequestDirectly) {
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(1);
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42)}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
absl::optional<ReConfigChunk> reconfig = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req,
|
|
reconfig->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
|
|
EXPECT_EQ(req.request_sequence_number(), kMyInitialReqSn);
|
|
EXPECT_EQ(req.sender_last_assigned_tsn(),
|
|
TSN(*retransmission_queue_.next_tsn() - 1));
|
|
EXPECT_THAT(req.stream_ids(), UnorderedElementsAre(StreamID(42)));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, ResetMultipleStreamsInOneRequest) {
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(3);
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42)}));
|
|
handler_.ResetStreams(
|
|
std::vector<StreamID>({StreamID(43), StreamID(44), StreamID(41)}));
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42), StreamID(40)}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
absl::optional<ReConfigChunk> reconfig = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req,
|
|
reconfig->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
|
|
EXPECT_EQ(req.request_sequence_number(), kMyInitialReqSn);
|
|
EXPECT_EQ(req.sender_last_assigned_tsn(),
|
|
TSN(*retransmission_queue_.next_tsn() - 1));
|
|
EXPECT_THAT(req.stream_ids(),
|
|
UnorderedElementsAre(StreamID(40), StreamID(41), StreamID(42),
|
|
StreamID(43), StreamID(44)));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendOutgoingRequestDeferred) {
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(1);
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42)}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams())
|
|
.WillOnce(Return(false))
|
|
.WillOnce(Return(false))
|
|
.WillOnce(Return(true));
|
|
|
|
EXPECT_FALSE(handler_.MakeStreamResetRequest().has_value());
|
|
EXPECT_FALSE(handler_.MakeStreamResetRequest().has_value());
|
|
EXPECT_TRUE(handler_.MakeStreamResetRequest().has_value());
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendOutgoingResettingOnPositiveResponse) {
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(1);
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42)}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
|
|
absl::optional<ReConfigChunk> reconfig = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req,
|
|
reconfig->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
|
|
Parameters::Builder builder;
|
|
builder.Add(ReconfigurationResponseParameter(
|
|
req.request_sequence_number(), ResponseResult::kSuccessPerformed));
|
|
ReConfigChunk response_reconfig(builder.Build());
|
|
|
|
EXPECT_CALL(producer_, CommitResetStreams()).Times(1);
|
|
EXPECT_CALL(producer_, RollbackResetStreams()).Times(0);
|
|
|
|
// Processing a response shouldn't result in sending anything.
|
|
EXPECT_CALL(callbacks_, OnError).Times(0);
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(0);
|
|
handler_.HandleReConfig(std::move(response_reconfig));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendOutgoingResetRollbackOnError) {
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(1);
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42)}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
|
|
absl::optional<ReConfigChunk> reconfig = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req,
|
|
reconfig->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
|
|
Parameters::Builder builder;
|
|
builder.Add(ReconfigurationResponseParameter(
|
|
req.request_sequence_number(), ResponseResult::kErrorBadSequenceNumber));
|
|
ReConfigChunk response_reconfig(builder.Build());
|
|
|
|
EXPECT_CALL(producer_, CommitResetStreams()).Times(0);
|
|
EXPECT_CALL(producer_, RollbackResetStreams()).Times(1);
|
|
|
|
// Only requests should result in sending responses.
|
|
EXPECT_CALL(callbacks_, OnError).Times(0);
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(0);
|
|
handler_.HandleReConfig(std::move(response_reconfig));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendOutgoingResetRetransmitOnInProgress) {
|
|
static constexpr StreamID kStreamToReset = StreamID(42);
|
|
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(1);
|
|
handler_.ResetStreams(std::vector<StreamID>({kStreamToReset}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
|
|
absl::optional<ReConfigChunk> reconfig1 = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig1.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req1,
|
|
reconfig1->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
|
|
// Simulate that the peer responded "In Progress".
|
|
Parameters::Builder builder;
|
|
builder.Add(ReconfigurationResponseParameter(req1.request_sequence_number(),
|
|
ResponseResult::kInProgress));
|
|
ReConfigChunk response_reconfig(builder.Build());
|
|
|
|
EXPECT_CALL(producer_, CommitResetStreams()).Times(0);
|
|
EXPECT_CALL(producer_, RollbackResetStreams()).Times(0);
|
|
|
|
// Processing a response shouldn't result in sending anything.
|
|
EXPECT_CALL(callbacks_, OnError).Times(0);
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(0);
|
|
handler_.HandleReConfig(std::move(response_reconfig));
|
|
|
|
// Let some time pass, so that the reconfig timer expires, and retries the
|
|
// same request.
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(1);
|
|
AdvanceTime(kRto);
|
|
|
|
std::vector<uint8_t> payload = callbacks_.ConsumeSentPacket();
|
|
ASSERT_FALSE(payload.empty());
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(SctpPacket packet, SctpPacket::Parse(payload));
|
|
ASSERT_THAT(packet.descriptors(), SizeIs(1));
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
ReConfigChunk reconfig2,
|
|
ReConfigChunk::Parse(packet.descriptors()[0].data));
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req2,
|
|
reconfig2.parameters().get<OutgoingSSNResetRequestParameter>());
|
|
|
|
EXPECT_EQ(req2.request_sequence_number(),
|
|
AddTo(req1.request_sequence_number(), 1));
|
|
EXPECT_THAT(req2.stream_ids(), UnorderedElementsAre(kStreamToReset));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, ResetWhileRequestIsSentWillQueue) {
|
|
EXPECT_CALL(producer_, PrepareResetStreams).Times(1);
|
|
handler_.ResetStreams(std::vector<StreamID>({StreamID(42)}));
|
|
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
absl::optional<ReConfigChunk> reconfig1 = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig1.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req1,
|
|
reconfig1->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
EXPECT_EQ(req1.request_sequence_number(), kMyInitialReqSn);
|
|
EXPECT_EQ(req1.sender_last_assigned_tsn(),
|
|
AddTo(retransmission_queue_.next_tsn(), -1));
|
|
EXPECT_THAT(req1.stream_ids(), UnorderedElementsAre(StreamID(42)));
|
|
|
|
// Streams reset while the request is in-flight will be queued.
|
|
StreamID stream_ids[] = {StreamID(41), StreamID(43)};
|
|
handler_.ResetStreams(stream_ids);
|
|
EXPECT_EQ(handler_.MakeStreamResetRequest(), absl::nullopt);
|
|
|
|
Parameters::Builder builder;
|
|
builder.Add(ReconfigurationResponseParameter(
|
|
req1.request_sequence_number(), ResponseResult::kSuccessPerformed));
|
|
ReConfigChunk response_reconfig(builder.Build());
|
|
|
|
EXPECT_CALL(producer_, CommitResetStreams()).Times(1);
|
|
EXPECT_CALL(producer_, RollbackResetStreams()).Times(0);
|
|
|
|
// Processing a response shouldn't result in sending anything.
|
|
EXPECT_CALL(callbacks_, OnError).Times(0);
|
|
EXPECT_CALL(callbacks_, SendPacketWithStatus).Times(0);
|
|
handler_.HandleReConfig(std::move(response_reconfig));
|
|
|
|
// Response has been processed. A new request can be sent.
|
|
EXPECT_CALL(producer_, CanResetStreams()).WillOnce(Return(true));
|
|
absl::optional<ReConfigChunk> reconfig2 = handler_.MakeStreamResetRequest();
|
|
ASSERT_TRUE(reconfig2.has_value());
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req2,
|
|
reconfig2->parameters().get<OutgoingSSNResetRequestParameter>());
|
|
EXPECT_EQ(req2.request_sequence_number(), AddTo(kMyInitialReqSn, 1));
|
|
EXPECT_EQ(req2.sender_last_assigned_tsn(),
|
|
TSN(*retransmission_queue_.next_tsn() - 1));
|
|
EXPECT_THAT(req2.stream_ids(),
|
|
UnorderedElementsAre(StreamID(41), StreamID(43)));
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendIncomingResetJustReturnsNothingPerformed) {
|
|
Parameters::Builder builder;
|
|
builder.Add(
|
|
IncomingSSNResetRequestParameter(kPeerInitialReqSn, {StreamID(1)}));
|
|
|
|
std::vector<ReconfigurationResponseParameter> responses =
|
|
HandleAndCatchResponse(ReConfigChunk(builder.Build()));
|
|
ASSERT_THAT(responses, SizeIs(1));
|
|
EXPECT_THAT(responses[0].response_sequence_number(), kPeerInitialReqSn);
|
|
EXPECT_THAT(responses[0].result(), ResponseResult::kSuccessNothingToDo);
|
|
}
|
|
|
|
TEST_F(StreamResetHandlerTest, SendSameRequestTwiceReturnsNothingToDo) {
|
|
reasm_.Add(kPeerInitialTsn, gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
reasm_.Add(AddTo(kPeerInitialTsn, 1), gen_.Ordered({1, 2, 3, 4}, "BE"));
|
|
|
|
buf_.Observe(kPeerInitialTsn);
|
|
buf_.Observe(AddTo(kPeerInitialTsn, 1));
|
|
EXPECT_THAT(reasm_.FlushMessages(),
|
|
UnorderedElementsAre(
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload),
|
|
SctpMessageIs(StreamID(1), PPID(53), kShortPayload)));
|
|
|
|
Parameters::Builder builder1;
|
|
builder1.Add(OutgoingSSNResetRequestParameter(
|
|
kPeerInitialReqSn, ReconfigRequestSN(3), AddTo(kPeerInitialTsn, 1),
|
|
{StreamID(1)}));
|
|
|
|
std::vector<ReconfigurationResponseParameter> responses1 =
|
|
HandleAndCatchResponse(ReConfigChunk(builder1.Build()));
|
|
EXPECT_THAT(responses1, SizeIs(1));
|
|
EXPECT_EQ(responses1[0].result(), ResponseResult::kSuccessPerformed);
|
|
|
|
Parameters::Builder builder2;
|
|
builder2.Add(OutgoingSSNResetRequestParameter(
|
|
kPeerInitialReqSn, ReconfigRequestSN(3), AddTo(kPeerInitialTsn, 1),
|
|
{StreamID(1)}));
|
|
|
|
std::vector<ReconfigurationResponseParameter> responses2 =
|
|
HandleAndCatchResponse(ReConfigChunk(builder2.Build()));
|
|
EXPECT_THAT(responses2, SizeIs(1));
|
|
EXPECT_EQ(responses2[0].result(), ResponseResult::kSuccessNothingToDo);
|
|
}
|
|
} // namespace
|
|
} // namespace dcsctp
|