mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
94f4d9effc
Reason for revert:
Fails video quality tests in Chrome: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
I should have looked more closer at those :(
Original issue's description:
> PyLint fixes for tools-webrtc and webrtc/tools
>
> Fix a lot of errors before bringing in the new config in
> https://codereview.webrtc.org/2737963003/
>
> BUG=webrtc:7303
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2736233003
> Cr-Commit-Position: refs/heads/master@{#17137}
> Committed: f5318e1f39
TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7303
Review-Url: https://codereview.webrtc.org/2737233003
Cr-Commit-Position: refs/heads/master@{#17142}
104 lines
3.7 KiB
Python
Executable file
104 lines
3.7 KiB
Python
Executable file
#!/usr/bin/env python
|
|
# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
"""Script to cleanup symlinks created from setup_links.py.
|
|
|
|
Before 177567c518b121731e507e9b9c4049c4dc96e4c8 (#15754) we had a Chromium
|
|
checkout which we created symlinks into. In order to do clean syncs after
|
|
landing that change, this script cleans up any old symlinks, avoiding annoying
|
|
manual cleanup needed in order to complete gclient sync.
|
|
"""
|
|
|
|
import logging
|
|
import optparse
|
|
import os
|
|
import shelve
|
|
import subprocess
|
|
import sys
|
|
|
|
|
|
ROOT_DIR = os.path.dirname(os.path.abspath(__file__))
|
|
LINKS_DB = 'links'
|
|
|
|
# Version management to make future upgrades/downgrades easier to support.
|
|
SCHEMA_VERSION = 1
|
|
|
|
class WebRTCLinkSetup(object):
|
|
def __init__(self, links_db, dry_run=False):
|
|
self._dry_run = dry_run
|
|
self._links_db = links_db
|
|
|
|
def CleanupLinks(self):
|
|
logging.debug('CleanupLinks')
|
|
for source, link_path in self._links_db.iteritems():
|
|
if source == 'SCHEMA_VERSION':
|
|
continue
|
|
if os.path.islink(link_path) or sys.platform.startswith('win'):
|
|
# os.path.islink() always returns false on Windows
|
|
# See http://bugs.python.org/issue13143.
|
|
logging.debug('Removing link to %s at %s', source, link_path)
|
|
if not self._dry_run:
|
|
if os.path.exists(link_path):
|
|
if sys.platform.startswith('win') and os.path.isdir(link_path):
|
|
subprocess.check_call(['rmdir', '/q', '/s', link_path],
|
|
shell=True)
|
|
else:
|
|
os.remove(link_path)
|
|
del self._links_db[source]
|
|
|
|
|
|
def _initialize_database(filename):
|
|
links_database = shelve.open(filename)
|
|
# Wipe the database if this version of the script ends up looking at a
|
|
# newer (future) version of the links db, just to be sure.
|
|
version = links_database.get('SCHEMA_VERSION')
|
|
if version and version != SCHEMA_VERSION:
|
|
logging.info('Found database with schema version %s while this script only '
|
|
'supports %s. Wiping previous database contents.', version,
|
|
SCHEMA_VERSION)
|
|
links_database.clear()
|
|
links_database['SCHEMA_VERSION'] = SCHEMA_VERSION
|
|
return links_database
|
|
|
|
|
|
def main():
|
|
parser = optparse.OptionParser()
|
|
parser.add_option('-d', '--dry-run', action='store_true', default=False,
|
|
help='Print what would be done, but don\'t perform any '
|
|
'operations. This will automatically set logging to '
|
|
'verbose.')
|
|
parser.add_option('-v', '--verbose', action='store_const',
|
|
const=logging.DEBUG, default=logging.INFO,
|
|
help='Print verbose output for debugging.')
|
|
options, _ = parser.parse_args()
|
|
|
|
if options.dry_run:
|
|
options.verbose = logging.DEBUG
|
|
logging.basicConfig(format='%(message)s', level=options.verbose)
|
|
|
|
# Work from the root directory of the checkout.
|
|
script_dir = os.path.dirname(os.path.abspath(__file__))
|
|
os.chdir(script_dir)
|
|
|
|
# The database file gets .db appended on some platforms.
|
|
db_filenames = [LINKS_DB, LINKS_DB + '.db']
|
|
if any(os.path.isfile(f) for f in db_filenames):
|
|
links_database = _initialize_database(LINKS_DB)
|
|
try:
|
|
symlink_creator = WebRTCLinkSetup(links_database, options.dry_run)
|
|
symlink_creator.CleanupLinks()
|
|
finally:
|
|
for f in db_filenames:
|
|
if os.path.isfile(f):
|
|
os.remove(f)
|
|
return 0
|
|
|
|
|
|
if __name__ == '__main__':
|
|
sys.exit(main())
|