mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_coding/audio_network_adaptor
History
Bjorn A Mellem 413ccc49ec Stop DCHECK which occurs in ANA BitrateController when overhead is zero. 
https://webrtc-review.googlesource.com/c/src/+/119121 added two calls to set the observed overhead.  Both SetupSendCodec() and ReconfigureSendCodec() update the encoder's overhead.  However, these calls happen before RTP has issued any callbacks to set the overhead, so they tell the encoder that the overhead is zero.

This change checks whether the overhead has been set to a non-zero value before each of the new calls and adds a DCHECK to quickly catch future cases which attempt to set overhead to zero.

Bug: webrtc:10150
Change-Id: Ieb3345ecfcda1cf25538d5d424383df17a71b4a2
TBR: solenberg@webrtc.org
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134260
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Reviewed-by: Anton Sukhanov <sukhanov@webrtc.org>
Reviewed-by: Minyue Li <minyue@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27793}
2019-04-27 00:20:37 +00:00
..
include [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
mock Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
util Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
audio_network_adaptor_config.cc Create RtcEventLogEncoderLegacy 2017-10-03 13:51:59 +00:00
audio_network_adaptor_impl.cc webrtc: Remove semicolons. 2019-02-20 16:02:59 +00:00
audio_network_adaptor_impl.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
audio_network_adaptor_impl_unittest.cc (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
bitrate_controller.cc Stop DCHECK which occurs in ANA BitrateController when overhead is zero. 2019-04-27 00:20:37 +00:00
bitrate_controller.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
bitrate_controller_unittest.cc Reformat the WebRTC code base 2018-06-19 14:00:39 +00:00
channel_controller.cc Optional: Use nullopt and implicit construction in /modules/audio_coding 2017-11-17 11:58:37 +00:00
channel_controller.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
channel_controller_unittest.cc Replace rtc::Optional with absl::optional in modules/audio_coding 2018-06-19 12:46:20 +00:00
config.proto Added configurable offsets to the per-packet overhead in the ANA frame length and bitrate controllers. 2017-09-28 08:11:16 +00:00
controller.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
controller.h Replace rtc::Optional with absl::optional in modules/audio_coding 2018-06-19 12:46:20 +00:00
controller_manager.cc Remove webrtc::ProtoString. 2019-02-16 11:11:45 +00:00
controller_manager.h Remove webrtc::ProtoString. 2019-02-16 11:11:45 +00:00
controller_manager_unittest.cc Remove webrtc::ProtoString. 2019-02-16 11:11:45 +00:00
debug_dump.proto Moving src/webrtc into src/. 2017-09-15 04:25:06 +00:00
debug_dump_writer.cc Remove webrtc::ProtoString. 2019-02-16 11:11:45 +00:00
debug_dump_writer.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
dtx_controller.cc Optional: Use nullopt and implicit construction in /modules/audio_coding 2017-11-17 11:58:37 +00:00
dtx_controller.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
dtx_controller_unittest.cc Replace rtc::Optional with absl::optional in modules/audio_coding 2018-06-19 12:46:20 +00:00
event_log_writer.cc [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
event_log_writer.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
event_log_writer_unittest.cc Fully qualify googletest symbols. 2019-04-09 17:18:20 +00:00
fec_controller_plr_based.cc [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
fec_controller_plr_based.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
fec_controller_plr_based_unittest.cc [clang-tidy] Apply performance-for-range-copy fixes. 2019-01-28 09:53:50 +00:00
fec_controller_rplr_based.cc [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
fec_controller_rplr_based.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
fec_controller_rplr_based_unittest.cc [clang-tidy] Apply performance-for-range-copy fixes. 2019-01-28 09:53:50 +00:00
frame_length_controller.cc Use ordered data structure for supported frame lengths in ANA. 2019-01-03 11:56:09 +00:00
frame_length_controller.h (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
frame_length_controller_unittest.cc Use ordered data structure for supported frame lengths in ANA. 2019-01-03 11:56:09 +00:00
parse_ana_dump.py Fixing py lint errors 2018-07-23 15:28:48 +00:00