mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 22:00:47 +01:00
0deda15c96
This reverts commitb625101da8. Reason for revert: Found problem that was specific how configuration is handled for VP9. A 1-line change in webrtc_video_engine.cc line 3715. Thanks Rasmus and great that this was tested! Original change's description: > Revert "RtpEncodingParameters::request_resolution patch 1" > > This reverts commitef7359e679. > > Reason for revert: Breaks downstream test > > Original change's description: > > RtpEncodingParameters::request_resolution patch 1 > > > > This patch adds RtpEncodingParameters::request_resolution > > with documentation and plumming. No behaviour is changed yet. > > > > Bug: webrtc:14451 > > Change-Id: I1f4f83a312ee8c293e3d8f02b950751e62048304 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276262 > > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > > Reviewed-by: Henrik Boström <hbos@webrtc.org> > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > > Commit-Queue: Jonas Oreland <jonaso@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#38172} > > Bug: webrtc:14451 > Change-Id: I4b9590e23ec38e9e1c2e51a4600ef96b129439f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276541 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Jonas Oreland <jonaso@webrtc.org> > Owners-Override: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38176} Bug: webrtc:14451 Change-Id: Ica9b74180bce22d09bf289126bb5ac137bf9eb70 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276543 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38178}
61 lines
1.9 KiB
C++
61 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef API_VIDEO_RECORDABLE_ENCODED_FRAME_H_
|
|
#define API_VIDEO_RECORDABLE_ENCODED_FRAME_H_
|
|
|
|
#include "api/array_view.h"
|
|
#include "api/scoped_refptr.h"
|
|
#include "api/units/timestamp.h"
|
|
#include "api/video/color_space.h"
|
|
#include "api/video/encoded_image.h"
|
|
#include "api/video/video_codec_type.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Interface for accessing recordable elements of an encoded frame.
|
|
class RecordableEncodedFrame {
|
|
public:
|
|
// Encoded resolution in pixels
|
|
// TODO(bugs.webrtc.org/12114) : remove in favor of Resolution.
|
|
struct EncodedResolution {
|
|
bool empty() const { return width == 0 && height == 0; }
|
|
|
|
unsigned width = 0;
|
|
unsigned height = 0;
|
|
};
|
|
|
|
virtual ~RecordableEncodedFrame() = default;
|
|
|
|
// Provides access to encoded data
|
|
virtual rtc::scoped_refptr<const EncodedImageBufferInterface> encoded_buffer()
|
|
const = 0;
|
|
|
|
// Optionally returns the colorspace of the encoded frame. This can differ
|
|
// from the eventually decoded frame's colorspace.
|
|
virtual absl::optional<webrtc::ColorSpace> color_space() const = 0;
|
|
|
|
// Returns the codec of the encoded frame
|
|
virtual VideoCodecType codec() const = 0;
|
|
|
|
// Returns whether the encoded frame is a key frame
|
|
virtual bool is_key_frame() const = 0;
|
|
|
|
// Returns the frame's encoded resolution. May be 0x0 if the frame
|
|
// doesn't contain resolution information
|
|
virtual EncodedResolution resolution() const = 0;
|
|
|
|
// Returns the computed render time
|
|
virtual Timestamp render_time() const = 0;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // API_VIDEO_RECORDABLE_ENCODED_FRAME_H_
|