mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 14:50:39 +01:00

Change log:6ac7929166..eef62e8a0c
Full diff:6ac7929166..eef62e8a0c
Changed dependencies * fuchsia_version: version:14.20230826.1.1..version:15.20230909.2.1 * reclient_version: re_client_version:0.113.0.8b45b89-gomaip..re_client_version:0.114.2.81e819b-gomaip * src/base:609cafa975..10140da63a
* src/build:115a707991..c5658c73de
* src/buildtools:b2043d4f43..a567506e78
* src/buildtools/linux64: git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4..git_revision:991530ce394efb58fcd848195469022fa17ae126 * src/buildtools/mac: git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4..git_revision:991530ce394efb58fcd848195469022fa17ae126 * src/buildtools/reclient: re_client_version:0.113.0.8b45b89-gomaip..re_client_version:0.114.2.81e819b-gomaip * src/buildtools/win: git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4..git_revision:991530ce394efb58fcd848195469022fa17ae126 * src/ios:17864bdc8f..91328c276e
* src/testing:ff8dee88bc..ac71f97e4a
* src/third_party:ee6367daea..935018fd37
* src/third_party/android_build_tools/manifest_merger: kkbYOGsVRXhtxBiXuTufY0puTnG5QAfyxvFTBHFWL08C..FlwnxEZ1wdjoQfedkF4MiZgo8pD48-_CJNA7RnU6as4C * src/third_party/android_toolchain/ndk: R_8suM8m0oHbZ1awdxGXvKEFpAOETscbfZxkkMthyk8C..3vHltFqfgIw8wZ38ggGM9c7Eyw_AHZnwCgFIVtc9gngC * src/third_party/androidx: 2n47PFweHFzGxPWjh9RANTrGhmSDWowZ-YhkOV4j11MC..zIMLlRAldYvFj1UOOB-KZX_1YKfWx4vfYoCYVyF1XUsC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/b8e012e1ff..3aecf1d00b * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b8c4f2d99a..0dfa3b81d7 * src/third_party/depot_tools:427f0f43ad..523537049c
* src/third_party/freetype/src:dd1ced4ee3..d7b63a966b
* src/third_party/kotlin_stdlib: 6cGkpHi3fSRhpRfq2b1mjmzfFmShvtQe6gy4g2nFQd0C..7XCiIAlSi36gvPwOn8N4Q1GE9sMLw6V1RljM9151cWIC * src/third_party/libc++/src:84fb809dd6..7cee6b00d3
* src/third_party/libc++abi/src:3d83ca7bd2..f6a17c88dd
* src/third_party/libunwind/src:76e621a897..d9b4abf6b6
* src/third_party/libvpx/source/libvpx:24c0dcc851..6da1bd01d6
* src/third_party/perfetto:00427277dd..9a3ec114fc
* src/third_party/r8: TBaeKaSTY2ttKx2JSFuWiQ8Na80KHZwLEgSAvT1DBJ0C..WptUn43oi_BkFPtEyZTdUD9wZo1yy8OPVqFwdP3jmqoC * src/third_party/turbine: ZlMS4BOYyYmbU8BuBDGyW7QrkvZ_-pTkm4lH4jKjTi4C..laSnfZnTgkmZynERrjAlU3yeqB5rN446BctGmKQsZ64C * src/tools:3e78ed797e..723bed483d
* src/tools/luci-go: git_revision:fe3cfd422b1012c2c8cf00d65cdb11aa2c26cd66..git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1 * src/tools/luci-go: git_revision:fe3cfd422b1012c2c8cf00d65cdb11aa2c26cd66..git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1 DEPS diff:6ac7929166..eef62e8a0c
/DEPS Clang version changed llvmorg-17-init-16420-g0c545a44:llvmorg-18-init-4631-gd50b56d1 Details:6ac7929166..eef62e8a0c
/tools/clang/scripts/update.py BUG=chromium:1481493,chromium:1483216,b/298960678 Change-Id: I934c827a71d332242ff182de08ba145c8eb8ec04 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320680 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40767}
299 lines
10 KiB
Objective-C
299 lines
10 KiB
Objective-C
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import <XCTest/XCTest.h>
|
|
|
|
#import <Foundation/Foundation.h>
|
|
#import <MetalKit/MetalKit.h>
|
|
#import <OCMock/OCMock.h>
|
|
|
|
#import "components/renderer/metal/RTCMTLVideoView.h"
|
|
|
|
#import "api/video_frame_buffer/RTCNativeI420Buffer.h"
|
|
#import "base/RTCVideoFrameBuffer.h"
|
|
#import "components/renderer/metal/RTCMTLNV12Renderer.h"
|
|
#import "components/video_frame_buffer/RTCCVPixelBuffer.h"
|
|
|
|
static size_t kBufferWidth = 200;
|
|
static size_t kBufferHeight = 200;
|
|
|
|
// Extension of RTC_OBJC_TYPE(RTCMTLVideoView) for testing purposes.
|
|
@interface RTC_OBJC_TYPE (RTCMTLVideoView)
|
|
(Testing)
|
|
|
|
@property(nonatomic, readonly) MTKView *metalView;
|
|
|
|
+ (BOOL)isMetalAvailable;
|
|
+ (UIView *)createMetalView:(CGRect)frame;
|
|
+ (id<RTCMTLRenderer>)createNV12Renderer;
|
|
+ (id<RTCMTLRenderer>)createI420Renderer;
|
|
- (void)drawInMTKView:(id)view;
|
|
@end
|
|
|
|
@interface RTCMTLVideoViewTests : XCTestCase
|
|
@property(nonatomic, strong) id classMock;
|
|
@property(nonatomic, strong) id rendererNV12Mock;
|
|
@property(nonatomic, strong) id rendererI420Mock;
|
|
@property(nonatomic, strong) id frameMock;
|
|
@end
|
|
|
|
@implementation RTCMTLVideoViewTests
|
|
|
|
@synthesize classMock = _classMock;
|
|
@synthesize rendererNV12Mock = _rendererNV12Mock;
|
|
@synthesize rendererI420Mock = _rendererI420Mock;
|
|
@synthesize frameMock = _frameMock;
|
|
|
|
- (void)setUp {
|
|
self.classMock = OCMClassMock([RTC_OBJC_TYPE(RTCMTLVideoView) class]);
|
|
[self startMockingNilView];
|
|
}
|
|
|
|
- (void)tearDown {
|
|
[self.classMock stopMocking];
|
|
[self.rendererI420Mock stopMocking];
|
|
[self.rendererNV12Mock stopMocking];
|
|
[self.frameMock stopMocking];
|
|
self.classMock = nil;
|
|
self.rendererI420Mock = nil;
|
|
self.rendererNV12Mock = nil;
|
|
self.frameMock = nil;
|
|
}
|
|
|
|
- (id)frameMockWithCVPixelBuffer:(BOOL)hasCVPixelBuffer {
|
|
id frameMock = OCMClassMock([RTC_OBJC_TYPE(RTCVideoFrame) class]);
|
|
if (hasCVPixelBuffer) {
|
|
CVPixelBufferRef pixelBufferRef;
|
|
CVPixelBufferCreate(kCFAllocatorDefault,
|
|
kBufferWidth,
|
|
kBufferHeight,
|
|
kCVPixelFormatType_420YpCbCr8Planar,
|
|
nil,
|
|
&pixelBufferRef);
|
|
OCMStub([frameMock buffer])
|
|
.andReturn([[RTC_OBJC_TYPE(RTCCVPixelBuffer) alloc] initWithPixelBuffer:pixelBufferRef]);
|
|
} else {
|
|
OCMStub([frameMock buffer])
|
|
.andReturn([[RTC_OBJC_TYPE(RTCI420Buffer) alloc] initWithWidth:kBufferWidth
|
|
height:kBufferHeight]);
|
|
}
|
|
OCMStub([((RTC_OBJC_TYPE(RTCVideoFrame) *)frameMock) width]).andReturn(kBufferWidth);
|
|
OCMStub([((RTC_OBJC_TYPE(RTCVideoFrame) *)frameMock) height]).andReturn(kBufferHeight);
|
|
OCMStub([frameMock timeStampNs]).andReturn(arc4random_uniform(INT_MAX));
|
|
return frameMock;
|
|
}
|
|
|
|
- (id)rendererMockWithSuccessfulSetup:(BOOL)success {
|
|
id rendererMock = OCMClassMock([RTCMTLRenderer class]);
|
|
OCMStub([rendererMock addRenderingDestination:[OCMArg any]]).andReturn(success);
|
|
return rendererMock;
|
|
}
|
|
|
|
- (void)startMockingNilView {
|
|
// Use OCMock 2 syntax here until OCMock is upgraded to 3.4
|
|
[[[self.classMock stub] andReturn:nil] createMetalView:CGRectZero];
|
|
}
|
|
|
|
#pragma mark - Test cases
|
|
|
|
- (void)testInitAssertsIfMetalUnavailabe {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(NO);
|
|
|
|
// when
|
|
BOOL asserts = NO;
|
|
@try {
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectZero];
|
|
(void)realView;
|
|
} @catch (NSException *ex) {
|
|
asserts = YES;
|
|
}
|
|
|
|
XCTAssertTrue(asserts);
|
|
}
|
|
|
|
- (void)testRTCVideoRenderNilFrameCallback {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
self.frameMock = OCMClassMock([RTC_OBJC_TYPE(RTCVideoFrame) class]);
|
|
|
|
[[self.frameMock reject] buffer];
|
|
[[self.classMock reject] createNV12Renderer];
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
// when
|
|
[realView renderFrame:nil];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
// then
|
|
[self.frameMock verify];
|
|
[self.classMock verify];
|
|
}
|
|
|
|
- (void)testRTCVideoRenderFrameCallbackI420 {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererI420Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:NO];
|
|
|
|
OCMExpect([self.rendererI420Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createI420Renderer]).andReturn(self.rendererI420Mock);
|
|
[[self.classMock reject] createNV12Renderer];
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
|
|
// when
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
// then
|
|
[self.rendererI420Mock verify];
|
|
[self.classMock verify];
|
|
}
|
|
|
|
- (void)testRTCVideoRenderFrameCallbackNV12 {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererNV12Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:YES];
|
|
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createNV12Renderer]).andReturn(self.rendererNV12Mock);
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
|
|
// when
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
// then
|
|
[self.rendererNV12Mock verify];
|
|
[self.classMock verify];
|
|
}
|
|
|
|
- (void)testRTCVideoRenderWorksAfterReconstruction {
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererNV12Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:YES];
|
|
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createNV12Renderer]).andReturn(self.rendererNV12Mock);
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
[self.rendererNV12Mock verify];
|
|
[self.classMock verify];
|
|
|
|
// Recreate view.
|
|
realView = [[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
// View hould reinit renderer.
|
|
OCMExpect([self.classMock createNV12Renderer]).andReturn(self.rendererNV12Mock);
|
|
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
[self.rendererNV12Mock verify];
|
|
[self.classMock verify];
|
|
}
|
|
|
|
- (void)testDontRedrawOldFrame {
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererNV12Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:YES];
|
|
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createNV12Renderer]).andReturn(self.rendererNV12Mock);
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
[self.rendererNV12Mock verify];
|
|
[self.classMock verify];
|
|
|
|
[[self.rendererNV12Mock reject] drawFrame:[OCMArg any]];
|
|
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
[self.rendererNV12Mock verify];
|
|
}
|
|
|
|
- (void)testDoDrawNewFrame {
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererNV12Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:YES];
|
|
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createNV12Renderer]).andReturn(self.rendererNV12Mock);
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
[self.rendererNV12Mock verify];
|
|
[self.classMock verify];
|
|
|
|
// Get new frame.
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:YES];
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:realView.metalView];
|
|
|
|
[self.rendererNV12Mock verify];
|
|
}
|
|
|
|
- (void)testReportsSizeChangesToDelegate {
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
|
|
id delegateMock = OCMProtocolMock(@protocol(RTC_OBJC_TYPE(RTCVideoViewDelegate)));
|
|
CGSize size = CGSizeMake(640, 480);
|
|
OCMExpect([delegateMock videoView:[OCMArg any] didChangeVideoSize:size]);
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView =
|
|
[[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] initWithFrame:CGRectMake(0, 0, 640, 480)];
|
|
realView.delegate = delegateMock;
|
|
[realView setSize:size];
|
|
|
|
// Delegate method is invoked with a dispatch_async.
|
|
OCMVerifyAllWithDelay(delegateMock, 1);
|
|
}
|
|
|
|
// TODO(b/298960678): Fix test expectations.
|
|
- (void)DISABLED_testSetContentMode {
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
id metalKitView = OCMClassMock([MTKView class]);
|
|
[[[[self.classMock stub] ignoringNonObjectArgs] andReturn:metalKitView]
|
|
createMetalView:CGRectZero];
|
|
OCMExpect([metalKitView setContentMode:UIViewContentModeScaleAspectFill]);
|
|
|
|
RTC_OBJC_TYPE(RTCMTLVideoView) *realView = [[RTC_OBJC_TYPE(RTCMTLVideoView) alloc] init];
|
|
[realView setVideoContentMode:UIViewContentModeScaleAspectFill];
|
|
|
|
OCMVerifyAll(metalKitView);
|
|
}
|
|
|
|
@end
|