mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
928146f546
This CL removes all external access to the integer sample data in the AudioBuffer class. It also removes the API in AudioBuffer that provides this. The purpose of this is to pave the way for removing the sample duplicating and implicit conversions between integer and floating point sample formats which is done inside the AudioBuffer. Bug: webrtc:10882 Change-Id: I1438b691bcef98278aef8e3c63624c367c2d12e9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149162 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28912}
51 lines
1.9 KiB
C++
51 lines
1.9 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/audio_processing/include/audio_frame_view.h"
|
|
|
|
#include "modules/audio_processing/audio_buffer.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
TEST(AudioFrameTest, ConstructFromAudioBuffer) {
|
|
constexpr int kSampleRateHz = 48000;
|
|
constexpr int kNumChannels = 2;
|
|
constexpr float kFloatConstant = 1272.f;
|
|
constexpr float kIntConstant = 17252;
|
|
const webrtc::StreamConfig stream_config(kSampleRateHz, kNumChannels, false);
|
|
webrtc::AudioBuffer buffer(
|
|
stream_config.num_frames(), stream_config.num_channels(),
|
|
stream_config.num_frames(), stream_config.num_channels(),
|
|
stream_config.num_frames());
|
|
|
|
AudioFrameView<float> non_const_view(
|
|
buffer.channels_f(), buffer.num_channels(), buffer.num_frames());
|
|
// Modification is allowed.
|
|
non_const_view.channel(0)[0] = kFloatConstant;
|
|
EXPECT_EQ(buffer.channels_f()[0][0], kFloatConstant);
|
|
|
|
AudioFrameView<const float> const_view(
|
|
buffer.channels_f(), buffer.num_channels(), buffer.num_frames());
|
|
// Modification is not allowed.
|
|
// const_view.channel(0)[0] = kFloatConstant;
|
|
|
|
// Assignment is allowed.
|
|
AudioFrameView<const float> other_const_view = non_const_view;
|
|
static_cast<void>(other_const_view);
|
|
|
|
// But not the other way. The following will fail:
|
|
// non_const_view = other_const_view;
|
|
|
|
AudioFrameView<float> non_const_float_view(
|
|
buffer.channels_f(), buffer.num_channels(), buffer.num_frames());
|
|
non_const_float_view.channel(0)[0] = kIntConstant;
|
|
EXPECT_EQ(buffer.channels_f()[0][0], kIntConstant);
|
|
}
|
|
} // namespace webrtc
|