mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 06:10:40 +01:00
e1795f4158
This adds the RemoteEstimate rtcp packet and wires it up to GoogCC where it's used to improve congestion controller behavior. The functionality is negotiated using SDP. It's added with a field trial that allow disabling the functionality in case there's any issues. Bug: webrtc:10742 Change-Id: I1ea8e4216a27cd2b00505c99b42d1e38726256c8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146602 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28654}
56 lines
2.3 KiB
C++
56 lines
2.3 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "modules/rtp_rtcp/source/rtcp_packet/remote_estimate.h"
|
|
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace rtcp {
|
|
TEST(RemoteEstimateTest, EncodesCapacityBounds) {
|
|
NetworkStateEstimate src;
|
|
src.link_capacity_lower = DataRate::kbps(10);
|
|
src.link_capacity_upper = DataRate::kbps(1000000);
|
|
rtc::Buffer data = GetRemoteEstimateSerializer()->Serialize(src);
|
|
NetworkStateEstimate dst;
|
|
EXPECT_TRUE(GetRemoteEstimateSerializer()->Parse(data, &dst));
|
|
EXPECT_EQ(src.link_capacity_lower, dst.link_capacity_lower);
|
|
EXPECT_EQ(src.link_capacity_upper, dst.link_capacity_upper);
|
|
}
|
|
|
|
TEST(RemoteEstimateTest, ExpandsToPlusInfinity) {
|
|
NetworkStateEstimate src;
|
|
// White box testing: We know that the value is stored in an unsigned 24 int
|
|
// with kbps resolution. We expected it be represented as plus infinity.
|
|
src.link_capacity_lower = DataRate::kbps(2 << 24);
|
|
src.link_capacity_upper = DataRate::PlusInfinity();
|
|
rtc::Buffer data = GetRemoteEstimateSerializer()->Serialize(src);
|
|
|
|
NetworkStateEstimate dst;
|
|
EXPECT_TRUE(GetRemoteEstimateSerializer()->Parse(data, &dst));
|
|
EXPECT_TRUE(dst.link_capacity_lower.IsPlusInfinity());
|
|
EXPECT_TRUE(dst.link_capacity_upper.IsPlusInfinity());
|
|
}
|
|
|
|
TEST(RemoteEstimateTest, DoesNotEncodeNegative) {
|
|
NetworkStateEstimate src;
|
|
src.link_capacity_lower = DataRate::MinusInfinity();
|
|
src.link_capacity_upper = DataRate::MinusInfinity();
|
|
rtc::Buffer data = GetRemoteEstimateSerializer()->Serialize(src);
|
|
// Since MinusInfinity can't be represented, the buffer should be empty.
|
|
EXPECT_EQ(data.size(), 0u);
|
|
NetworkStateEstimate dst;
|
|
dst.link_capacity_lower = DataRate::kbps(300);
|
|
EXPECT_TRUE(GetRemoteEstimateSerializer()->Parse(data, &dst));
|
|
// The fields will be left unchanged by the parser as they were not encoded.
|
|
EXPECT_EQ(dst.link_capacity_lower, DataRate::kbps(300));
|
|
EXPECT_TRUE(dst.link_capacity_upper.IsMinusInfinity());
|
|
}
|
|
} // namespace rtcp
|
|
} // namespace webrtc
|